[Enabler][zos_blockinfile]Add_documentation_of_false_negatives_and_ensure_proper_testing #2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreMarcel99
requested review from
fernandofloresg,
rexemin,
richp405 and
surendrababuravella
richp405
approved these changes
Mar 26, 2025
Collaborator
richp405
left a comment
richp405
left a comment
There was a problem hiding this comment.
I'm approving, but strongly recommend to re-work the commend in zos_blockinfile.py.
plugins/modules/zos_blockinfile.py
Outdated
| - When more then one block should be handled in a file you must change | ||
| the I(marker) per task. | ||
| - When working with a backup of a sequential dataset to avoid false positive | ||
| backup name should be a sequential dataset too, not a member of pds or pdse. |
Collaborator
There was a problem hiding this comment.
The wording is challenging. I'd suggest something like:
"When working with a backup of a sequential dataset, the backup name should also be a sequential dataset. This will avoid the false positive and error condition during backup. "
The comma, reordering, and eliminating the word 'too' should help make this more readable.
fernandofloresg
requested changes
Mar 26, 2025
plugins/modules/zos_blockinfile.py
Outdated
| - When more then one block should be handled in a file you must change | ||
| the I(marker) per task. | ||
| - When working with a backup of a sequential dataset to avoid false positive | ||
| backup name should be a sequential dataset too, not a member of pds or pdse. |
fernandofloresg
approved these changes
Mar 27, 2025
Collaborator
fernandofloresg
left a comment
fernandofloresg
left a comment
There was a problem hiding this comment.
Looks good to me
fernandofloresg
deleted the
enabler/629/test_case_blockinfile_false_positive
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Previous we have some false positives cases with backup, to avoid false positives and verify the proper work of the module is required to add the backup validation, fixing #629, but open a new issue been #2024 to work on a specific problem of backups, if the backup required to be same time as the original MVS or could be SEQ with PDS, meanwhile, add to the documentation how avoid false positives.
ISSUE TYPE
COMPONENT NAME
Verify the type of backup is use and verify the content of the backup.
