[Release] Staging v1.11.0-beta.1 into main #1646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Staging v1.7.0 beta.1 (#915) * Added tagging of converted files * Updated tests for zos_encode * Added restoration of PDS/PDSE members when module fails zos_copy can now track which members got overwritten or newly added to a partitioned data set, and restore them accordingly. This commit includes a refactorization of the copy_to_pdse method to simplify the restoration work. * Fixed cleanup of dest when module fails * Removed exception used for debugging * Added pytest markers * solved pep8 issue * Added more information to error when restoration fails * Update make file with new features to manage the nodes (#563) * Update make file with new features to manage the nodes Signed-off-by: ddimatos <dimatos@gmail.com> * Correct typo Signed-off-by: ddimatos <dimatos@gmail.com> * updated makefile to allow for no password in the clear and added a new host Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Fix a bug that failed to copy the cert to the managed node (#577) Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Added apropiate error message in zos_lineinfile when src is not found * Better error message * Added fragment for changelog * Update git issue slection field (#593) * Update git issue slection field * Added some additional future versions * Added rule to ignore python 2.7 compile not supporting f strings * Corrected rule in ignore file * Update 584-zos_lineinfile-error-message.yml * Added missing fragments for issues 309 and 408 * update make file and related artifacts with recent zVM changes (#598) Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Expand what is ingored for venv to all venv's (#613) Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Ansible-core versions with updated ignore file pass (#615) * Validated that ansible-core versions with updated ignore file pass locally Signed-off-by: ddimatos <dimatos@gmail.com> * remove redundant entry on last line Signed-off-by: ddimatos <dimatos@gmail.com> * remove redundant entry on last line Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Update make file to read exported var VENV else default to 'venv' (#614) * Update make file to read exported var VENV else default to 'venv' Signed-off-by: ddimatos <dimatos@gmail.com> * Correct the default from defaultValue to 'venv' Signed-off-by: ddimatos <dimatos@gmail.com> * Bugfix/558/zos copy backup dev (#609) * Create emergency backup only if force is set to False and dest exists * Added Changelog fragment * Updated imports ansible.module_utils._text to ansible.module_utils.common.text.converters (#602) * Updated import in zos_fetch * Updated import in zos_job_submit * Updated import in module_utils/data_set * Updated import in module_utils/System * Updated import in zos_copy * Updated import in zos_fetch * Added changelog fragment * Update enhancement-518-text-converter-import.yml * Updates the makefile and related scripts for the latest mounts (#628) * Update makefile coments and use --ignore for pytest Signed-off-by: ddimatos <dimatos@gmail.com> * lexicographical order targets Signed-off-by: ddimatos <dimatos@gmail.com> * Update makefile and artifacts to support new mounts Signed-off-by: ddimatos <dimatos@gmail.com> * Removing encrypted versions of the scripts, no longer senstive content Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * update profile created for mount points Signed-off-by: ddimatos <dimatos@gmail.com> * Correct f-string usage to remain 2.7 compatible (#659) * Correct f-string usage to remain 2.7 compatible Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Updated shell scripts for development tooling Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Update collab template Signed-off-by: ddimatos <dimatos@gmail.com> * Update collab template Signed-off-by: ddimatos <dimatos@gmail.com> * Update collab template Signed-off-by: ddimatos <dimatos@gmail.com> * Template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Template updates Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * changed zos_job_query to allow multi/embedded wildcard job_values. job.py/_get_job_status now uses fnmatch to test for wildcarded job_names. added test looking for a wildcard job name. added basic changelog text as 'enhancement'. * expanded wildcard support to job_id as well as job_name corrected error-handling issue in query routine playbook tests complete * cleaned up pep8 issues * Bug fix to correct job log returining and other edge cases (#683) * Update zos_job_submit to handle some edge cases and return the job log nearly always Signed-off-by: ddimatos <dimatos@gmail.com> * Linting correction Signed-off-by: ddimatos <dimatos@gmail.com> * Add changelog fragement for pr 683 Signed-off-by: ddimatos <dimatos@gmail.com> * Clean up comments in code Signed-off-by: ddimatos <dimatos@gmail.com> * Update restructured text for modules and changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Add support to check for security exception to job submit module Signed-off-by: ddimatos <dimatos@gmail.com> * Add additonal logic for jobs that use typerun=scan Signed-off-by: ddimatos <dimatos@gmail.com> * Update chnagelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Update zos_job_submit.py Grammar change and correction. --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Added uss_tag_encoding function * Fixing linter issues * removed extraneous comment on query, eliminated unused variable * responding to reviewer comments * Expanded query tests to run a hello jcl file to make sure we are searching for a job id that exists. * Expanded documentation in code to highlight asterisk availability. Added examples showing multi-asterisk search. * Corrected 2 documentation errors * Change to documentation text (indent on multi line string?) * Still trying to get documentation to pass * Looks like '---' was killing documentation block. * Update zos_blockinfile with complex examples (#727) * Update zos_blockinfile with complex examples Signed-off-by: ddimatos <dimatos@gmail.com> * Add changelog fragement Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Added additional D SYMBOLS example to zos_operator documentation (#730) * Update zos_operator with an additional example Signed-off-by: ddimatos <dimatos@gmail.com> * Added changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * zos_gather_facts - add sample output to RETURN docstring (#722) * zos_gather_facts - add sample output to RETURN docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add changelog fragment Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * zos_gather_facts RETURN docstring - add sample sysplex_name and lpar_name values Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * Update generated module doc Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> * 574find (#668) * change to allow find loop to continue when one particular data set element is not found This has been validated with a zos-check-find.yaml playbook * added functional test that includes non-existant pds entry, which should be skipped over * added changelog fragment. * zos_blockinfile , can quotes in content can be supported (#680) * Verify coomand of ZOAU support the doble quotes and get better output of message * Verify coomand of ZOAU support the doble quotes and get better output of message * Restore to the one tyme function solving TypeError * Test about cases with quotes supported * Solve comments * Comments in the changelog * Adjust test for working accord the text * A needed space * All in structured * Comments solved * Better order --------- Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> Co-authored-by: Demetri <dimatos@gmail.com> * zos_copy mode is applied to the destination directory, a deviation from the communtiy module behavior. (#723) * Verify coomand of ZOAU support the doble quotes and get better output of message * Verify coomand of ZOAU support the doble quotes and get better output of message * Restore to the one tyme function solving TypeError * Test about cases with quotes supported * Solve comments * Comments in the changelog * Adjust test for working accord the text * Solve the dest functional mode set for the applied to destination directory * Identation and spaces * To work well * To work well * To work well * To work well * Changelogs added * Solved the fragment test and separte the cases --------- Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> * corrected job test case that wanted to extract job id. * changed call to zos_job_query in the functional test. * zos_data_set - add force parameter to enable member delete via disp shr (#718) * add force parameter to enable member delete via disp shr Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update link to PR instead of issue Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * fix minor mistake in func test Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update DOCstring for missed items highlighted in PR review Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update copyright years in data set module util Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> --------- Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * Update changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Update to doc and examples Signed-off-by: ddimatos <dimatos@gmail.com> * Update to doc and examples Signed-off-by: ddimatos <dimatos@gmail.com> * Update to doc and examples Signed-off-by: ddimatos <dimatos@gmail.com> * update doc, rst Signed-off-by: ddimatos <dimatos@gmail.com> * Update doc and examples Signed-off-by: ddimatos <dimatos@gmail.com> * Added handler for job not found edge cases (None not iterable errors) * corrected pep8 issue (bad indent) * removed tracking text from error/not found messages. * Update zos_job_query.py * Add and automate a load lib test case for module zos_copy (#640) * Modified if statement * Added changelog fragment * Corrected statements Corrected PR in changelog fix lint issue * Adding test case on the work * Added assertion to loadlib test Changed cobol src Added newlines * Correcting cobol src * Removed unnecessary comments * Removed deprint statements for debug * Update 601-copy-loadlib-member.yml * Reduce space primary * Make sure cobol is executable * corrected name * Corrected names * Adding debug statements * modified name in link step * Changing copy name * Removed print statements for debug * Removed previous changelog * Removed unused fragment * Removed test case * Add max_rc support for module zos_tso_command (#666) * rebuilding 565 * fixing pep8 issue * corrected not in code, added functional test to use maxrc * changing maxrc return codes as indicated * updated copy_rexx to incorporate max_rc * pep8 issue on an if statement * changed test to dump intermediate values temporarily * added max_rc to arg params to get it to pass through * removed extra output on test * Added changelog fragment. * Update 565-zos_tsocommand_maxrc.yml * PARTIAL correction based on reviewer's feedback. Will complete later today. * Partial push: change origrc to orig_rc and added documentation. Added experimental loop for multiline results. Changed error case to continue through the commands even after a failure (?!) * Changes based on review feedback: - rc is actual returned value - origrc/orig_rc removed - in a list of commands, first error (considering max_rc) stops the chain - while processing commands, a list of success/failures are kept for error state info - changed listds to a longer, more complete string in example * updated test case for max_rc to use longer, more complete listds command * Minor pep8 and yamllint changes * Updated string builder to use append and join, for efficiency. * Update changelog fragment to correspond to pull request number Signed-off-by: ddimatos <dimatos@gmail.com> * removed old fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Changed output of command-by-command to use max_rc instead of Max RC, for consistency. * clarifying failure message when user hasn't set a max_rc. * corrected date on copyright notice to include current year. * corrected copyright date on test case --------- Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Demetri <dimatos@gmail.com> * added changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * zos_copy forward port a test case for symbols on a volume #739 (#740) * added test case for symbols on a volume Signed-off-by: ddimatos <dimatos@gmail.com> * Changelog fragment added Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with added comments Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Volume Initialization Module (#654) * Adding ZOS_INIT plugins The module and action for ZOS_Init command, under zos_ickdsf_command. Designed for version 1.3.1, and example given references removed zos_ssh.py. * Create zos_ickdsf_command.rst Tentative documentation. Does not quite list every return, and program may change to work with overall zos core collection. * Update zos_ickdsf_command.py fixed to pass pep8 sanity test. * Update zos_ickdsf_command.py Edited zos_ickdsf_command.py in action folder to pass pep8 style check. * bugfix - undo hard-coded storagegroup param from command passed to mvs_raw Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update encoding and licensing info Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * edit descriptions, leaving in old to verify messaging with dfsms team Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove references to buildix Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * cleanup examples docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add return docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add some unit tests Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update dict names, some clean up Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update interface and docs with cleaner descriptions and define default values and required true/false where applicable Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove init param and bring out sub-options one level Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * rename module from zos_ickdsf_command to zos_ickdsf_init Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove files referring to zos_ickdsf_command; i forgot to untrack these in the previous commit Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove params from intitial definition of results dict which are not always present, remove unused return params, rename message to msg to match ibm_zos_core and ansible style Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add ignore missing gplv3 license warning from sanity testings to existing ignore files Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * style edits to pass sanity tests Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add in-depth task name to first example docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add minimal params functional test Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * convert action plugin to module_util, remove IckdsfCommand and CommandInit class definitions and custom error classes, move convert method to module_util Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * rename rc param, update func test Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add note about disabled verify_offline check Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * removed volume_address checks which can be handled by ansiblemodule parsing validation or ickdsf itself; changed function signature of convert method to include results dicts so it can pass it to fail_json method in the case of module failure Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add invalid volume_address func tests Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * change param names, organize mvscmd return output Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * consolidate negative func tests, add negative tests for vtoc_tracks param, start list for postive tests to implement Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add func tests for "verify_existing_volid" and "verify_no_data_sets_exist" Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add volid positive and negative func tests Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add mutual exclusion to no index/sms_managedw with func test, minor edits to comments * add func tests for index param Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add func test for vtoc_tracks param Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove 'addr_range', 'volid_prefix' and 'output_html' params; add example with ansible loop to init multiple serial volumes Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * convert 'content' return param to list for prettier playbook output Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add specific examples to docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add guard rail test with volser check set to ensure target volume is as expected Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * switch target test vol to user02, remove existing data sets in initial test Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * start adding author names to docstring, edits of yaml for sanity test Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * rename module to zos_volume_init Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove unit test suite which was not kept up to date with code restructure Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove old/outdated .rst file Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * bring up to speed with v1.5.0-beta.1 which is currently more recent than dev Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add sanity test 2.15 file Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * clean up trailing empty lines/space chars Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * more pep8 style Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * pull in more changes from latest dev branch Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * tweak tests/sanity/ignore-2.10.txt file Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * rename volume_address to address, rename verify_no_data_sets_exist to verify_volume_empty, rename verify_existing_volid to verify_volid, rename vtoc_tracks to vtoc_size, rename return param command to cmd, make suggested doc changes, switch off check_mode Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * resolve pep8 line too long issue Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add year to copyright, add gh user name to author, restyle true/false with code rather than italics, remove backslashes in docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add changelog fragment Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update zos_fetch test case to create data set instead of using one that gets wiped away by zos_volume_init test cases Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * address PR comments including pep8 styling, docstring changes including add seealso section, add details around authorized usage of ickdsf, some light wordsmithing, and remove cmd from return structure Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add backticks to other special chars in docs for consistency Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * on more formatting tweak to national chars in docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add new param to support tmp_hlq Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * extend tmphlq binding to sysprint(*), disable verbose mode for mvscmd call Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove references to betterargparser - it cannot be used in its current state as it is too restrictive on volume serial and qualifier args Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove soft language ie beware, please; reduce line lengths, fix a spelling error Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * reorganize test case code for more logical grouping and un-nesting from a for loop, also update copyright year that was missed Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update display command check to only check particular lines instead of entire output in test_volid_address_assigned_correctly which would always be positive when tested against the entire output Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> --------- Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> Co-authored-by: trevor-glassey <Trevor.Glassey@ibm.com> * Ported bugfixes for #664 and #678 from 1.5.0 (#743) * Ported bugfixes for #664 and #678 * Updated file normalization for sequential datasets * Fixed encoding when a remote source is used * Added encoding normalization for record length (#664) This is a port and tweak from the normalization found in the L2 support branch. Now the normalization applies for both local and remote source files. There is still work left to validate how this behaves when copying to partitioned datasets, and see if the normalization needs to handle directories as well. * Refactored normalization for USS files * Updated line endings normalization in PDSEs * Updated create_temp_with_lf_endings * Added tests for line endings normalization * Added changelog fragment * Updated changelog fragment * Updated copyright information * Added comments to record length tests * Added more context to the record length normalization * Add force (disp=shr) option to zos_lineinfile and update zos_blockinfile with the same locking test case. (#731) * Add DISP=SHR by function force to the user * Add helper function for force cases only for EOF inserts * Test cases added * Just to check in the change case * All test cases for force in zos_lineinfile working properly * Test cases for force blockinfile * Fixes for style of code * One identation error * One identation error * One identation error * Documentation error * All test cases for line infile and block infile * Comments * Change the stdout to assert with expected of ds * Error of test case * Fragment added * Solve typo errors * Update to remove uncessary comment Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with force comments Signed-off-by: ddimatos <dimatos@gmail.com> * Solve some test problems * Copyright year * Copyright year * Add cases for other ecodes * Add test for all encodings * Cover all encodes test cases with force * Blockinfile force added for other encodes and DS types --------- Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> Co-authored-by: Andre Marcel Gutierrez Benitez <andre@mbp-de-andre-2.gdl.mex.ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * remove duplicate function (#753) * Update branch production branch Main with release v1.5.0 content (#756) (#758) * Bug fix to correct job log returining and other edge cases (#688) * Update zos_job_submit to handle some edge cases and return the job log nearly always * Linting correction * Add changelog fragement for pr 683 * Clean up comments in code * Update restructured text for modules and changelog fragment * Add support to check for security exception to job submit module * Add additonal logic for jobs that use typerun=scan * Update chnagelog fragment * Correct run on sentence --------- * Added additional `D SYMBOLS` example to zos_operator documentation (#729) * Update zos_operator with an additional example * Added change fragment --------- * Ported bugfixes for #664 and #678 * Updated file normalization for sequential datasets * Fixed encoding when a remote source is used * Added encoding normalization for record length (#664) This is a port and tweak from the normalization found in the L2 support branch. Now the normalization applies for both local and remote source files. There is still work left to validate how this behaves when copying to partitioned datasets, and see if the normalization needs to handle directories as well. * Refactored normalization for USS files * Updated line endings normalization in PDSEs * Updated create_temp_with_lf_endings * Added tests for line endings normalization * Added changelog fragment * Add copy lib member test case * Corrected changelog fragment * Add conflict resolution * Update 641-copy-loadlib-member.yml * zos_copy forward port a test case for symbols on a volume (#739) * Add a test case for symbols using an existing volume on our test system * Add changelog fragment * Update 739-zos_copy-volume-symbol-test.yml Update description to use symbols overs special chars. * Update test case with added comments --------- * bring in updates to zos_gather_facts RETURN docstring (#744) * Solve problem 619 about set mode on dest file (#746) * Solve problem 619 about set mode on dest file * Add fragment of 746 PR --------- * Merge release tasks for v1.5.0 into release branch (#752) * Updated metadata * Updated copyright information * Updated copyright in README * Generated changelog * Added previous versions to changelog * Changed a minor_change fragment to bugfix * Updated release notes * Update dependency finder to allow for all tests minus skip tests * Update release notes and changelog with full date formats --------- * remove changelog fragments no longer needed (#754) --------- Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> Co-authored-by: Ivan Moreno <iamorenosoto@gmail.com> Co-authored-by: Fernando Flores <fernandofloresdev@gmail.com> Co-authored-by: Rich Parker <richp405@gmail.com> Co-authored-by: ketankelkar <ktnklkr@gmail.com> Co-authored-by: André Marcel Gutiérrez Benítez <68956970+AndreMarcel99@users.noreply.github.com> Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> * Merge master to dev for 1.6.0 beta.1 (#763) * Update branch production branch Main with release v1.5.0 content (#756) * Bug fix to correct job log returining and other edge cases (#688) * Update zos_job_submit to handle some edge cases and return the job log nearly always Signed-off-by: ddimatos <dimatos@gmail.com> * Linting correction Signed-off-by: ddimatos <dimatos@gmail.com> * Add changelog fragement for pr 683 Signed-off-by: ddimatos <dimatos@gmail.com> * Clean up comments in code Signed-off-by: ddimatos <dimatos@gmail.com> * Update restructured text for modules and changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Add support to check for security exception to job submit module Signed-off-by: ddimatos <dimatos@gmail.com> * Add additonal logic for jobs that use typerun=scan Signed-off-by: ddimatos <dimatos@gmail.com> * Update chnagelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Correct run on sentence Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Added additional `D SYMBOLS` example to zos_operator documentation (#729) * Update zos_operator with an additional example Signed-off-by: ddimatos <dimatos@gmail.com> * Added change fragment Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Ported bugfixes for #664 and #678 * Updated file normalization for sequential datasets * Fixed encoding when a remote source is used * Added encoding normalization for record length (#664) This is a port and tweak from the normalization found in the L2 support branch. Now the normalization applies for both local and remote source files. There is still work left to validate how this behaves when copying to partitioned datasets, and see if the normalization needs to handle directories as well. * Refactored normalization for USS files * Updated line endings normalization in PDSEs * Updated create_temp_with_lf_endings * Added tests for line endings normalization * Added changelog fragment * Add copy lib member test case * Corrected changelog fragment * Add conflict resolution * Update 641-copy-loadlib-member.yml * zos_copy forward port a test case for symbols on a volume (#739) * Add a test case for symbols using an existing volume on our test system Signed-off-by: ddimatos <dimatos@gmail.com> * Add changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Update 739-zos_copy-volume-symbol-test.yml Update description to use symbols overs special chars. * Update test case with added comments Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * bring in updates to zos_gather_facts RETURN docstring (#744) Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * Solve problem 619 about set mode on dest file (#746) * Solve problem 619 about set mode on dest file * Add fragment of 746 PR --------- Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> * Merge release tasks for v1.5.0 into release branch (#752) * Updated metadata * Updated copyright information * Updated copyright in README * Generated changelog * Added previous versions to changelog * Changed a minor_change fragment to bugfix * Updated release notes * Update dependency finder to allow for all tests minus skip tests Signed-off-by: ddimatos <dimatos@gmail.com> * Update release notes and changelog with full date formats Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> * remove changelog fragments no longer needed (#754) Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> Co-authored-by: Ivan Moreno <iamorenosoto@gmail.com> Co-authored-by: Fernando Flores <fernandofloresdev@gmail.com> Co-authored-by: Rich Parker <richp405@gmail.com> Co-authored-by: ketankelkar <ktnklkr@gmail.com> Co-authored-by: André Marcel Gutiérrez Benítez <68956970+AndreMarcel99@users.noreply.github.com> Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> * v1.6.0-beta.1 release (#759) * Added tagging of converted files * Updated tests for zos_encode * Added restoration of PDS/PDSE members when module fails zos_copy can now track which members got overwritten or newly added to a partitioned data set, and restore them accordingly. This commit includes a refactorization of the copy_to_pdse method to simplify the restoration work. * Fixed cleanup of dest when module fails * Removed exception used for debugging * Added pytest markers * solved pep8 issue * Added more information to error when restoration fails * Update make file with new features to manage the nodes (#563) * Update make file with new features to manage the nodes Signed-off-by: ddimatos <dimatos@gmail.com> * Correct typo Signed-off-by: ddimatos <dimatos@gmail.com> * updated makefile to allow for no password in the clear and added a new host Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Fix a bug that failed to copy the cert to the managed node (#577) Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Added apropiate error message in zos_lineinfile when src is not found * Better error message * Added fragment for changelog * Update git issue slection field (#593) * Update git issue slection field * Added some additional future versions * Added rule to ignore python 2.7 compile not supporting f strings * Corrected rule in ignore file * Update 584-zos_lineinfile-error-message.yml * Added missing fragments for issues 309 and 408 * update make file and related artifacts with recent zVM changes (#598) Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Expand what is ingored for venv to all venv's (#613) Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Ansible-core versions with updated ignore file pass (#615) * Validated that ansible-core versions with updated ignore file pass locally Signed-off-by: ddimatos <dimatos@gmail.com> * remove redundant entry on last line Signed-off-by: ddimatos <dimatos@gmail.com> * remove redundant entry on last line Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Update make file to read exported var VENV else default to 'venv' (#614) * Update make file to read exported var VENV else default to 'venv' Signed-off-by: ddimatos <dimatos@gmail.com> * Correct the default from defaultValue to 'venv' Signed-off-by: ddimatos <dimatos@gmail.com> * Bugfix/558/zos copy backup dev (#609) * Create emergency backup only if force is set to False and dest exists * Added Changelog fragment * Updated imports ansible.module_utils._text to ansible.module_utils.common.text.converters (#602) * Updated import in zos_fetch * Updated import in zos_job_submit * Updated import in module_utils/data_set * Updated import in module_utils/System * Updated import in zos_copy * Updated import in zos_fetch * Added changelog fragment * Update enhancement-518-text-converter-import.yml * Updates the makefile and related scripts for the latest mounts (#628) * Update makefile coments and use --ignore for pytest Signed-off-by: ddimatos <dimatos@gmail.com> * lexicographical order targets Signed-off-by: ddimatos <dimatos@gmail.com> * Update makefile and artifacts to support new mounts Signed-off-by: ddimatos <dimatos@gmail.com> * Removing encrypted versions of the scripts, no longer senstive content Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * update profile created for mount points Signed-off-by: ddimatos <dimatos@gmail.com> * Correct f-string usage to remain 2.7 compatible (#659) * Correct f-string usage to remain 2.7 compatible Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Updated shell scripts for development tooling Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Update collab template Signed-off-by: ddimatos <dimatos@gmail.com> * Update collab template Signed-off-by: ddimatos <dimatos@gmail.com> * Update collab template Signed-off-by: ddimatos <dimatos@gmail.com> * Template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Template updates Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * changed zos_job_query to allow multi/embedded wildcard job_values. job.py/_get_job_status now uses fnmatch to test for wildcarded job_names. added test looking for a wildcard job name. added basic changelog text as 'enhancement'. * expanded wildcard support to job_id as well as job_name corrected error-handling issue in query routine playbook tests complete * cleaned up pep8 issues * Bug fix to correct job log returining and other edge cases (#683) * Update zos_job_submit to handle some edge cases and return the job log nearly always Signed-off-by: ddimatos <dimatos@gmail.com> * Linting correction Signed-off-by: ddimatos <dimatos@gmail.com> * Add changelog fragement for pr 683 Signed-off-by: ddimatos <dimatos@gmail.com> * Clean up comments in code Signed-off-by: ddimatos <dimatos@gmail.com> * Update restructured text for modules and changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Add support to check for security exception to job submit module Signed-off-by: ddimatos <dimatos@gmail.com> * Add additonal logic for jobs that use typerun=scan Signed-off-by: ddimatos <dimatos@gmail.com> * Update chnagelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Update zos_job_submit.py Grammar change and correction. --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Added uss_tag_encoding function * Fixing linter issues * removed extraneous comment on query, eliminated unused variable * responding to reviewer comments * Expanded query tests to run a hello jcl file to make sure we are searching for a job id that exists. * Expanded documentation in code to highlight asterisk availability. Added examples showing multi-asterisk search. * Corrected 2 documentation errors * Change to documentation text (indent on multi line string?) * Still trying to get documentation to pass * Looks like '---' was killing documentation block. * Update zos_blockinfile with complex examples (#727) * Update zos_blockinfile with complex examples Signed-off-by: ddimatos <dimatos@gmail.com> * Add changelog fragement Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Added additional D SYMBOLS example to zos_operator documentation (#730) * Update zos_operator with an additional example Signed-off-by: ddimatos <dimatos@gmail.com> * Added changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * zos_gather_facts - add sample output to RETURN docstring (#722) * zos_gather_facts - add sample output to RETURN docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add changelog fragment Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * zos_gather_facts RETURN docstring - add sample sysplex_name and lpar_name values Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * Update generated module doc Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> * 574find (#668) * change to allow find loop to continue when one particular data set element is not found This has been validated with a zos-check-find.yaml playbook * added functional test that includes non-existant pds entry, which should be skipped over * added changelog fragment. * zos_blockinfile , can quotes in content can be supported (#680) * Verify coomand of ZOAU support the doble quotes and get better output of message * Verify coomand of ZOAU support the doble quotes and get better output of message * Restore to the one tyme function solving TypeError * Test about cases with quotes supported * Solve comments * Comments in the changelog * Adjust test for working accord the text * A needed space * All in structured * Comments solved * Better order --------- Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> Co-authored-by: Demetri <dimatos@gmail.com> * zos_copy mode is applied to the destination directory, a deviation from the communtiy module behavior. (#723) * Verify coomand of ZOAU support the doble quotes and get better output of message * Verify coomand of ZOAU support the doble quotes and get better output of message * Restore to the one tyme function solving TypeError * Test about cases with quotes supported * Solve comments * Comments in the changelog * Adjust test for working accord the text * Solve the dest functional mode set for the applied to destination directory * Identation and spaces * To work well * To work well * To work well * To work well * Changelogs added * Solved the fragment test and separte the cases --------- Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> * corrected job test case that wanted to extract job id. * changed call to zos_job_query in the functional test. * zos_data_set - add force parameter to enable member delete via disp shr (#718) * add force parameter to enable member delete via disp shr Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update link to PR instead of issue Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * fix minor mistake in func test Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update DOCstring for missed items highlighted in PR review Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update copyright years in data set module util Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> --------- Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * Update changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Update to doc and examples Signed-off-by: ddimatos <dimatos@gmail.com> * Update to doc and examples Signed-off-by: ddimatos <dimatos@gmail.com> * Update to doc and examples Signed-off-by: ddimatos <dimatos@gmail.com> * update doc, rst Signed-off-by: ddimatos <dimatos@gmail.com> * Update doc and examples Signed-off-by: ddimatos <dimatos@gmail.com> * Added handler for job not found edge cases (None not iterable errors) * corrected pep8 issue (bad indent) * removed tracking text from error/not found messages. * Update zos_job_query.py * Add and automate a load lib test case for module zos_copy (#640) * Modified if statement * Added changelog fragment * Corrected statements Corrected PR in changelog fix lint issue * Adding test case on the work * Added assertion to loadlib test Changed cobol src Added newlines * Correcting cobol src * Removed unnecessary comments * Removed deprint statements for debug * Update 601-copy-loadlib-member.yml * Reduce space primary * Make sure cobol is executable * corrected name * Corrected names * Adding debug statements * modified name in link step * Changing copy name * Removed print statements for debug * Removed previous changelog * Removed unused fragment * Removed test case * Add max_rc support for module zos_tso_command (#666) * rebuilding 565 * fixing pep8 issue * corrected not in code, added functional test to use maxrc * changing maxrc return codes as indicated * updated copy_rexx to incorporate max_rc * pep8 issue on an if statement * changed test to dump intermediate values temporarily * added max_rc to arg params to get it to pass through * removed extra output on test * Added changelog fragment. * Update 565-zos_tsocommand_maxrc.yml * PARTIAL correction based on reviewer's feedback. Will complete later today. * Partial push: change origrc to orig_rc and added documentation. Added experimental loop for multiline results. Changed error case to continue through the commands even after a failure (?!) * Changes based on review feedback: - rc is actual returned value - origrc/orig_rc removed - in a list of commands, first error (considering max_rc) stops the chain - while processing commands, a list of success/failures are kept for error state info - changed listds to a longer, more complete string in example * updated test case for max_rc to use longer, more complete listds command * Minor pep8 and yamllint changes * Updated string builder to use append and join, for efficiency. * Update changelog fragment to correspond to pull request number Signed-off-by: ddimatos <dimatos@gmail.com> * removed old fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Changed output of command-by-command to use max_rc instead of Max RC, for consistency. * clarifying failure message when user hasn't set a max_rc. * corrected date on copyright notice to include current year. * corrected copyright date on test case --------- Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Demetri <dimatos@gmail.com> * added changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * zos_copy forward port a test case for symbols on a volume #739 (#740) * added test case for symbols on a volume Signed-off-by: ddimatos <dimatos@gmail.com> * Changelog fragment added Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with added comments Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Volume Initialization Module (#654) * Adding ZOS_INIT plugins The module and action for ZOS_Init command, under zos_ickdsf_command. Designed for version 1.3.1, and example given references removed zos_ssh.py. * Create zos_ickdsf_command.rst Tentative documentation. Does not quite list every return, and program may change to work with overall zos core collection. * Update zos_ickdsf_command.py fixed to pass pep8 sanity test. * Update zos_ickdsf_command.py Edited zos_ickdsf_command.py in action folder to pass pep8 style check. * bugfix - undo hard-coded storagegroup param from command passed to mvs_raw Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update encoding and licensing info Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * edit descriptions, leaving in old to verify messaging with dfsms team Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove references to buildix Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * cleanup examples docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add return docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add some unit tests Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update dict names, some clean up Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update interface and docs with cleaner descriptions and define default values and required true/false where applicable Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove init param and bring out sub-options one level Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * rename module from zos_ickdsf_command to zos_ickdsf_init Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove files referring to zos_ickdsf_command; i forgot to untrack these in the previous commit Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove params from intitial definition of results dict which are not always present, remove unused return params, rename message to msg to match ibm_zos_core and ansible style Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add ignore missing gplv3 license warning from sanity testings to existing ignore files Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * style edits to pass sanity tests Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add in-depth task name to first example docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add minimal params functional test Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * convert action plugin to module_util, remove IckdsfCommand and CommandInit class definitions and custom error classes, move convert method to module_util Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * rename rc param, update func test Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add note about disabled verify_offline check Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * removed volume_address checks which can be handled by ansiblemodule parsing validation or ickdsf itself; changed function signature of convert method to include results dicts so it can pass it to fail_json method in the case of module failure Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add invalid volume_address func tests Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * change param names, organize mvscmd return output Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * consolidate negative func tests, add negative tests for vtoc_tracks param, start list for postive tests to implement Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add func tests for "verify_existing_volid" and "verify_no_data_sets_exist" Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add volid positive and negative func tests Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add mutual exclusion to no index/sms_managedw with func test, minor edits to comments * add func tests for index param Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add func test for vtoc_tracks param Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove 'addr_range', 'volid_prefix' and 'output_html' params; add example with ansible loop to init multiple serial volumes Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * convert 'content' return param to list for prettier playbook output Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add specific examples to docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add guard rail test with volser check set to ensure target volume is as expected Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * switch target test vol to user02, remove existing data sets in initial test Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * start adding author names to docstring, edits of yaml for sanity test Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * rename module to zos_volume_init Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove unit test suite which was not kept up to date with code restructure Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove old/outdated .rst file Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * bring up to speed with v1.5.0-beta.1 which is currently more recent than dev Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add sanity test 2.15 file Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * clean up trailing empty lines/space chars Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * more pep8 style Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * pull in more changes from latest dev branch Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * tweak tests/sanity/ignore-2.10.txt file Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * rename volume_address to address, rename verify_no_data_sets_exist to verify_volume_empty, rename verify_existing_volid to verify_volid, rename vtoc_tracks to vtoc_size, rename return param command to cmd, make suggested doc changes, switch off check_mode Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * resolve pep8 line too long issue Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add year to copyright, add gh user name to author, restyle true/false with code rather than italics, remove backslashes in docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add changelog fragment Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update zos_fetch test case to create data set instead of using one that gets wiped away by zos_volume_init test cases Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * address PR comments including pep8 styling, docstring changes including add seealso section, add details around authorized usage of ickdsf, some light wordsmithing, and remove cmd from return structure Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add backticks to other special chars in docs for consistency Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * on more formatting tweak to national chars in docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add new param to support tmp_hlq Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * extend tmphlq binding to sysprint(*), disable verbose mode for mvscmd call Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove references to betterargparser - it cannot be used in its current state as it is too restrictive on volume serial and qualifier args Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove soft language ie beware, please; reduce line lengths, fix a spelling error Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * reorganize test case code for more logical grouping and un-nesting from a for loop, also update copyright year that was missed Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update display command check to only check particular lines instead of entire output in test_volid_address_assigned_correctly which would always be positive when tested against the entire output Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> --------- Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> Co-authored-by: trevor-glassey <Trevor.Glassey@ibm.com> * Ported bugfixes for #664 and #678 from 1.5.0 (#743) * Ported bugfixes for #664 and #678 * Updated file normalization for sequential datasets * Fixed encoding when a remote source is used * Added encoding normalization for record length (#664) This is a port and tweak from the normalization found in the L2 support branch. Now the normalization applies for both local and remote source files. There is still work left to validate how this behaves when copying to partitioned datasets, and see if the normalization needs to handle directories as well. * Refactored normalization for USS files * Updated line endings normalization in PDSEs * Updated create_temp_with_lf_endings * Added tests for line endings normalization * Added changelog fragment * Updated changelog fragment * Updated copyright information * Added comments to record length tests * Added more context to the record length normalization * Add force (disp=shr) option to zos_lineinfile and update zos_blockinfile with the same locking test case. (#731) * Add DISP=SHR by function force to the user * Add helper function for force cases only for EOF inserts * Test cases added * Just to check in the change case * All test cases for force in zos_lineinfile working properly * Test cases for force blockinfile * Fixes for style of code * One identation error * One identation error * One identation error * Documentation error * All test cases for line infile and block infile * Comments * Change the stdout to assert with expected of ds * Error of test case * Fragment added * Solve typo errors * Update to remove uncessary comment Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with force comments Signed-off-by: ddimatos <dimatos@gmail.com> * Solve some test problems * Copyright year * Copyright year * Add cases for other ecodes * Add test for all encodings * Cover all encodes test cases with force * Blockinfile force added for other encodes and DS types --------- Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> Co-authored-by: Andre Marcel Gutierrez Benitez <andre@mbp-de-andre-2.gdl.mex.ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * remove duplicate function (#753) * Update branch production branch Main with release v1.5.0 content (#756) (#758) * Bug fix to correct job log returining and other edge cases (#688) * Update zos_job_submit to handle some edge cases and return the job log nearly always * Linting correction * Add changelog fragement for pr 683 * Clean up comments in code * Update restructured text for modules and changelog fragment * Add support to check for security exception to job submit module * Add additonal logic for jobs that use typerun=scan * Update chnagelog fragment * Correct run on sentence --------- * Added additional `D SYMBOLS` example to zos_operator documentation (#729) * Update zos_operator with an additional example * Added change fragment --------- * Ported bugfixes for #664 and #678 * Updated file normalization for sequential datasets * Fixed encoding when a remote source is used * Added encoding normalization for record length (#664) This is a port and tweak from the normalization found in the L2 support branch. Now the normalization applies for both local and remote source files. There is still work left to validate how this behaves when copying to partitioned datasets, and see if the normalization needs to handle directories as well. * Refactored normalization for USS files * Updated line endings normalization in PDSEs * Updated create_temp_with_lf_endings * Added tests for line endings normalization * Added changelog fragment * Add copy lib member test case * Corrected changelog fragment * Add conflict resolution * Update 641-copy-loadlib-member.yml * zos_copy forward port a test case for symbols on a volume (#739) * Add a test case for symbols using an existing volume on our test system * Add changelog fragment * Update 739-zos_copy-volume-symbol-test.yml Update description to use symbols overs special chars. * Update test case with added comments --------- * bring in updates to zos_gather_facts RETURN docstring (#744) * Solve problem 619 about set mode on dest file (#746) * Solve problem 619 about set mode on dest file * Add fragment of 746 PR --------- * Merge release tasks for v1.5.0 into release branch (#752) * Updated metadata * Updated copyright information * Updated copyright in README * Generated changelog * Added previous versions to changelog * Changed a minor_change fragment to bugfix * Updated release notes * Update dependency finder to allow for all tests minus skip tests * Update release notes and changelog with full date formats --------- * remove changelog fragments no longer needed (#754) --------- Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> Co-authored-by: Ivan Moreno <iamorenosoto@gmail.com> Co-authored-by: Fernando Flores <fernandofloresdev@gmail.com> Co-authored-by: Rich Parker <richp405@gmail.com> Co-authored-by: ketankelkar <ktnklkr@gmail.com> Co-authored-by: André Marcel Gutiérrez Benítez <68956970+AndreMarcel99@users.noreply.github.com> Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> * update galaxy and meta/ files Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update copyright years Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update rst doc files Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add 1.6.0-beta.1 release summary fragment Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * generate changelog Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add release notes Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add additional stylizing Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * Delete fragements once changelog is generated Signed-off-by: ddimatos <dimatos@gmail.com> * update stylizing ar…
…r-job-submit [zos_job_submit] Fix undefined variable
…te-sanity-test-ignore-9-11 Update zos job submit undocumented argument and import exception
rexemin
reviewed
Aug 9, 2024
ketankelkar
requested changes
Aug 10, 2024
Collaborator
ketankelkar
left a comment
ketankelkar
left a comment
There was a problem hiding this comment.
Wow, what a herculean effort from the team this last quarter that is reflected in this PR, this is amazing work!!
Thanks Fernando for responding to my edits ahead of time so they never had to make it here. The only comments I've had to make here are for the release notes. There seem to be some merge issues, from what I can tell, the 'minor_changes' section may have gotten split up in a strange way, perhaps an error from the doc-gen tooling, not sure
ddimatos
requested changes
Aug 12, 2024
Collaborator
ddimatos
left a comment
ddimatos
left a comment
There was a problem hiding this comment.
This looks great, I will request some edits.
FYI, several of my comments we can take offline and resolve Monday, I put them there to discuss to see if we should track the comments as future git issues.
richp405
approved these changes
Aug 12, 2024
Collaborator
richp405
left a comment
richp405
left a comment
There was a problem hiding this comment.
I pointed out a comma or two, which won't impact the user.
I also noticed use of 'shellescape', which should be 'shlex' so it sticks to python, not a 3rd party lib... as of now, there's no difference to the user.
I LOVE how the new comment/explanations read.
fernandofloresg
referenced
this pull request
Apr 1, 2025
* Staging v1.7.0 beta.1 (#915) * Added tagging of converted files * Updated tests for zos_encode * Added restoration of PDS/PDSE members when module fails zos_copy can now track which members got overwritten or newly added to a partitioned data set, and restore them accordingly. This commit includes a refactorization of the copy_to_pdse method to simplify the restoration work. * Fixed cleanup of dest when module fails * Removed exception used for debugging * Added pytest markers * solved pep8 issue * Added more information to error when restoration fails * Update make file with new features to manage the nodes (#563) * Update make file with new features to manage the nodes Signed-off-by: ddimatos <dimatos@gmail.com> * Correct typo Signed-off-by: ddimatos <dimatos@gmail.com> * updated makefile to allow for no password in the clear and added a new host Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Fix a bug that failed to copy the cert to the managed node (#577) Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Added apropiate error message in zos_lineinfile when src is not found * Better error message * Added fragment for changelog * Update git issue slection field (#593) * Update git issue slection field * Added some additional future versions * Added rule to ignore python 2.7 compile not supporting f strings * Corrected rule in ignore file * Update 584-zos_lineinfile-error-message.yml * Added missing fragments for issues 309 and 408 * update make file and related artifacts with recent zVM changes (#598) Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Expand what is ingored for venv to all venv's (#613) Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Ansible-core versions with updated ignore file pass (#615) * Validated that ansible-core versions with updated ignore file pass locally Signed-off-by: ddimatos <dimatos@gmail.com> * remove redundant entry on last line Signed-off-by: ddimatos <dimatos@gmail.com> * remove redundant entry on last line Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Update make file to read exported var VENV else default to 'venv' (#614) * Update make file to read exported var VENV else default to 'venv' Signed-off-by: ddimatos <dimatos@gmail.com> * Correct the default from defaultValue to 'venv' Signed-off-by: ddimatos <dimatos@gmail.com> * Bugfix/558/zos copy backup dev (#609) * Create emergency backup only if force is set to False and dest exists * Added Changelog fragment * Updated imports ansible.module_utils._text to ansible.module_utils.common.text.converters (#602) * Updated import in zos_fetch * Updated import in zos_job_submit * Updated import in module_utils/data_set * Updated import in module_utils/System * Updated import in zos_copy * Updated import in zos_fetch * Added changelog fragment * Update enhancement-518-text-converter-import.yml * Updates the makefile and related scripts for the latest mounts (#628) * Update makefile coments and use --ignore for pytest Signed-off-by: ddimatos <dimatos@gmail.com> * lexicographical order targets Signed-off-by: ddimatos <dimatos@gmail.com> * Update makefile and artifacts to support new mounts Signed-off-by: ddimatos <dimatos@gmail.com> * Removing encrypted versions of the scripts, no longer senstive content Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * update profile created for mount points Signed-off-by: ddimatos <dimatos@gmail.com> * Correct f-string usage to remain 2.7 compatible (#659) * Correct f-string usage to remain 2.7 compatible Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Updated shell scripts for development tooling Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Update collab template Signed-off-by: ddimatos <dimatos@gmail.com> * Update collab template Signed-off-by: ddimatos <dimatos@gmail.com> * Update collab template Signed-off-by: ddimatos <dimatos@gmail.com> * Template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Template updates Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * changed zos_job_query to allow multi/embedded wildcard job_values. job.py/_get_job_status now uses fnmatch to test for wildcarded job_names. added test looking for a wildcard job name. added basic changelog text as 'enhancement'. * expanded wildcard support to job_id as well as job_name corrected error-handling issue in query routine playbook tests complete * cleaned up pep8 issues * Bug fix to correct job log returining and other edge cases (#683) * Update zos_job_submit to handle some edge cases and return the job log nearly always Signed-off-by: ddimatos <dimatos@gmail.com> * Linting correction Signed-off-by: ddimatos <dimatos@gmail.com> * Add changelog fragement for pr 683 Signed-off-by: ddimatos <dimatos@gmail.com> * Clean up comments in code Signed-off-by: ddimatos <dimatos@gmail.com> * Update restructured text for modules and changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Add support to check for security exception to job submit module Signed-off-by: ddimatos <dimatos@gmail.com> * Add additonal logic for jobs that use typerun=scan Signed-off-by: ddimatos <dimatos@gmail.com> * Update chnagelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Update zos_job_submit.py Grammar change and correction. --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Added uss_tag_encoding function * Fixing linter issues * removed extraneous comment on query, eliminated unused variable * responding to reviewer comments * Expanded query tests to run a hello jcl file to make sure we are searching for a job id that exists. * Expanded documentation in code to highlight asterisk availability. Added examples showing multi-asterisk search. * Corrected 2 documentation errors * Change to documentation text (indent on multi line string?) * Still trying to get documentation to pass * Looks like '---' was killing documentation block. * Update zos_blockinfile with complex examples (#727) * Update zos_blockinfile with complex examples Signed-off-by: ddimatos <dimatos@gmail.com> * Add changelog fragement Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Added additional D SYMBOLS example to zos_operator documentation (#730) * Update zos_operator with an additional example Signed-off-by: ddimatos <dimatos@gmail.com> * Added changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * zos_gather_facts - add sample output to RETURN docstring (#722) * zos_gather_facts - add sample output to RETURN docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add changelog fragment Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * zos_gather_facts RETURN docstring - add sample sysplex_name and lpar_name values Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * Update generated module doc Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> * 574find (#668) * change to allow find loop to continue when one particular data set element is not found This has been validated with a zos-check-find.yaml playbook * added functional test that includes non-existant pds entry, which should be skipped over * added changelog fragment. * zos_blockinfile , can quotes in content can be supported (#680) * Verify coomand of ZOAU support the doble quotes and get better output of message * Verify coomand of ZOAU support the doble quotes and get better output of message * Restore to the one tyme function solving TypeError * Test about cases with quotes supported * Solve comments * Comments in the changelog * Adjust test for working accord the text * A needed space * All in structured * Comments solved * Better order --------- Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> Co-authored-by: Demetri <dimatos@gmail.com> * zos_copy mode is applied to the destination directory, a deviation from the communtiy module behavior. (#723) * Verify coomand of ZOAU support the doble quotes and get better output of message * Verify coomand of ZOAU support the doble quotes and get better output of message * Restore to the one tyme function solving TypeError * Test about cases with quotes supported * Solve comments * Comments in the changelog * Adjust test for working accord the text * Solve the dest functional mode set for the applied to destination directory * Identation and spaces * To work well * To work well * To work well * To work well * Changelogs added * Solved the fragment test and separte the cases --------- Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> * corrected job test case that wanted to extract job id. * changed call to zos_job_query in the functional test. * zos_data_set - add force parameter to enable member delete via disp shr (#718) * add force parameter to enable member delete via disp shr Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update link to PR instead of issue Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * fix minor mistake in func test Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update DOCstring for missed items highlighted in PR review Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update copyright years in data set module util Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> --------- Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * Update changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Update to doc and examples Signed-off-by: ddimatos <dimatos@gmail.com> * Update to doc and examples Signed-off-by: ddimatos <dimatos@gmail.com> * Update to doc and examples Signed-off-by: ddimatos <dimatos@gmail.com> * update doc, rst Signed-off-by: ddimatos <dimatos@gmail.com> * Update doc and examples Signed-off-by: ddimatos <dimatos@gmail.com> * Added handler for job not found edge cases (None not iterable errors) * corrected pep8 issue (bad indent) * removed tracking text from error/not found messages. * Update zos_job_query.py * Add and automate a load lib test case for module zos_copy (#640) * Modified if statement * Added changelog fragment * Corrected statements Corrected PR in changelog fix lint issue * Adding test case on the work * Added assertion to loadlib test Changed cobol src Added newlines * Correcting cobol src * Removed unnecessary comments * Removed deprint statements for debug * Update 601-copy-loadlib-member.yml * Reduce space primary * Make sure cobol is executable * corrected name * Corrected names * Adding debug statements * modified name in link step * Changing copy name * Removed print statements for debug * Removed previous changelog * Removed unused fragment * Removed test case * Add max_rc support for module zos_tso_command (#666) * rebuilding 565 * fixing pep8 issue * corrected not in code, added functional test to use maxrc * changing maxrc return codes as indicated * updated copy_rexx to incorporate max_rc * pep8 issue on an if statement * changed test to dump intermediate values temporarily * added max_rc to arg params to get it to pass through * removed extra output on test * Added changelog fragment. * Update 565-zos_tsocommand_maxrc.yml * PARTIAL correction based on reviewer's feedback. Will complete later today. * Partial push: change origrc to orig_rc and added documentation. Added experimental loop for multiline results. Changed error case to continue through the commands even after a failure (?!) * Changes based on review feedback: - rc is actual returned value - origrc/orig_rc removed - in a list of commands, first error (considering max_rc) stops the chain - while processing commands, a list of success/failures are kept for error state info - changed listds to a longer, more complete string in example * updated test case for max_rc to use longer, more complete listds command * Minor pep8 and yamllint changes * Updated string builder to use append and join, for efficiency. * Update changelog fragment to correspond to pull request number Signed-off-by: ddimatos <dimatos@gmail.com> * removed old fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Changed output of command-by-command to use max_rc instead of Max RC, for consistency. * clarifying failure message when user hasn't set a max_rc. * corrected date on copyright notice to include current year. * corrected copyright date on test case --------- Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Demetri <dimatos@gmail.com> * added changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * zos_copy forward port a test case for symbols on a volume #739 (#740) * added test case for symbols on a volume Signed-off-by: ddimatos <dimatos@gmail.com> * Changelog fragment added Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with added comments Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Volume Initialization Module (#654) * Adding ZOS_INIT plugins The module and action for ZOS_Init command, under zos_ickdsf_command. Designed for version 1.3.1, and example given references removed zos_ssh.py. * Create zos_ickdsf_command.rst Tentative documentation. Does not quite list every return, and program may change to work with overall zos core collection. * Update zos_ickdsf_command.py fixed to pass pep8 sanity test. * Update zos_ickdsf_command.py Edited zos_ickdsf_command.py in action folder to pass pep8 style check. * bugfix - undo hard-coded storagegroup param from command passed to mvs_raw Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update encoding and licensing info Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * edit descriptions, leaving in old to verify messaging with dfsms team Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove references to buildix Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * cleanup examples docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add return docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add some unit tests Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update dict names, some clean up Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update interface and docs with cleaner descriptions and define default values and required true/false where applicable Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove init param and bring out sub-options one level Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * rename module from zos_ickdsf_command to zos_ickdsf_init Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove files referring to zos_ickdsf_command; i forgot to untrack these in the previous commit Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove params from intitial definition of results dict which are not always present, remove unused return params, rename message to msg to match ibm_zos_core and ansible style Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add ignore missing gplv3 license warning from sanity testings to existing ignore files Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * style edits to pass sanity tests Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add in-depth task name to first example docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add minimal params functional test Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * convert action plugin to module_util, remove IckdsfCommand and CommandInit class definitions and custom error classes, move convert method to module_util Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * rename rc param, update func test Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add note about disabled verify_offline check Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * removed volume_address checks which can be handled by ansiblemodule parsing validation or ickdsf itself; changed function signature of convert method to include results dicts so it can pass it to fail_json method in the case of module failure Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add invalid volume_address func tests Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * change param names, organize mvscmd return output Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * consolidate negative func tests, add negative tests for vtoc_tracks param, start list for postive tests to implement Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add func tests for "verify_existing_volid" and "verify_no_data_sets_exist" Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add volid positive and negative func tests Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add mutual exclusion to no index/sms_managedw with func test, minor edits to comments * add func tests for index param Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add func test for vtoc_tracks param Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove 'addr_range', 'volid_prefix' and 'output_html' params; add example with ansible loop to init multiple serial volumes Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * convert 'content' return param to list for prettier playbook output Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add specific examples to docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add guard rail test with volser check set to ensure target volume is as expected Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * switch target test vol to user02, remove existing data sets in initial test Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * start adding author names to docstring, edits of yaml for sanity test Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * rename module to zos_volume_init Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove unit test suite which was not kept up to date with code restructure Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove old/outdated .rst file Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * bring up to speed with v1.5.0-beta.1 which is currently more recent than dev Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add sanity test 2.15 file Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * clean up trailing empty lines/space chars Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * more pep8 style Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * pull in more changes from latest dev branch Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * tweak tests/sanity/ignore-2.10.txt file Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * rename volume_address to address, rename verify_no_data_sets_exist to verify_volume_empty, rename verify_existing_volid to verify_volid, rename vtoc_tracks to vtoc_size, rename return param command to cmd, make suggested doc changes, switch off check_mode Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * resolve pep8 line too long issue Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add year to copyright, add gh user name to author, restyle true/false with code rather than italics, remove backslashes in docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add changelog fragment Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update zos_fetch test case to create data set instead of using one that gets wiped away by zos_volume_init test cases Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * address PR comments including pep8 styling, docstring changes including add seealso section, add details around authorized usage of ickdsf, some light wordsmithing, and remove cmd from return structure Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add backticks to other special chars in docs for consistency Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * on more formatting tweak to national chars in docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add new param to support tmp_hlq Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * extend tmphlq binding to sysprint(*), disable verbose mode for mvscmd call Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove references to betterargparser - it cannot be used in its current state as it is too restrictive on volume serial and qualifier args Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove soft language ie beware, please; reduce line lengths, fix a spelling error Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * reorganize test case code for more logical grouping and un-nesting from a for loop, also update copyright year that was missed Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update display command check to only check particular lines instead of entire output in test_volid_address_assigned_correctly which would always be positive when tested against the entire output Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> --------- Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> Co-authored-by: trevor-glassey <Trevor.Glassey@ibm.com> * Ported bugfixes for #664 and #678 from 1.5.0 (#743) * Ported bugfixes for #664 and #678 * Updated file normalization for sequential datasets * Fixed encoding when a remote source is used * Added encoding normalization for record length (#664) This is a port and tweak from the normalization found in the L2 support branch. Now the normalization applies for both local and remote source files. There is still work left to validate how this behaves when copying to partitioned datasets, and see if the normalization needs to handle directories as well. * Refactored normalization for USS files * Updated line endings normalization in PDSEs * Updated create_temp_with_lf_endings * Added tests for line endings normalization * Added changelog fragment * Updated changelog fragment * Updated copyright information * Added comments to record length tests * Added more context to the record length normalization * Add force (disp=shr) option to zos_lineinfile and update zos_blockinfile with the same locking test case. (#731) * Add DISP=SHR by function force to the user * Add helper function for force cases only for EOF inserts * Test cases added * Just to check in the change case * All test cases for force in zos_lineinfile working properly * Test cases for force blockinfile * Fixes for style of code * One identation error * One identation error * One identation error * Documentation error * All test cases for line infile and block infile * Comments * Change the stdout to assert with expected of ds * Error of test case * Fragment added * Solve typo errors * Update to remove uncessary comment Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with force comments Signed-off-by: ddimatos <dimatos@gmail.com> * Solve some test problems * Copyright year * Copyright year * Add cases for other ecodes * Add test for all encodings * Cover all encodes test cases with force * Blockinfile force added for other encodes and DS types --------- Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> Co-authored-by: Andre Marcel Gutierrez Benitez <andre@mbp-de-andre-2.gdl.mex.ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * remove duplicate function (#753) * Update branch production branch Main with release v1.5.0 content (#756) (#758) * Bug fix to correct job log returining and other edge cases (#688) * Update zos_job_submit to handle some edge cases and return the job log nearly always * Linting correction * Add changelog fragement for pr 683 * Clean up comments in code * Update restructured text for modules and changelog fragment * Add support to check for security exception to job submit module * Add additonal logic for jobs that use typerun=scan * Update chnagelog fragment * Correct run on sentence --------- * Added additional `D SYMBOLS` example to zos_operator documentation (#729) * Update zos_operator with an additional example * Added change fragment --------- * Ported bugfixes for #664 and #678 * Updated file normalization for sequential datasets * Fixed encoding when a remote source is used * Added encoding normalization for record length (#664) This is a port and tweak from the normalization found in the L2 support branch. Now the normalization applies for both local and remote source files. There is still work left to validate how this behaves when copying to partitioned datasets, and see if the normalization needs to handle directories as well. * Refactored normalization for USS files * Updated line endings normalization in PDSEs * Updated create_temp_with_lf_endings * Added tests for line endings normalization * Added changelog fragment * Add copy lib member test case * Corrected changelog fragment * Add conflict resolution * Update 641-copy-loadlib-member.yml * zos_copy forward port a test case for symbols on a volume (#739) * Add a test case for symbols using an existing volume on our test system * Add changelog fragment * Update 739-zos_copy-volume-symbol-test.yml Update description to use symbols overs special chars. * Update test case with added comments --------- * bring in updates to zos_gather_facts RETURN docstring (#744) * Solve problem 619 about set mode on dest file (#746) * Solve problem 619 about set mode on dest file * Add fragment of 746 PR --------- * Merge release tasks for v1.5.0 into release branch (#752) * Updated metadata * Updated copyright information * Updated copyright in README * Generated changelog * Added previous versions to changelog * Changed a minor_change fragment to bugfix * Updated release notes * Update dependency finder to allow for all tests minus skip tests * Update release notes and changelog with full date formats --------- * remove changelog fragments no longer needed (#754) --------- Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> Co-authored-by: Ivan Moreno <iamorenosoto@gmail.com> Co-authored-by: Fernando Flores <fernandofloresdev@gmail.com> Co-authored-by: Rich Parker <richp405@gmail.com> Co-authored-by: ketankelkar <ktnklkr@gmail.com> Co-authored-by: André Marcel Gutiérrez Benítez <68956970+AndreMarcel99@users.noreply.github.com> Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> * Merge master to dev for 1.6.0 beta.1 (#763) * Update branch production branch Main with release v1.5.0 content (#756) * Bug fix to correct job log returining and other edge cases (#688) * Update zos_job_submit to handle some edge cases and return the job log nearly always Signed-off-by: ddimatos <dimatos@gmail.com> * Linting correction Signed-off-by: ddimatos <dimatos@gmail.com> * Add changelog fragement for pr 683 Signed-off-by: ddimatos <dimatos@gmail.com> * Clean up comments in code Signed-off-by: ddimatos <dimatos@gmail.com> * Update restructured text for modules and changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Add support to check for security exception to job submit module Signed-off-by: ddimatos <dimatos@gmail.com> * Add additonal logic for jobs that use typerun=scan Signed-off-by: ddimatos <dimatos@gmail.com> * Update chnagelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Correct run on sentence Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Added additional `D SYMBOLS` example to zos_operator documentation (#729) * Update zos_operator with an additional example Signed-off-by: ddimatos <dimatos@gmail.com> * Added change fragment Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Ported bugfixes for #664 and #678 * Updated file normalization for sequential datasets * Fixed encoding when a remote source is used * Added encoding normalization for record length (#664) This is a port and tweak from the normalization found in the L2 support branch. Now the normalization applies for both local and remote source files. There is still work left to validate how this behaves when copying to partitioned datasets, and see if the normalization needs to handle directories as well. * Refactored normalization for USS files * Updated line endings normalization in PDSEs * Updated create_temp_with_lf_endings * Added tests for line endings normalization * Added changelog fragment * Add copy lib member test case * Corrected changelog fragment * Add conflict resolution * Update 641-copy-loadlib-member.yml * zos_copy forward port a test case for symbols on a volume (#739) * Add a test case for symbols using an existing volume on our test system Signed-off-by: ddimatos <dimatos@gmail.com> * Add changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Update 739-zos_copy-volume-symbol-test.yml Update description to use symbols overs special chars. * Update test case with added comments Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * bring in updates to zos_gather_facts RETURN docstring (#744) Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * Solve problem 619 about set mode on dest file (#746) * Solve problem 619 about set mode on dest file * Add fragment of 746 PR --------- Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> * Merge release tasks for v1.5.0 into release branch (#752) * Updated metadata * Updated copyright information * Updated copyright in README * Generated changelog * Added previous versions to changelog * Changed a minor_change fragment to bugfix * Updated release notes * Update dependency finder to allow for all tests minus skip tests Signed-off-by: ddimatos <dimatos@gmail.com> * Update release notes and changelog with full date formats Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> * remove changelog fragments no longer needed (#754) Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> Co-authored-by: Ivan Moreno <iamorenosoto@gmail.com> Co-authored-by: Fernando Flores <fernandofloresdev@gmail.com> Co-authored-by: Rich Parker <richp405@gmail.com> Co-authored-by: ketankelkar <ktnklkr@gmail.com> Co-authored-by: André Marcel Gutiérrez Benítez <68956970+AndreMarcel99@users.noreply.github.com> Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> * v1.6.0-beta.1 release (#759) * Added tagging of converted files * Updated tests for zos_encode * Added restoration of PDS/PDSE members when module fails zos_copy can now track which members got overwritten or newly added to a partitioned data set, and restore them accordingly. This commit includes a refactorization of the copy_to_pdse method to simplify the restoration work. * Fixed cleanup of dest when module fails * Removed exception used for debugging * Added pytest markers * solved pep8 issue * Added more information to error when restoration fails * Update make file with new features to manage the nodes (#563) * Update make file with new features to manage the nodes Signed-off-by: ddimatos <dimatos@gmail.com> * Correct typo Signed-off-by: ddimatos <dimatos@gmail.com> * updated makefile to allow for no password in the clear and added a new host Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Fix a bug that failed to copy the cert to the managed node (#577) Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Added apropiate error message in zos_lineinfile when src is not found * Better error message * Added fragment for changelog * Update git issue slection field (#593) * Update git issue slection field * Added some additional future versions * Added rule to ignore python 2.7 compile not supporting f strings * Corrected rule in ignore file * Update 584-zos_lineinfile-error-message.yml * Added missing fragments for issues 309 and 408 * update make file and related artifacts with recent zVM changes (#598) Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Expand what is ingored for venv to all venv's (#613) Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Ansible-core versions with updated ignore file pass (#615) * Validated that ansible-core versions with updated ignore file pass locally Signed-off-by: ddimatos <dimatos@gmail.com> * remove redundant entry on last line Signed-off-by: ddimatos <dimatos@gmail.com> * remove redundant entry on last line Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Update make file to read exported var VENV else default to 'venv' (#614) * Update make file to read exported var VENV else default to 'venv' Signed-off-by: ddimatos <dimatos@gmail.com> * Correct the default from defaultValue to 'venv' Signed-off-by: ddimatos <dimatos@gmail.com> * Bugfix/558/zos copy backup dev (#609) * Create emergency backup only if force is set to False and dest exists * Added Changelog fragment * Updated imports ansible.module_utils._text to ansible.module_utils.common.text.converters (#602) * Updated import in zos_fetch * Updated import in zos_job_submit * Updated import in module_utils/data_set * Updated import in module_utils/System * Updated import in zos_copy * Updated import in zos_fetch * Added changelog fragment * Update enhancement-518-text-converter-import.yml * Updates the makefile and related scripts for the latest mounts (#628) * Update makefile coments and use --ignore for pytest Signed-off-by: ddimatos <dimatos@gmail.com> * lexicographical order targets Signed-off-by: ddimatos <dimatos@gmail.com> * Update makefile and artifacts to support new mounts Signed-off-by: ddimatos <dimatos@gmail.com> * Removing encrypted versions of the scripts, no longer senstive content Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * update profile created for mount points Signed-off-by: ddimatos <dimatos@gmail.com> * Correct f-string usage to remain 2.7 compatible (#659) * Correct f-string usage to remain 2.7 compatible Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Updated shell scripts for development tooling Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Update collab template Signed-off-by: ddimatos <dimatos@gmail.com> * Update collab template Signed-off-by: ddimatos <dimatos@gmail.com> * Update collab template Signed-off-by: ddimatos <dimatos@gmail.com> * Template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Template updates Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * changed zos_job_query to allow multi/embedded wildcard job_values. job.py/_get_job_status now uses fnmatch to test for wildcarded job_names. added test looking for a wildcard job name. added basic changelog text as 'enhancement'. * expanded wildcard support to job_id as well as job_name corrected error-handling issue in query routine playbook tests complete * cleaned up pep8 issues * Bug fix to correct job log returining and other edge cases (#683) * Update zos_job_submit to handle some edge cases and return the job log nearly always Signed-off-by: ddimatos <dimatos@gmail.com> * Linting correction Signed-off-by: ddimatos <dimatos@gmail.com> * Add changelog fragement for pr 683 Signed-off-by: ddimatos <dimatos@gmail.com> * Clean up comments in code Signed-off-by: ddimatos <dimatos@gmail.com> * Update restructured text for modules and changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Add support to check for security exception to job submit module Signed-off-by: ddimatos <dimatos@gmail.com> * Add additonal logic for jobs that use typerun=scan Signed-off-by: ddimatos <dimatos@gmail.com> * Update chnagelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Update zos_job_submit.py Grammar change and correction. --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Added uss_tag_encoding function * Fixing linter issues * removed extraneous comment on query, eliminated unused variable * responding to reviewer comments * Expanded query tests to run a hello jcl file to make sure we are searching for a job id that exists. * Expanded documentation in code to highlight asterisk availability. Added examples showing multi-asterisk search. * Corrected 2 documentation errors * Change to documentation text (indent on multi line string?) * Still trying to get documentation to pass * Looks like '---' was killing documentation block. * Update zos_blockinfile with complex examples (#727) * Update zos_blockinfile with complex examples Signed-off-by: ddimatos <dimatos@gmail.com> * Add changelog fragement Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Added additional D SYMBOLS example to zos_operator documentation (#730) * Update zos_operator with an additional example Signed-off-by: ddimatos <dimatos@gmail.com> * Added changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * zos_gather_facts - add sample output to RETURN docstring (#722) * zos_gather_facts - add sample output to RETURN docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add changelog fragment Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * zos_gather_facts RETURN docstring - add sample sysplex_name and lpar_name values Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * Update generated module doc Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> * 574find (#668) * change to allow find loop to continue when one particular data set element is not found This has been validated with a zos-check-find.yaml playbook * added functional test that includes non-existant pds entry, which should be skipped over * added changelog fragment. * zos_blockinfile , can quotes in content can be supported (#680) * Verify coomand of ZOAU support the doble quotes and get better output of message * Verify coomand of ZOAU support the doble quotes and get better output of message * Restore to the one tyme function solving TypeError * Test about cases with quotes supported * Solve comments * Comments in the changelog * Adjust test for working accord the text * A needed space * All in structured * Comments solved * Better order --------- Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> Co-authored-by: Demetri <dimatos@gmail.com> * zos_copy mode is applied to the destination directory, a deviation from the communtiy module behavior. (#723) * Verify coomand of ZOAU support the doble quotes and get better output of message * Verify coomand of ZOAU support the doble quotes and get better output of message * Restore to the one tyme function solving TypeError * Test about cases with quotes supported * Solve comments * Comments in the changelog * Adjust test for working accord the text * Solve the dest functional mode set for the applied to destination directory * Identation and spaces * To work well * To work well * To work well * To work well * Changelogs added * Solved the fragment test and separte the cases --------- Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> * corrected job test case that wanted to extract job id. * changed call to zos_job_query in the functional test. * zos_data_set - add force parameter to enable member delete via disp shr (#718) * add force parameter to enable member delete via disp shr Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update link to PR instead of issue Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * fix minor mistake in func test Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update DOCstring for missed items highlighted in PR review Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update copyright years in data set module util Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> --------- Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * Update changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Update to doc and examples Signed-off-by: ddimatos <dimatos@gmail.com> * Update to doc and examples Signed-off-by: ddimatos <dimatos@gmail.com> * Update to doc and examples Signed-off-by: ddimatos <dimatos@gmail.com> * update doc, rst Signed-off-by: ddimatos <dimatos@gmail.com> * Update doc and examples Signed-off-by: ddimatos <dimatos@gmail.com> * Added handler for job not found edge cases (None not iterable errors) * corrected pep8 issue (bad indent) * removed tracking text from error/not found messages. * Update zos_job_query.py * Add and automate a load lib test case for module zos_copy (#640) * Modified if statement * Added changelog fragment * Corrected statements Corrected PR in changelog fix lint issue * Adding test case on the work * Added assertion to loadlib test Changed cobol src Added newlines * Correcting cobol src * Removed unnecessary comments * Removed deprint statements for debug * Update 601-copy-loadlib-member.yml * Reduce space primary * Make sure cobol is executable * corrected name * Corrected names * Adding debug statements * modified name in link step * Changing copy name * Removed print statements for debug * Removed previous changelog * Removed unused fragment * Removed test case * Add max_rc support for module zos_tso_command (#666) * rebuilding 565 * fixing pep8 issue * corrected not in code, added functional test to use maxrc * changing maxrc return codes as indicated * updated copy_rexx to incorporate max_rc * pep8 issue on an if statement * changed test to dump intermediate values temporarily * added max_rc to arg params to get it to pass through * removed extra output on test * Added changelog fragment. * Update 565-zos_tsocommand_maxrc.yml * PARTIAL correction based on reviewer's feedback. Will complete later today. * Partial push: change origrc to orig_rc and added documentation. Added experimental loop for multiline results. Changed error case to continue through the commands even after a failure (?!) * Changes based on review feedback: - rc is actual returned value - origrc/orig_rc removed - in a list of commands, first error (considering max_rc) stops the chain - while processing commands, a list of success/failures are kept for error state info - changed listds to a longer, more complete string in example * updated test case for max_rc to use longer, more complete listds command * Minor pep8 and yamllint changes * Updated string builder to use append and join, for efficiency. * Update changelog fragment to correspond to pull request number Signed-off-by: ddimatos <dimatos@gmail.com> * removed old fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Changed output of command-by-command to use max_rc instead of Max RC, for consistency. * clarifying failure message when user hasn't set a max_rc. * corrected date on copyright notice to include current year. * corrected copyright date on test case --------- Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Demetri <dimatos@gmail.com> * added changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * zos_copy forward port a test case for symbols on a volume #739 (#740) * added test case for symbols on a volume Signed-off-by: ddimatos <dimatos@gmail.com> * Changelog fragment added Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with added comments Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Volume Initialization Module (#654) * Adding ZOS_INIT plugins The module and action for ZOS_Init command, under zos_ickdsf_command. Designed for version 1.3.1, and example given references removed zos_ssh.py. * Create zos_ickdsf_command.rst Tentative documentation. Does not quite list every return, and program may change to work with overall zos core collection. * Update zos_ickdsf_command.py fixed to pass pep8 sanity test. * Update zos_ickdsf_command.py Edited zos_ickdsf_command.py in action folder to pass pep8 style check. * bugfix - undo hard-coded storagegroup param from command passed to mvs_raw Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update encoding and licensing info Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * edit descriptions, leaving in old to verify messaging with dfsms team Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove references to buildix Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * cleanup examples docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add return docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add some unit tests Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update dict names, some clean up Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update interface and docs with cleaner descriptions and define default values and required true/false where applicable Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove init param and bring out sub-options one level Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * rename module from zos_ickdsf_command to zos_ickdsf_init Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove files referring to zos_ickdsf_command; i forgot to untrack these in the previous commit Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove params from intitial definition of results dict which are not always present, remove unused return params, rename message to msg to match ibm_zos_core and ansible style Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add ignore missing gplv3 license warning from sanity testings to existing ignore files Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * style edits to pass sanity tests Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add in-depth task name to first example docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add minimal params functional test Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * convert action plugin to module_util, remove IckdsfCommand and CommandInit class definitions and custom error classes, move convert method to module_util Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * rename rc param, update func test Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add note about disabled verify_offline check Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * removed volume_address checks which can be handled by ansiblemodule parsing validation or ickdsf itself; changed function signature of convert method to include results dicts so it can pass it to fail_json method in the case of module failure Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add invalid volume_address func tests Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * change param names, organize mvscmd return output Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * consolidate negative func tests, add negative tests for vtoc_tracks param, start list for postive tests to implement Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add func tests for "verify_existing_volid" and "verify_no_data_sets_exist" Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add volid positive and negative func tests Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add mutual exclusion to no index/sms_managedw with func test, minor edits to comments * add func tests for index param Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add func test for vtoc_tracks param Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove 'addr_range', 'volid_prefix' and 'output_html' params; add example with ansible loop to init multiple serial volumes Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * convert 'content' return param to list for prettier playbook output Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add specific examples to docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add guard rail test with volser check set to ensure target volume is as expected Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * switch target test vol to user02, remove existing data sets in initial test Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * start adding author names to docstring, edits of yaml for sanity test Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * rename module to zos_volume_init Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove unit test suite which was not kept up to date with code restructure Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove old/outdated .rst file Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * bring up to speed with v1.5.0-beta.1 which is currently more recent than dev Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add sanity test 2.15 file Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * clean up trailing empty lines/space chars Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * more pep8 style Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * pull in more changes from latest dev branch Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * tweak tests/sanity/ignore-2.10.txt file Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * rename volume_address to address, rename verify_no_data_sets_exist to verify_volume_empty, rename verify_existing_volid to verify_volid, rename vtoc_tracks to vtoc_size, rename return param command to cmd, make suggested doc changes, switch off check_mode Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * resolve pep8 line too long issue Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add year to copyright, add gh user name to author, restyle true/false with code rather than italics, remove backslashes in docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add changelog fragment Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update zos_fetch test case to create data set instead of using one that gets wiped away by zos_volume_init test cases Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * address PR comments including pep8 styling, docstring changes including add seealso section, add details around authorized usage of ickdsf, some light wordsmithing, and remove cmd from return structure Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add backticks to other special chars in docs for consistency Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * on more formatting tweak to national chars in docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add new param to support tmp_hlq Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * extend tmphlq binding to sysprint(*), disable verbose mode for mvscmd call Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove references to betterargparser - it cannot be used in its current state as it is too restrictive on volume serial and qualifier args Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove soft language ie beware, please; reduce line lengths, fix a spelling error Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * reorganize test case code for more logical grouping and un-nesting from a for loop, also update copyright year that was missed Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update display command check to only check particular lines instead of entire output in test_volid_address_assigned_correctly which would always be positive when tested against the entire output Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> --------- Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> Co-authored-by: trevor-glassey <Trevor.Glassey@ibm.com> * Ported bugfixes for #664 and #678 from 1.5.0 (#743) * Ported bugfixes for #664 and #678 * Updated file normalization for sequential datasets * Fixed encoding when a remote source is used * Added encoding normalization for record length (#664) This is a port and tweak from the normalization found in the L2 support branch. Now the normalization applies for both local and remote source files. There is still work left to validate how this behaves when copying to partitioned datasets, and see if the normalization needs to handle directories as well. * Refactored normalization for USS files * Updated line endings normalization in PDSEs * Updated create_temp_with_lf_endings * Added tests for line endings normalization * Added changelog fragment * Updated changelog fragment * Updated copyright information * Added comments to record length tests * Added more context to the record length normalization * Add force (disp=shr) option to zos_lineinfile and update zos_blockinfile with the same locking test case. (#731) * Add DISP=SHR by function force to the user * Add helper function for force cases only for EOF inserts * Test cases added * Just to check in the change case * All test cases for force in zos_lineinfile working properly * Test cases for force blockinfile * Fixes for style of code * One identation error * One identation error * One identation error * Documentation error * All test cases for line infile and block infile * Comments * Change the stdout to assert with expected of ds * Error of test case * Fragment added * Solve typo errors * Update to remove uncessary comment Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with force comments Signed-off-by: ddimatos <dimatos@gmail.com> * Solve some test problems * Copyright year * Copyright year * Add cases for other ecodes * Add test for all encodings * Cover all encodes test cases with force * Blockinfile force added for other encodes and DS types --------- Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> Co-authored-by: Andre Marcel Gutierrez Benitez <andre@mbp-de-andre-2.gdl.mex.ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * remove duplicate function (#753) * Update branch production branch Main with release v1.5.0 content (#756) (#758) * Bug fix to correct job log returining and other edge cases (#688) * Update zos_job_submit to handle some edge cases and return the job log nearly always * Linting correction * Add changelog fragement for pr 683 * Clean up comments in code * Update restructured text for modules and changelog fragment * Add support to check for security exception to job submit module * Add additonal logic for jobs that use typerun=scan * Update chnagelog fragment * Correct run on sentence --------- * Added additional `D SYMBOLS` example to zos_operator documentation (#729) * Update zos_operator with an additional example * Added change fragment --------- * Ported bugfixes for #664 and #678 * Updated file normalization for sequential datasets * Fixed encoding when a remote source is used * Added encoding normalization for record length (#664) This is a port and tweak from the normalization found in the L2 support branch. Now the normalization applies for both local and remote source files. There is still work left to validate how this behaves when copying to partitioned datasets, and see if the normalization needs to handle directories as well. * Refactored normalization for USS files * Updated line endings normalization in PDSEs * Updated create_temp_with_lf_endings * Added tests for line endings normalization * Added changelog fragment * Add copy lib member test case * Corrected changelog fragment * Add conflict resolution * Update 641-copy-loadlib-member.yml * zos_copy forward port a test case for symbols on a volume (#739) * Add a test case for symbols using an existing volume on our test system * Add changelog fragment * Update 739-zos_copy-volume-symbol-test.yml Update description to use symbols overs special chars. * Update test case with added comments --------- * bring in updates to zos_gather_facts RETURN docstring (#744) * Solve problem 619 about set mode on dest file (#746) * Solve problem 619 about set mode on dest file * Add fragment of 746 PR --------- * Merge release tasks for v1.5.0 into release branch (#752) * Updated metadata * Updated copyright information * Updated copyright in README * Generated changelog * Added previous versions to changelog * Changed a minor_change fragment to bugfix * Updated release notes * Update dependency finder to allow for all tests minus skip tests * Update release notes and changelog with full date formats --------- * remove changelog fragments no longer needed (#754) --------- Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> Co-authored-by: Ivan Moreno <iamorenosoto@gmail.com> Co-authored-by: Fernando Flores <fernandofloresdev@gmail.com> Co-authored-by: Rich Parker <richp405@gmail.com> Co-authored-by: ketankelkar <ktnklkr@gmail.com> Co-authored-by: André Marcel Gutiérrez Benítez <68956970+AndreMarcel99@users.noreply.github.com> Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> * update galaxy and meta/ files Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update copyright years Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update rst doc files Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add 1.6.0-beta.1 release summary fragment Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * generate changelog Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add release notes Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add additional stylizing Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * Delete fragements once changelog is generated Signed-off-by: ddimatos <dimatos@gmail.com> * update stylizin…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Merge staging-v1.11.0-beta.1 release into main.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION