Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add secretmanager info module (#579) #580

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat: add secretmanager info module (#579) #580

wants to merge 5 commits into from

Conversation

tze-dev
Copy link

@tze-dev tze-dev commented Jun 22, 2023 •
edited
Loading

SUMMARY

PR for implementing #579

This is to implement an info module for retrieving list of GCP Secret Manager secrets metadata.
This module does NOT retrieve the actual secret payloads. Only metadata of secrets.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

module: gcp_secretmanager_info

ADDITIONAL INFORMATION

Example usage:

- name: get list of secrets and the associated versions - secret payload excluded
  gcp_secretmanager_info:
    project: "{{ project_id }}"
    auth_kind: application

toumorokoshi
toumorokoshi reviewed Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! thanks for the contribution.

Overall this looks good. Do you have a testcase to run this through?

plugins/modules/gcp_secretmanager_info.py Outdated
short_description: Gather info for GCP Secret Manager - List secrets and versions metadata.
author: Tze L. (https://github.com/tl-aiyor)
requirements:
- python >= 2.6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this really work with python2.6? Since it's a new module, we could just up the version.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What version do you suggest I bump up to? I can amend it if required.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess ansible 2.14 supports 2.7 or newer as of 2.13: https://endoflife.date/ansible-core#python-compatibility.

So how about updating to 2.7 at least?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the req in documentation from 2.6 to 2.7 in #8b88a27

@toumorokoshi
Copy link
Collaborator

I think if you can fix the sanity/lint errors I'm happy to merge it.

@tze-dev
Copy link
Author

tze-dev commented Jul 25, 2023

I think if you can fix the sanity/lint errors I'm happy to merge it.

@toumorokoshi just want to check in to see the progress of this? Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toumorokoshi toumorokoshi toumorokoshi left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tze-dev @toumorokoshi @tze-sxiq