Add custom hostname set in GCE to the hostnames block of the inventory plugin #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be super helpful for us... any chance of getting it merged? |
|
@rambleraptor Are PRs accepted on this repo or is there some other method to send changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This change allows the use of the custom hostname set when creating an instance in GCE as the
inventory_hostnamein playbooks. Includes a fallback to the instance name in the case that a custom hostname is not defined.ISSUE TYPE
COMPONENT NAME
gcp_compute.py(dynamic inventory plugin)ADDITIONAL INFORMATION
The
hostnameblock already allowed the dynamic inventory plugin to use the instance name, but I am setting a custom hostname for my instances (viaterraform) and wanted to be able to leverage that inansible. I added a few lines of code that allowed this, with a fallback in case some instances do not have a custom hostname set.