-
Notifications
You must be signed in to change notification settings - Fork 88
test: refactor for ansible-core 2.19 #419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
==========================================
+ Coverage 64.39% 72.56% +8.17%
==========================================
Files 16 21 +5
Lines 1747 2260 +513
Branches 374 475 +101
==========================================
+ Hits 1125 1640 +515
+ Misses 453 450 -3
- Partials 169 170 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I can hardly believe it, but after hours of trial and error, the tests now also work with the current Ansible devel version (2.19). This version has some changes. It handles certain values and args in the unit tests differently. The molecule tests for Ansible development (2.19) depend on the PR I mentioned in the PR description. |
720f0a4
to
4292aaf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Back to draft, I want to rewrite unit tests a little bit. I don't want to check against the version - I want to check if the import of the new args patch functions works with try/catch. I think It's a better approche than the version check.
@rndmh3ro Now everything is finished and ready for review. I don't think we'll have to wait until the merge at molecule plugins repo, right? |
LGTM! Do you want to fix the failing tests in devel at a later time? |
@rndmh3ro the molecule devel tests are failing because of ansible-community/molecule-plugins#308 |
SUMMARY
Since commit 9683ad2 some ansible tests fail. With this PR I want to update some versions and fix/improve some tests.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
Molecule tests for "devel" (ansible 2.19) will fail until ansible-community/molecule-plugins#308 is merged/fixed.