Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ufw: added support for vrrp protocol #9582

Merged
merged 5 commits into from
Jan 21, 2025

Conversation

Andrewb12505
Copy link
Contributor

@Andrewb12505 Andrewb12505 commented Jan 19, 2025

SUMMARY

Added the vrrp to list proto.
Changes made as described in #9562

Fixes #9562

ISSUE #TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/ufw.py

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type) labels Jan 19, 2025
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

changelogs/fragments/9582-add-support-for-vrrp.yml Outdated Show resolved Hide resolved
plugins/modules/ufw.py Outdated Show resolved Hide resolved
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-10 Automatically create a backport for the stable-10 branch labels Jan 19, 2025
@ansibullbot

This comment was marked as outdated.

@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jan 19, 2025
Andrewb12505 and others added 2 commits January 19, 2025 09:57
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
@ansibullbot ansibullbot removed the ci_verified Push fixes to PR branch to re-run CI label Jan 19, 2025
@Andrewb12505 Andrewb12505 changed the title [wip] ufw: added support for vrrp protocol ufw: added support for vrrp protocol Jan 19, 2025
@Andrewb12505
Copy link
Contributor Author

Thanks, for helping out with those typos I missed.

Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I'll merge this in a few days if nobody objects.

@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Jan 19, 2025
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jan 21, 2025
@felixfontein felixfontein merged commit c5cc949 into ansible-collections:main Jan 21, 2025
138 checks passed
Copy link

patchback bot commented Jan 21, 2025

Backport to stable-10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-10/c5cc9494921386eb35297decc59e2b95083dde95/pr-9582

Backported as #9595

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 21, 2025
* ufw: added support for vrrp protocol

* Add changelog fragment for (#9582)

* ufw: Add support for vrrp

Co-authored-by: Felix Fontein <felix@fontein.de>

* ufw: Add support for vrrp

Co-authored-by: Felix Fontein <felix@fontein.de>

* ufw: Add support for vrrp

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit c5cc949)
@felixfontein
Copy link
Collaborator

@Andrewb12505 thanks for your contribution!
@russoz thanks for reviewing!

felixfontein pushed a commit that referenced this pull request Jan 21, 2025
…rotocol (#9595)

ufw: added support for vrrp protocol (#9582)

* ufw: added support for vrrp protocol

* Add changelog fragment for (#9582)

* ufw: Add support for vrrp

Co-authored-by: Felix Fontein <felix@fontein.de>

* ufw: Add support for vrrp

Co-authored-by: Felix Fontein <felix@fontein.de>

* ufw: Add support for vrrp

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit c5cc949)

Co-authored-by: Andrew Bowen <andrewb12505@gmail.com>
@Andrewb12505 Andrewb12505 deleted the dev branch January 22, 2025 00:11
Massl123 pushed a commit to Massl123/community.general that referenced this pull request Feb 7, 2025
* ufw: added support for vrrp protocol

* Add changelog fragment for (ansible-collections#9582)

* ufw: Add support for vrrp

Co-authored-by: Felix Fontein <felix@fontein.de>

* ufw: Add support for vrrp

Co-authored-by: Felix Fontein <felix@fontein.de>

* ufw: Add support for vrrp

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-10 Automatically create a backport for the stable-10 branch feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ufw supports vrrp, but community.general.ufw plugin does not
4 participants