Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opentelemetry callback plugin: remove unused code #9503

Merged
merged 2 commits into from
Dec 31, 2024
Merged

opentelemetry callback plugin: remove unused code #9503

merged 2 commits into from
Dec 31, 2024

Conversation

v1v
Copy link
Contributor

@v1v v1v commented Dec 31, 2024 •
edited
Loading

SUMMARY

Part of #9454

ISSUE TYPE
  • Refactoring Pull Request
COMPONENT NAME

plugins/callback/opentelemetry.py

ADDITIONAL INFORMATION

OTEL_LIBRARY_TIME_NS_ERROR was introduced at #5342 (comment) and partially removed in #9482

I'm testing this PR in here - that's a basic test framework using logs validations that I built some time ago.

@v1v v1v marked this pull request as ready for review December 31, 2024 09:48
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-10 Automatically create a backport for the stable-10 branch labels Dec 31, 2024
@ansibullbot ansibullbot added callback callback plugin plugins plugin (any type) labels Dec 31, 2024
@felixfontein felixfontein merged commit 6e919a4 into ansible-collections:main Dec 31, 2024
129 checks passed
@patchback Patchback
Copy link

patchback bot commented Dec 31, 2024 •
edited
Loading

Backport to stable-10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-10/6e919a4b7678e258d4610c2fef4b28f00ed0c641/pr-9503

Backported as #9504

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Dec 31, 2024
@felixfontein
Copy link
Collaborator

@v1v thanks for your contribution!

patchback bot pushed a commit that referenced this pull request Dec 31, 2024
@v1v @patchback
opentelemetry callback plugin: remove unused code (#9503)
b8a3951 
* opentelemetry callback plugin: remove unused code

* changelog

(cherry picked from commit 6e919a4)
@patchback patchback bot mentioned this pull request Dec 31, 2024
Merged
felixfontein pushed a commit that referenced this pull request Dec 31, 2024
@patchback @v1v
[PR #9503/6e919a4b backport][stable-10] opentelemetry callback plugin…
62b45e2 
…: remove unused code (#9504)

opentelemetry callback plugin: remove unused code (#9503)

* opentelemetry callback plugin: remove unused code

* changelog

(cherry picked from commit 6e919a4)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Massl123 pushed a commit to Massl123/community.general that referenced this pull request Feb 7, 2025
@v1v @Massl123
opentelemetry callback plugin: remove unused code (ansible-collection…
4ee6344 
…s#9503)

* opentelemetry callback plugin: remove unused code

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
backport-10 Automatically create a backport for the stable-10 branch callback callback plugin plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v1v @felixfontein @ansibullbot