lookup plugins: use f-strings #9324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
ci_verified
@felixfontein this looks like a snafu from |
ansibullbot
added
ci_verified
felixfontein
added
backport-10
For now it's best to add ignore.txt entries. The check has been removed from ansible-core 2.17 anyway, so fixing it is no longer possible. |
|
(Ref: ansible/ansible@9dd3eaf) |
Co-authored-by: Felix Fontein <felix@fontein.de>
ansibullbot
added
ci_verified
ansibullbot
added
tests
Co-authored-by: Felix Fontein <felix@fontein.de>
ansibullbot
added
needs_ci
ansibullbot
removed
the
needs_revision
felixfontein
approved these changes
Dec 25, 2024
Backport to stable-10: 💚 backport PR created✅ Backport PR branch: Backported as #9367 🤖 @patchback |
felixfontein
removed
the
check-before-release
patchback bot
pushed a commit
that referenced
this pull request
Dec 25, 2024
* lookup plugins: use f-strings * add changelog frag * manual change for few occurrences * Update plugins/lookup/dependent.py Co-authored-by: Felix Fontein <felix@fontein.de> * adjustment from review * no f-string for you * Update plugins/lookup/dependent.py Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 6cd3f79)
|
@russoz thanks for your contribution! |
felixfontein
pushed a commit
that referenced
this pull request
Dec 25, 2024
…#9367) lookup plugins: use f-strings (#9324) * lookup plugins: use f-strings * add changelog frag * manual change for few occurrences * Update plugins/lookup/dependent.py Co-authored-by: Felix Fontein <felix@fontein.de> * adjustment from review * no f-string for you * Update plugins/lookup/dependent.py Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 6cd3f79) Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Massl123
pushed a commit
to Massl123/community.general
that referenced
this pull request
Feb 7, 2025
* lookup plugins: use f-strings * add changelog frag * manual change for few occurrences * Update plugins/lookup/dependent.py Co-authored-by: Felix Fontein <felix@fontein.de> * adjustment from review * no f-string for you * Update plugins/lookup/dependent.py Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Use f-strings instead of string interpolations or string format().
ISSUE TYPE
COMPONENT NAME
plugins/lookup/bitwarden.py
plugins/lookup/chef_databag.py
plugins/lookup/collection_version.py
plugins/lookup/consul_kv.py
plugins/lookup/credstash.py
plugins/lookup/cyberarkpassword.py
plugins/lookup/dependent.py
plugins/lookup/dig.py
plugins/lookup/dnstxt.py
plugins/lookup/dsv.py
plugins/lookup/etcd.py
plugins/lookup/etcd3.py
plugins/lookup/filetree.py
plugins/lookup/github_app_access_token.py
plugins/lookup/hiera.py
plugins/lookup/keyring.py
plugins/lookup/lastpass.py
plugins/lookup/lmdb_kv.py
plugins/lookup/manifold.py
plugins/lookup/merge_variables.py
plugins/lookup/onepassword.py
plugins/lookup/onepassword_doc.py
plugins/lookup/passwordstore.py
plugins/lookup/random_pet.py
plugins/lookup/redis.py
plugins/lookup/revbitspss.py
plugins/lookup/shelvefile.py
plugins/lookup/tss.py