Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

callback plugins: use f-strings #9321

Merged

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Dec 23, 2024

SUMMARY

Use f-strings instead of string interpolations or string format().

ISSUE TYPE
  • Refactoring Pull Request
COMPONENT NAME

plugins/callback/cgroup_memory_recap.py
plugins/callback/context_demo.py
plugins/callback/counter_enabled.py
plugins/callback/dense.py
plugins/callback/diy.py
plugins/callback/elastic.py
plugins/callback/jabber.py
plugins/callback/log_plays.py
plugins/callback/loganalytics.py
plugins/callback/logdna.py
plugins/callback/logentries.py
plugins/callback/mail.py
plugins/callback/nrdp.py
plugins/callback/opentelemetry.py
plugins/callback/say.py
plugins/callback/selective.py
plugins/callback/slack.py
plugins/callback/splunk.py
plugins/callback/timestamp.py
plugins/callback/unixy.py
plugins/callback/yaml.py

@ansibullbot ansibullbot added callback callback plugin plugins plugin (any type) labels Dec 23, 2024
@felixfontein felixfontein added backport-10 Automatically create a backport for the stable-10 branch check-before-release PR will be looked at again shortly before release and merged if possible. labels Dec 23, 2024
plugins/callback/counter_enabled.py Outdated Show resolved Hide resolved
plugins/callback/dense.py Outdated Show resolved Hide resolved
plugins/callback/dense.py Outdated Show resolved Hide resolved
plugins/callback/loganalytics.py Outdated Show resolved Hide resolved
russoz and others added 2 commits December 24, 2024 10:36
@felixfontein felixfontein merged commit c3ed214 into ansible-collections:main Dec 24, 2024
129 checks passed
Copy link

patchback bot commented Dec 24, 2024

Backport to stable-10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-10/c3ed2144e2585ee7c91761f666767154e299c734/pr-9321

Backported as #9357

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 24, 2024
* callback plugins: use f-strings

* add changelog frag

* manual change for few occurrences

* manual change for few occurrences

* adjustment from review

* adjustment from review

* adjustment from review

* Update plugins/callback/splunk.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* replace str templating with JSON templating

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit c3ed214)
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Dec 24, 2024
@felixfontein
Copy link
Collaborator

@russoz thanks!

@russoz russoz deleted the fstr-callback-plugins branch December 24, 2024 12:45
felixfontein pushed a commit that referenced this pull request Dec 24, 2024
…gs (#9357)

callback plugins: use f-strings (#9321)

* callback plugins: use f-strings

* add changelog frag

* manual change for few occurrences

* manual change for few occurrences

* adjustment from review

* adjustment from review

* adjustment from review

* Update plugins/callback/splunk.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* replace str templating with JSON templating

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit c3ed214)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Massl123 pushed a commit to Massl123/community.general that referenced this pull request Feb 7, 2025
* callback plugins: use f-strings

* add changelog frag

* manual change for few occurrences

* manual change for few occurrences

* adjustment from review

* adjustment from review

* adjustment from review

* Update plugins/callback/splunk.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* replace str templating with JSON templating

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-10 Automatically create a backport for the stable-10 branch callback callback plugin plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants