proxmox_template: fix the wrong path called on proxmox_template.task_status #9277

xunleii · 2024-12-18T00:11:12Z

SUMMARY

The task_status functions uses the wrong Proxmox API path to fetch tasks logs (node instead of nodes). The documentation can be found here: https://pve.proxmox.com/pve-docs/api-viewer/index.html#/nodes/{node}/tasks (the node path doesn't exist)

Fixes #9276

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

proxmox_template

ansibullbot · 2024-12-18T00:23:29Z

cc @Ajpantuso @Thulium-Drake @UnderGreen @joshainglis @karmab @krauthosting
click here for bot help

felixfontein

Thanks for your contribution! My guess is that the path changed in some Proxmox release. The module also needs to support Proxmox versions where it currently works, so you need to figure out in which version it changed and adjust the code to only use the new path for the appropriate versions.

...agments/9277-proxmox_template-fix-the-wrong-path-called-on-proxmox_template.task_status.yaml

xunleii · 2024-12-21T08:09:11Z

Thanks for your contribution! My guess is that the path changed in some Proxmox release. The module also needs to support Proxmox versions where it currently works, so you need to figure out in which version it changed and adjust the code to only use the new path for the appropriate versions.

Hello, thank you for your reply.

I hadn't thought to do any research, thinking it was a typo 😅.

However, after some research, and as far as I can go, the API path to interact with a node has always been nodes and not node.

Here's an archive dating from 2016 on which you can see the nodes path: https://web.archive.org/web/20160823164612/http://pve.proxmox.com:80/pve-docs/api-viewer/index.html (I had a problem viewing it, running document.getElementsByClassName(“x-grid-item-container”)[0].removeAttribute('style') in Dev Console should help).
I also researched the first API definition from the documentation (https://github.com/proxmox/pve-docs/blob/561229878cc7e18ae9644af4e4fd4ca2f4c46f06/api-viewer/apidata.js) and found no reference to a /node/.

With all this in mind, I think it's a typo 😟.

Missing the 's' means using the wrong API, making log reading impossible. Should fix !9276 Co-Authored-By: Felix Fontein <felix@fontein.de> Signed-off-by: Alexandre Nicolaie <xunleii@users.noreply.github.com>

russoz

LGTM

patchback · 2024-12-30T11:47:53Z

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/403418f75da9b23d0cef65ca582ed7f7cdb65e16/pr-9277

Backported as #9475

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

…status (#9277) fix: add missing 's' on proxmox_template.task_status Missing the 's' means using the wrong API, making log reading impossible. Should fix !9276 Signed-off-by: Alexandre Nicolaie <xunleii@users.noreply.github.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 403418f)

patchback · 2024-12-30T11:48:02Z

Backport to stable-10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-10/403418f75da9b23d0cef65ca582ed7f7cdb65e16/pr-9277

Backported as #9476

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

…status (#9277) fix: add missing 's' on proxmox_template.task_status Missing the 's' means using the wrong API, making log reading impossible. Should fix !9276 Signed-off-by: Alexandre Nicolaie <xunleii@users.noreply.github.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 403418f)

felixfontein · 2024-12-30T11:48:12Z

@xunleii thanks for your contribution!
@russoz thanks for reviewing!

…g path called on proxmox_template.task_status (#9475) proxmox_template: fix the wrong path called on proxmox_template.task_status (#9277) fix: add missing 's' on proxmox_template.task_status Missing the 's' means using the wrong API, making log reading impossible. Should fix !9276 Signed-off-by: Alexandre Nicolaie <xunleii@users.noreply.github.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 403418f) Co-authored-by: Alexandre Nicolaie <xunleii@users.noreply.github.com>

…ng path called on proxmox_template.task_status (#9476) proxmox_template: fix the wrong path called on proxmox_template.task_status (#9277) fix: add missing 's' on proxmox_template.task_status Missing the 's' means using the wrong API, making log reading impossible. Should fix !9276 Signed-off-by: Alexandre Nicolaie <xunleii@users.noreply.github.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 403418f) Co-authored-by: Alexandre Nicolaie <xunleii@users.noreply.github.com>

…status (ansible-collections#9277) fix: add missing 's' on proxmox_template.task_status Missing the 's' means using the wrong API, making log reading impossible. Should fix !9276 Signed-off-by: Alexandre Nicolaie <xunleii@users.noreply.github.com> Co-authored-by: Felix Fontein <felix@fontein.de>

xunleii changed the title ~~proxmox_template: add missing 's' on proxmox_template.task_status~~ proxmox_template: fix the wrong path called on proxmox_template.task_status Dec 18, 2024

xunleii force-pushed the main branch 2 times, most recently from 2254068 to 956db7e Compare December 18, 2024 00:21

ansibullbot added bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type) labels Dec 18, 2024

felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-9 Automatically create a backport for the stable-9 branch backport-10 Automatically create a backport for the stable-10 branch labels Dec 20, 2024

felixfontein reviewed Dec 20, 2024

View reviewed changes

...agments/9277-proxmox_template-fix-the-wrong-path-called-on-proxmox_template.task_status.yaml Outdated Show resolved Hide resolved

xunleii force-pushed the main branch 3 times, most recently from 6d82eb2 to 9d5fd39 Compare December 21, 2024 08:26

fix: add missing 's' on proxmox_template.task_status

0e44300

Missing the 's' means using the wrong API, making log reading impossible. Should fix !9276 Co-Authored-By: Felix Fontein <felix@fontein.de> Signed-off-by: Alexandre Nicolaie <xunleii@users.noreply.github.com>

xunleii force-pushed the main branch from 9d5fd39 to 0e44300 Compare December 21, 2024 08:26

This comment was marked as outdated.

Sign in to view

ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Dec 21, 2024

ansibullbot added stale_ci CI is older than 7 days, rerun before merging and removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Dec 29, 2024

russoz approved these changes Dec 29, 2024

View reviewed changes

felixfontein merged commit 403418f into ansible-collections:main Dec 30, 2024
129 checks passed

felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Dec 30, 2024

patchback bot mentioned this pull request Dec 30, 2024

[PR #9277/403418f7 backport][stable-9] proxmox_template: fix the wrong path called on proxmox_template.task_status #9475

Merged

patchback bot mentioned this pull request Dec 30, 2024

[PR #9277/403418f7 backport][stable-10] proxmox_template: fix the wrong path called on proxmox_template.task_status #9476

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

proxmox_template: fix the wrong path called on proxmox_template.task_status #9277

proxmox_template: fix the wrong path called on proxmox_template.task_status #9277

xunleii commented Dec 18, 2024 •

edited

Loading

ansibullbot commented Dec 18, 2024

felixfontein left a comment

xunleii commented Dec 21, 2024 •

edited

Loading

This comment was marked as outdated.

russoz left a comment

patchback bot commented Dec 30, 2024 •

edited

Loading

patchback bot commented Dec 30, 2024 •

edited

Loading

felixfontein commented Dec 30, 2024

proxmox_template: fix the wrong path called on proxmox_template.task_status #9277

proxmox_template: fix the wrong path called on proxmox_template.task_status #9277

Conversation

xunleii commented Dec 18, 2024 • edited Loading

SUMMARY

ISSUE TYPE

COMPONENT NAME

ansibullbot commented Dec 18, 2024

felixfontein left a comment

Choose a reason for hiding this comment

xunleii commented Dec 21, 2024 • edited Loading

This comment was marked as outdated.

russoz left a comment

Choose a reason for hiding this comment

patchback bot commented Dec 30, 2024 • edited Loading

Backport to stable-9: 💚 backport PR created

patchback bot commented Dec 30, 2024 • edited Loading

Backport to stable-10: 💚 backport PR created

felixfontein commented Dec 30, 2024

xunleii commented Dec 18, 2024 •

edited

Loading

xunleii commented Dec 21, 2024 •

edited

Loading

patchback bot commented Dec 30, 2024 •

edited

Loading

patchback bot commented Dec 30, 2024 •

edited

Loading