Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9223/6f87bf2b backport][stable-10] Fix incorrect key lookup #9232

Merged
merged 1 commit into from
Dec 9, 2024
Merged

[PR #9223/6f87bf2b backport][stable-10] Fix incorrect key lookup #9232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix incorrect key lookup (#9223) 
* Fix incorrect key lookup

* Create changelog fragment

(cherry picked from commit 6f87bf2)
  • Loading branch information
@IamLunchbox @patchback
IamLunchbox authored and patchback[bot] committed Dec 9, 2024
commit fc9552f0c51c3d33d0d4163c76080324c441a4ef
2 changes: 2 additions & 0 deletions changelogs/fragments/9223-proxmox-backup-bugfixes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- proxmox_backup - fix incorrect key lookup in vmid permission check (https://github.com/ansible-collections/community.general/pull/9223).
2 changes: 1 addition & 1 deletion plugins/modules/proxmox_backup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ def check_vmid_backup_permission(self, permissions, vmids, pool):
if "/" in permissions.keys() and permissions["/"].get(
"VM.Backup", 0) == 1:
sufficient_permissions = True
elif "/vms" in permissions.keys() and permissions["/"].get(
elif "/vms" in permissions.keys() and permissions["/vms"].get(
"VM.Backup", 0) == 1:
sufficient_permissions = True
elif pool and "/pool/" + pool in permissions.keys() and permissions["/pool/" + pool].get(
Expand Down
Loading