Clean up Proxmox API token handling by stripping whitespace and forma… #9228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ansibullbot
added
bug
…tting the token string
xilmen
force-pushed
the
fix_issue_9227
branch
from
622ffaa to
367bcb7
Compare
felixfontein
added
check-before-release
felixfontein
reviewed
Dec 8, 2024
| # Clean and format token components | ||
| user = self.proxmox_user.strip() | ||
| token_id = self.proxmox_token_id.strip() | ||
| token_secret = self.proxmox_token_secret.strip() |
There was a problem hiding this comment.
I'm wondering whether this is a good idea. Is token_secret a user-selected string that can potentially have valid whitespace in it, that would get incorrectly removed by this change? (Most likely spaces, and not newlines.)
There was a problem hiding this comment.
Normally, pve tokens should never have spaces. If this is the case the token will be invalid in all cases.
https://pve.proxmox.com/wiki/Proxmox_VE_API#Example:_Use_API_Token
Exemple with token format
curl -H "Authorization: PVEAPIToken=root@pam!monitoring=aaaaaaaaa-bbb-cccc-dddd-ef0123456789" https://10.0.0.1:8006/api2/json/
There was a problem hiding this comment.
Hmm, what about token IDs and usernames? Can they have spaces?
There was a problem hiding this comment.
i try to create local user with space. It's not possible.
userid: invalid format - value 'user name@pam' does not look like a valid user name
(i cant try with other type (LDAP/AD/OpenID))
we can remove strip to self.proxmox_user if you prefer.
There was a problem hiding this comment.
Did you also test token ID? If that doesn't work either, everything should be fine.
There was a problem hiding this comment.
I try for token ID space is not possible :
Method 'POST /access/users/ansible@pam/token/user space' not implemented (501)
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
|
If nobody objects, I'll merge this at the end of next week. |
felixfontein
removed
the
check-before-release
Backport to stable-10: 💚 backport PR created✅ Backport PR branch: Backported as #9288 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Dec 20, 2024
#9228) * Clean up Proxmox API token handling by stripping whitespace and formatting the token string * Update plugins/inventory/proxmox.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/inventory/proxmox.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update changelogs/fragments/9228-fix-issue-header.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update changelogs/fragments/9228-fix-issue-header.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit c5855d1)
felixfontein
pushed a commit
that referenced
this pull request
Dec 20, 2024
…ndling by stripping whitespace and forma… (#9288) Clean up Proxmox API token handling by stripping whitespace and forma… (#9228) * Clean up Proxmox API token handling by stripping whitespace and formatting the token string * Update plugins/inventory/proxmox.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/inventory/proxmox.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update changelogs/fragments/9228-fix-issue-header.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update changelogs/fragments/9228-fix-issue-header.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit c5855d1) Co-authored-by: xilmen <romain.scha@gmail.com>
erichoog
pushed a commit
to erichoog/community.general
that referenced
this pull request
Dec 23, 2024
ansible-collections#9228) * Clean up Proxmox API token handling by stripping whitespace and formatting the token string * Update plugins/inventory/proxmox.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/inventory/proxmox.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update changelogs/fragments/9228-fix-issue-header.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update changelogs/fragments/9228-fix-issue-header.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de>
Massl123
pushed a commit
to Massl123/community.general
that referenced
this pull request
Feb 7, 2025
ansible-collections#9228) * Clean up Proxmox API token handling by stripping whitespace and formatting the token string * Update plugins/inventory/proxmox.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/inventory/proxmox.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update changelogs/fragments/9228-fix-issue-header.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update changelogs/fragments/9228-fix-issue-header.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix header issue for proxmox dynamic inventory with vault
#9227
ISSUE TYPE
COMPONENT NAME
proxmox inventory
ADDITIONAL INFORMATION
#9227