keycloak_clientscope_type: sort default and optional clientscope lists before diff #9202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
felixfontein
added
check-before-release
|
If nobody objects, I'll merge this on Sunday. |
|
unrelated to the PR, but when I opened the file to check something out, I spotted a typo (an "e" missing) in line 43, doc block. You might one to add that to this PR already ;-) |
russoz
reviewed
Dec 1, 2024
Comment on lines
+194
to
+198
| scopes_copy = scopes.copy() | ||
| if isinstance(scopes_copy.get('default_clientscopes'), list): | ||
| scopes_copy['default_clientscopes'] = sorted(scopes_copy['default_clientscopes']) | ||
| if isinstance(scopes_copy.get('optional_clientscopes'), list): | ||
| scopes_copy['optional_clientscopes'] = sorted(scopes_copy['optional_clientscopes']) |
There was a problem hiding this comment.
Doing the copy is a bit redundant. This could be simplified as:
Suggested change
| scopes_copy = scopes.copy() | |
| if isinstance(scopes_copy.get('default_clientscopes'), list): | |
| scopes_copy['default_clientscopes'] = sorted(scopes_copy['default_clientscopes']) | |
| if isinstance(scopes_copy.get('optional_clientscopes'), list): | |
| scopes_copy['optional_clientscopes'] = sorted(scopes_copy['optional_clientscopes']) | |
| scopes_copy = { | |
| 'default_clientscopes': sorted(scopes['default_clientscopes']) if scopes['default_clientscopes'] else [], | |
| 'optional_clientscopes': sorted(scopes['optional_clientscopes']) if scopes['optional_clientscopes'] else [], | |
| } |
felixfontein
removed
the
check-before-release
Backport to stable-9: 💚 backport PR created✅ Backport PR branch: Backported as #9221 🤖 @patchback |
Backport to stable-10: 💚 backport PR created✅ Backport PR branch: Backported as #9222 🤖 @patchback |
|
@fgruenbauer thanks for your contribution! |
felixfontein
pushed a commit
that referenced
this pull request
Dec 2, 2024
…t default and optional clientscope lists before diff (#9221) keycloak_clientscope_type: sort default and optional clientscope lists before diff (#9202) * sort default and optional clientscope lists before diff * add changelog fragment (cherry picked from commit 55d714d) Co-authored-by: fgruenbauer <gruenbauer@b1-systems.de>
felixfontein
pushed a commit
that referenced
this pull request
Dec 2, 2024
…rt default and optional clientscope lists before diff (#9222) keycloak_clientscope_type: sort default and optional clientscope lists before diff (#9202) * sort default and optional clientscope lists before diff * add changelog fragment (cherry picked from commit 55d714d) Co-authored-by: fgruenbauer <gruenbauer@b1-systems.de>
Massl123
pushed a commit
to Massl123/community.general
that referenced
this pull request
Feb 7, 2025
…s before diff (ansible-collections#9202) * sort default and optional clientscope lists before diff * add changelog fragment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The change sorts the default and optional clientscope lists before the diff, to make the diff more accurate.
Before:
After:
ISSUE TYPE
COMPONENT NAME
keycloak_clientscope_type