Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnf_config_manager: use --assumeyes when changing state #9124

Merged
merged 5 commits into from
Nov 17, 2024

Conversation

ahyattdev
Copy link
Contributor

@ahyattdev ahyattdev commented Nov 13, 2024

SUMMARY

Runs dnf config-manager with --assumeyes to automatically import GPG keys instead of hanging at y/N prompt.

Fixes #8830

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

dnf_config_manager

ADDITIONAL INFORMATION

@ahyattdev ahyattdev changed the title dnf_config_manager: use --assumeyesm when changing state dnf_config_manager: use --assumeyes when changing state Nov 13, 2024
@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module plugins plugin (any type) tests tests unit tests/unit labels Nov 13, 2024
@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Nov 13, 2024
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @ahyattdev

Just a minor nit to keep consistency in our documentation, other than that, LGTM

changelogs/fragments/9124-dnf_config_manager.yml Outdated Show resolved Hide resolved
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-10 Automatically create a backport for the stable-10 branch backport-9 Automatically create a backport for the stable-9 branch labels Nov 14, 2024
@felixfontein
Copy link
Collaborator

If nobody objects, I'll merge this on this weekend.

Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein merged commit 36c7e56 into ansible-collections:main Nov 17, 2024
129 checks passed
Copy link

patchback bot commented Nov 17, 2024

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/36c7e56005b2e78dff9bec3b3a605e5834661128/pr-9124

Backported as #9141

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Nov 17, 2024
patchback bot pushed a commit that referenced this pull request Nov 17, 2024
* dnf_config_manager: use --assumeyesm when changing state

* changelog fragment

* update tests

* format fix

* Update changelogs/fragments/9124-dnf_config_manager.yml

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

---------

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
(cherry picked from commit 36c7e56)
Copy link

patchback bot commented Nov 17, 2024

Backport to stable-10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-10/36c7e56005b2e78dff9bec3b3a605e5834661128/pr-9124

Backported as #9142

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@ahyattdev thanks for your contribution!
@russoz thanks for reviewing!

patchback bot pushed a commit that referenced this pull request Nov 17, 2024
* dnf_config_manager: use --assumeyesm when changing state

* changelog fragment

* update tests

* format fix

* Update changelogs/fragments/9124-dnf_config_manager.yml

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

---------

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
(cherry picked from commit 36c7e56)
felixfontein pushed a commit that referenced this pull request Nov 17, 2024
…umeyes when changing state (#9142)

dnf_config_manager: use --assumeyes when changing state (#9124)

* dnf_config_manager: use --assumeyesm when changing state

* changelog fragment

* update tests

* format fix

* Update changelogs/fragments/9124-dnf_config_manager.yml

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

---------

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
(cherry picked from commit 36c7e56)

Co-authored-by: Andrew Hyatt <4400272+ahyattdev@users.noreply.github.com>
felixfontein pushed a commit that referenced this pull request Nov 17, 2024
…meyes when changing state (#9141)

dnf_config_manager: use --assumeyes when changing state (#9124)

* dnf_config_manager: use --assumeyesm when changing state

* changelog fragment

* update tests

* format fix

* Update changelogs/fragments/9124-dnf_config_manager.yml

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

---------

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
(cherry picked from commit 36c7e56)

Co-authored-by: Andrew Hyatt <4400272+ahyattdev@users.noreply.github.com>
Massl123 pushed a commit to Massl123/community.general that referenced this pull request Feb 7, 2025
…ections#9124)

* dnf_config_manager: use --assumeyesm when changing state

* changelog fragment

* update tests

* format fix

* Update changelogs/fragments/9124-dnf_config_manager.yml

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

---------

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-9 Automatically create a backport for the stable-9 branch backport-10 Automatically create a backport for the stable-10 branch bug This issue/PR relates to a bug module module plugins plugin (any type) tests tests unit tests/unit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

community.general.dnf_config_manager Hangs on repolist after activating repository
4 participants