keycloak_clientscope_type fix checkmode #9093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
felixfontein
added
the
check-before-release
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
the
needs_revision
This comment was marked as outdated.
This comment was marked as outdated.
witrdotnet
force-pushed
the
keycloak/keycloak_clientscope_type_checkmode
branch
from
77444c7 to
d2254dc
Compare
This comment was marked as outdated.
This comment was marked as outdated.
witrdotnet
force-pushed
the
keycloak/keycloak_clientscope_type_checkmode
branch
from
d2254dc to
28dbc98
Compare
ansibullbot
removed
ci_verified
felixfontein
reviewed
Nov 2, 2024
changelogs/fragments/9092-keycloak-clientscope-type-fix-check-mode.yml
Outdated
Show resolved
Hide resolved
felixfontein
added
the
backport-9
felixfontein
reviewed
Nov 2, 2024
changelogs/fragments/9092-keycloak-clientscope-type-fix-check-mode.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
|
If nobody objects, I'll merge this tomorrow. |
Backport to stable-9: 💚 backport PR created✅ Backport PR branch: Backported as #9095 🤖 @patchback |
felixfontein
removed
the
check-before-release
patchback bot
pushed a commit
that referenced
this pull request
Nov 3, 2024
* fix check_mode on set keycloak client scope type (#9092) * add changelog fragment (#9092) * update changelog fragment (#9092) * compact code: make one line conditions with list comprehension and any() Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com> * fix syntax error: remove extra ')' * fix changelog fragment type Co-authored-by: Felix Fontein <felix@fontein.de> * add issue's link in changelog fragment Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 8fc11fe)
|
@witrdotnet thanks for your contribution! |
felixfontein
pushed a commit
that referenced
this pull request
Nov 3, 2024
…checkmode (#9095) keycloak_clientscope_type fix checkmode (#9093) * fix check_mode on set keycloak client scope type (#9092) * add changelog fragment (#9092) * update changelog fragment (#9092) * compact code: make one line conditions with list comprehension and any() Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com> * fix syntax error: remove extra ')' * fix changelog fragment type Co-authored-by: Felix Fontein <felix@fontein.de> * add issue's link in changelog fragment Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 8fc11fe) Co-authored-by: witrdotnet <witr.net@gmail.com>
Massl123
pushed a commit
to Massl123/community.general
that referenced
this pull request
Feb 7, 2025
* fix check_mode on set keycloak client scope type (ansible-collections#9092) * add changelog fragment (ansible-collections#9092) * update changelog fragment (ansible-collections#9092) * compact code: make one line conditions with list comprehension and any() Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com> * fix syntax error: remove extra ')' * fix changelog fragment type Co-authored-by: Felix Fontein <felix@fontein.de> * add issue's link in changelog fragment Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com> Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Exit json with
resultonly after evaluatingdefault_clientscopes_add,optional_clientscopes_add,default_clientscopes_delete,optional_clientscopes_deleteand after updatingresult["changed"]. Otherwise,keycloak_clientscope_typewill not detect changes in check mode.Fixes #9092
ISSUE TYPE
COMPONENT NAME
keycloak_clientscope_typeADDITIONAL INFORMATION
Before fix (check mode)
After fix (check mode)