-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consul_kv: add argument for the datacenter option on consul api #9026
Merged
felixfontein
merged 3 commits into
ansible-collections:main
from
raspbeguy:consul_kv-datacenter
Oct 19, 2024
Merged
consul_kv: add argument for the datacenter option on consul api #9026
felixfontein
merged 3 commits into
ansible-collections:main
from
raspbeguy:consul_kv-datacenter
Oct 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I've added some first comments below.
Co-authored-by: Felix Fontein <felix@fontein.de>
russoz
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@raspbeguy thanks for your contribution! |
1 task
Massl123
pushed a commit
to Massl123/community.general
that referenced
this pull request
Feb 7, 2025
…ble-collections#9026) * consul_kv: add argument for the datacenter option on consul api * changelog: add fragment for ansible-collections#9026 * Apply suggestions from code review Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
This issue/PR relates to a feature request
module
module
new_contributor
Help guide this first time contributor
plugins
plugin (any type)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ISSUE TYPE
COMPONENT NAME
consul_kv
ADDITIONAL INFORMATION
Consul supports a
datacenter
feature allowing to use a consul agent to connect to a different consul datacenter.Here is the consul CLI documentation.
Here is the python-consul documentation.