Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consul_kv: add argument for the datacenter option on consul api #9026

Merged
merged 3 commits into from
Oct 19, 2024

Conversation

raspbeguy
Copy link
Contributor

SUMMARY
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

consul_kv

ADDITIONAL INFORMATION

Consul supports a datacenter feature allowing to use a consul agent to connect to a different consul datacenter.

Here is the consul CLI documentation.

Here is the python-consul documentation.

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type) labels Oct 14, 2024
@felixfontein felixfontein added the check-before-release PR will be looked at again shortly before release and merged if possible. label Oct 14, 2024
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I've added some first comments below.

changelogs/fragments/9026-consul_kv-datacenter.yml Outdated Show resolved Hide resolved
plugins/modules/consul_kv.py Show resolved Hide resolved
plugins/modules/consul_kv.py Show resolved Hide resolved
Co-authored-by: Felix Fontein <felix@fontein.de>
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein merged commit 26fe427 into ansible-collections:main Oct 19, 2024
126 checks passed
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Oct 19, 2024
@felixfontein
Copy link
Collaborator

@raspbeguy thanks for your contribution!
@russoz thanks for reviewing!

Massl123 pushed a commit to Massl123/community.general that referenced this pull request Feb 7, 2025
…ble-collections#9026)

* consul_kv: add argument for the datacenter option on consul api

* changelog: add fragment for ansible-collections#9026

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants