Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

one_vnet: Fix module #9019

Merged
merged 3 commits into from
Oct 21, 2024
Merged

one_vnet: Fix module #9019

merged 3 commits into from
Oct 21, 2024

Conversation

abakanovskii
Copy link
Contributor

SUMMARY

Thats a hotfix for a one_vnet module

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

one_vnet

ADDITIONAL INFORMATION
  1. VN_MAD instead of VM_MAD (https://github.com/privazio/pyone/blob/master/pyone/xsd/vnet_pool.xsd#L69) - typo
  2. VNET insead of VMTEMPLATE (https://github.com/privazio/pyone/blob/master/pyone/xsd/vnet_pool.xsd#L8) - typo
  3. Fix loop for .AR_POOL.AR, I'm as confused as you are but apparently using simple for in doesn't work as .AR_POOL.AR without specifying index ([0]) will return first ID but not the full list
  4. -1 (https://github.com/acidburn0zzz/docs-2/blob/23f0ac32b5bb11caa8a180977a423076dc577cce/source/integration/system_interfaces/api.rst#onevnallocate) - lack of parameter

I'm really sorry for not testing manually these before as I thought it would be similar to a template (OpenNebula API is so weird tbh)
I tested it locally on my OpenNebula server and now it works as it should :)
Also backport is needed because without these fixes module just dont work

@ansibullbot
Copy link
Collaborator

cc @ilicmilan @meerkampdvv @nilsding @rsmontero @xorel
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module plugins plugin (any type) labels Oct 11, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-9 Automatically create a backport for the stable-9 branch labels Oct 11, 2024
felixfontein
felixfontein reviewed Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Just a quick note:

plugins/modules/one_vnet.py Show resolved Hide resolved
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Oct 19, 2024
@ansibullbot ansibullbot removed the stale_ci CI is older than 7 days, rerun before merging label Oct 19, 2024
felixfontein
felixfontein approved these changes Oct 19, 2024
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can judge, this looks ok.

russoz
russoz approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we have a majority in favour of moving forward :-)

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Oct 21, 2024
@felixfontein felixfontein merged commit 93be499 into ansible-collections:main Oct 21, 2024
126 checks passed
@patchback Patchback
Copy link

patchback bot commented Oct 21, 2024 •
edited
Loading

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/93be499f26a59faa5ba171ab44f22beea2533e74/pr-9019

Backported as #9049

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 21, 2024
@abakanovskii @patchback
one_vnet: Fix module (#9019)
0e470a0 
* Fix one_vnet module

* Add CHANGELOG

* Fix CHANGELOG

(cherry picked from commit 93be499)
@patchback patchback bot mentioned this pull request Oct 21, 2024
Merged
@felixfontein
Copy link
Collaborator

@abakanovskii thanks for fixing this!
@russoz thanks for reviewing!

felixfontein pushed a commit that referenced this pull request Oct 21, 2024
@patchback @abakanovskii
[PR #9019/93be499f backport][stable-9] one_vnet: Fix module (#9049)
65dd204 
one_vnet: Fix module (#9019)

* Fix one_vnet module

* Add CHANGELOG

* Fix CHANGELOG

(cherry picked from commit 93be499)

Co-authored-by: alexander <79072457+abakanovskii@users.noreply.github.com>
Massl123 pushed a commit to Massl123/community.general that referenced this pull request Feb 7, 2025
@abakanovskii @Massl123
one_vnet: Fix module (ansible-collections#9019)
0a71c61 
* Fix one_vnet module

* Add CHANGELOG

* Fix CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russoz russoz russoz approved these changes

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
backport-9 Automatically create a backport for the stable-9 branch bug This issue/PR relates to a bug module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abakanovskii @ansibullbot @felixfontein @russoz