Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9012/67ddb567 backport][stable-9] Dell PwrButton requires a job initated at reboot #9015

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Oct 10, 2024

This is a backport of PR #9012 as merged into main (67ddb56).

SUMMARY

Dell systems do not change the bios setting PwrButton right away. The command will return changed=true all the time, but it is not applied. Also no job is scheduled at next reboot for the change to take place. This patch aims to fix this issue.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

redfish_utils / refish_config

ADDITIONAL INFORMATION
  1. Use curl to verify the current configuration:
curl -u foobar:foobar https://my.host/redfish/v1/Systems/System.Embedded.1/Bios -k -s | jq '.Attributes.PwrButton'
"Enabled"
  1. Run community.general.redfish_config with params:
community.general.redfish_config:
  category: 'Systems'
  command: 'SetBiosAttributes'
  bios_attributes:
    PwrButton: 'Disabled'
  baseuri: 'my.host.com'
  username: 'foobar'
  password: 'foobar'
  1. The output will always return {"changed": true, "msg": "Modified BIOS attributes {'PwrButton': 'Disabled'}
  2. No update job is scheduled in the iDRAC system.
  3. Using curl again to verify no change took place
curl -u foobar:foobar https://my.host/redfish/v1/Systems/System.Embedded.1/Bios -k -s | jq '.Attributes.PwrButton'
"Enabled"
  1. One can continuously run this task and the output will always be the same.

With my patch a job will be scheduled and the output will change as expected.

fatal: [127.0.0.1]: FAILED! => {"changed": false, "msg": "HTTP Error 400 on PATCH request to 'https://my.host/redfish/v1/Systems/System.Embedded.1/Bios/Settings', extended message: 'Pending configuration values are already committed, unable to perform another set operation.'"}

I'm not aware currently of what other parameters require a reboot when changing them, thus this patch is limited to only "PwrButton"

Dell systems do not change the bios setting PwrButton right away. The
command will return changed=true, but it is not applied. Also no job is
scheduled at next reboot for the change to take place. This patch aims
to fix this issue.

(cherry picked from commit 67ddb56)
@felixfontein felixfontein merged commit 21a840e into stable-9 Oct 10, 2024
140 checks passed
@felixfontein felixfontein deleted the patchback/backports/stable-9/67ddb567c90f6a03dd3a9a3e2c4873c415b07e0d/pr-9012 branch October 10, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants