Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

udm_user, homectl: use legacycrypt on Python 3.13+ #8987

Merged
merged 1 commit into from
Oct 7, 2024
Merged

udm_user, homectl: use legacycrypt on Python 3.13+ #8987

merged 1 commit into from
Oct 7, 2024

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

On Python 3.13, crypt has been removed from the standard library. There's now a PyPI package legacycrypt which contains the removed module. Use that one if available.

Ref: #4690
Ref: #4691

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

udm_user
homectl

@felixfontein felixfontein added backport-8 Automatically create a backport for the stable-8 branch backport-9 Automatically create a backport for the stable-9 branch labels Oct 5, 2024
@ansibullbot
Copy link
Collaborator

cc @jameslivulpi @keachi
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug integration tests/integration module module plugins plugin (any type) tests tests labels Oct 5, 2024
@felixfontein felixfontein requested a review from russoz October 5, 2024 15:49
russoz
russoz approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein merged commit 29a2df8 into ansible-collections:main Oct 7, 2024
141 checks passed
@patchback Patchback
Copy link

patchback bot commented Oct 7, 2024 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/29a2df8e6b6b52f28aa99474f753cb5e7d343603/pr-8987

Backported as #8992

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein deleted the legacycrypt branch October 7, 2024 19:56
patchback bot pushed a commit that referenced this pull request Oct 7, 2024
@felixfontein @patchback
udm_user, homectl: use legacycrypt on Python 3.13+ (#8987)
aaf1267 
Use legacycrypt on Python 3.13+.

(cherry picked from commit 29a2df8)
@felixfontein
Copy link
Collaborator Author

@russoz thanks for reviewing this!

@patchback patchback bot mentioned this pull request Oct 7, 2024
Merged
@patchback Patchback
Copy link

patchback bot commented Oct 7, 2024 •
edited
Loading

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/29a2df8e6b6b52f28aa99474f753cb5e7d343603/pr-8987

Backported as #8993

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 7, 2024
@felixfontein @patchback
udm_user, homectl: use legacycrypt on Python 3.13+ (#8987)
c07f6fe 
Use legacycrypt on Python 3.13+.

(cherry picked from commit 29a2df8)
@patchback patchback bot mentioned this pull request Oct 7, 2024
Merged
@felixfontein
Copy link
Collaborator Author

@russoz thanks for reviewing this!

felixfontein added a commit that referenced this pull request Oct 7, 2024
@patchback @felixfontein
[PR #8987/29a2df8e backport][stable-9] udm_user, homectl: use legacyc…
2766898 
…rypt on Python 3.13+ (#8993)

udm_user, homectl: use legacycrypt on Python 3.13+ (#8987)

Use legacycrypt on Python 3.13+.

(cherry picked from commit 29a2df8)

Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein added a commit that referenced this pull request Oct 7, 2024
@patchback @felixfontein
[PR #8987/29a2df8e backport][stable-8] udm_user, homectl: use legacyc…
5362908 
…rypt on Python 3.13+ (#8992)

udm_user, homectl: use legacycrypt on Python 3.13+ (#8987)

Use legacycrypt on Python 3.13+.

(cherry picked from commit 29a2df8)

Co-authored-by: Felix Fontein <felix@fontein.de>
Massl123 pushed a commit to Massl123/community.general that referenced this pull request Feb 7, 2025
@felixfontein @Massl123
udm_user, homectl: use legacycrypt on Python 3.13+ (ansible-collectio…
2f7497d 
…ns#8987)

Use legacycrypt on Python 3.13+.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russoz russoz russoz approved these changes

Assignees
No one assigned
Labels
backport-8 Automatically create a backport for the stable-8 branch backport-9 Automatically create a backport for the stable-9 branch bug This issue/PR relates to a bug integration tests/integration module module plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixfontein @ansibullbot @russoz