Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare 10.0.0 release #8921

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Prepare 10.0.0 release #8921

merged 3 commits into from
Oct 7, 2024

Conversation

felixfontein
Copy link
Collaborator

@felixfontein felixfontein commented Sep 25, 2024 •
edited
Loading

SUMMARY

Currently contains #8918. Will rebase once that's merged.

This PR should be rebased and merged once community.general 9.5.0 has been released. From that point on, main will start preparing 10.0.0.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

various

@ansibullbot
Copy link
Collaborator

cc @Ajpantuso @FlossWare @Ilgmi @Thulium-Drake @UnderGreen @apollo13 @cnsnyder @giovannisciortino @helldorado @jlaska @joshainglis @jpmens @karmab @krauthosting @privateip @ptoscano @sgargan @sivel @vincentvdk @vritant
click here for bot help

@ansibullbot ansibullbot added WIP Work in progress callback callback plugin feature This issue/PR relates to a feature request integration tests/integration module module plugins plugin (any type) redhat_subscription tests tests unit tests/unit labels Sep 25, 2024
@ptoscano
Copy link
Contributor

As part of "remove deprecated modules and plugins", you can also drop plugins/module_utils/redhat.py entirely, as the dropped rhn_register module is its only consumer.

@felixfontein felixfontein added the breaking_change This PR contains a breaking change that MUST NOT be backported label Sep 25, 2024
@felixfontein
Copy link
Collaborator Author

@ptoscano we haven't deprecated that, and it's part of the public API of the collection.

@felixfontein
Copy link
Collaborator Author

Oh, I see that it is marked as deprecated.

@ansibullbot ansibullbot added the module_utils module_utils label Sep 25, 2024
@felixfontein felixfontein mentioned this pull request Sep 26, 2024
Merged
@felixfontein felixfontein force-pushed the 10.0.0 branch 2 times, most recently from ef1c50e to 3299d30 Compare September 28, 2024 05:12
@ansibullbot
Copy link
Collaborator

cc @alikins @barnabycourt
click here for bot help

@ptoscano
Copy link
Contributor

LGTM for rhn_register, rhn_channel, and module_utils.redhat.

(that said, since I was the one deprecating them for removal in the first place, obviously I'm biased here)

@felixfontein felixfontein mentioned this pull request Sep 29, 2024
Closed
1 task
@felixfontein
Copy link
Collaborator Author

Good point, I added a reminder to #7434, in case someone really wants to keep the module(s). (They can always be resurrected under another name and/or in another collection if needed, anyway...)

@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Oct 7, 2024
@felixfontein felixfontein changed the title [WIP] Prepare 10.0.0 release Prepare 10.0.0 release Oct 7, 2024
@felixfontein felixfontein marked this pull request as ready for review October 7, 2024 21:17
@ansibullbot ansibullbot removed WIP Work in progress stale_ci CI is older than 7 days, rerun before merging labels Oct 7, 2024
@felixfontein felixfontein merged commit ec64960 into ansible-collections:main Oct 7, 2024
126 checks passed
@felixfontein felixfontein deleted the 10.0.0 branch October 7, 2024 21:37
@felixfontein
Copy link
Collaborator Author

@ptoscano thanks for reviewing!

Massl123 pushed a commit to Massl123/community.general that referenced this pull request Feb 7, 2025
@felixfontein @Massl123
Prepare 10.0.0 release (ansible-collections#8921)
057d456 
* Bump version to 10.0.0, remove deprecated modules and plugins.

* Remove redhat module utils.

* Drop support for ansible-core 2.13 and ansible-core 2.14.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking_change This PR contains a breaking change that MUST NOT be backported callback callback plugin feature This issue/PR relates to a feature request has_issue integration tests/integration module_utils module_utils module module plugins plugin (any type) redhat_subscription tests tests unit tests/unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixfontein @ansibullbot @ptoscano