-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use dict comprehension in plugins, part 3 #8833
Merged
felixfontein
merged 2 commits into
ansible-collections:main
from
russoz-ansible:dict-comprehension-3
Sep 8, 2024
Merged
use dict comprehension in plugins, part 3 #8833
felixfontein
merged 2 commits into
ansible-collections:main
from
russoz-ansible:dict-comprehension-3
Sep 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
approved these changes
Sep 6, 2024
Backport to stable-9: 💚 backport PR created✅ Backport PR branch: Backported as #8835 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Sep 8, 2024
* use dict comprehension in plugins, part 3 * add changelog frag (cherry picked from commit 26df6c7)
@russoz thanks! |
aioue
pushed a commit
to aioue/community.general
that referenced
this pull request
Oct 1, 2024
* use dict comprehension in plugins, part 3 * add changelog frag
Massl123
pushed a commit
to Massl123/community.general
that referenced
this pull request
Feb 7, 2025
* use dict comprehension in plugins, part 3 * add changelog frag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-9
Automatically create a backport for the stable-9 branch
cache
cache plugin
cloud
lookup
lookup plugin
module_utils
module_utils
module
module
plugins
plugin (any type)
tests
tests
unit
tests/unit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Another PR to mass-replace the construct
dict((k, v) for k, v in d if condition)
with dict comprehensions:{k: v for k, v in d if condition}
ISSUE TYPE
COMPONENT NAME
plugins/cache/redis.py
plugins/lookup/onepassword.py
plugins/module_utils/ocapi_utils.py
plugins/module_utils/redfish_utils.py
plugins/module_utils/scaleway.py
plugins/modules/alternatives.py
plugins/modules/apache2_mod_proxy.py
plugins/modules/consul_acl.py
plugins/modules/imc_rest.py
plugins/modules/keycloak_user_federation.py
plugins/modules/pids.py
plugins/modules/pipx.py
plugins/modules/pipx_info.py
plugins/modules/pkg5_publisher.py
plugins/modules/scaleway_compute.py
plugins/modules/scaleway_ip.py
plugins/modules/scaleway_lb.py
plugins/modules/scaleway_security_group.py
plugins/modules/scaleway_user_data.py
plugins/modules/sensu_silence.py
plugins/modules/snmp_facts.py
plugins/modules/sorcery.py
tests/unit/plugins/module_utils/test_cmd_runner.py
tests/unit/plugins/module_utils/test_python_runner.py