keycloak_user_federation: remove lastSync param from kc API responses
#8812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
WIP
felixfontein
added
check-before-release
1 task
ansibullbot
added
needs_rebase
fgruenbauer
force-pushed
the
keycloak-user-federation-ignore-lastSync-value
branch
from
7b4dd2e to
1007345
Compare
ansibullbot
removed
needs_rebase
This comment was marked as outdated.
This comment was marked as outdated.
fgruenbauer
force-pushed
the
keycloak-user-federation-ignore-lastSync-value
branch
from
1007345 to
5deecbf
Compare
felixfontein
removed
the
check-before-release
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #8976 🤖 @patchback |
|
@fgruenbauer thanks for your contribution! |
Backport to stable-9: 💚 backport PR created✅ Backport PR branch: Backported as #8977 🤖 @patchback |
felixfontein
pushed a commit
that referenced
this pull request
Oct 3, 2024
…ve `lastSync` param from kc API responses (#8976) keycloak_user_federation: remove `lastSync` param from kc API responses (#8812) * remove `lastSync` param from kc API responses * add blank line to satisfy sanity check * add changelog fragment * fix NoneType error introduced by changed normalize func return value (cherry picked from commit 5d9a7ab) Co-authored-by: fgruenbauer <gruenbauer@b1-systems.de>
felixfontein
pushed a commit
that referenced
this pull request
Oct 3, 2024
…ve `lastSync` param from kc API responses (#8977) keycloak_user_federation: remove `lastSync` param from kc API responses (#8812) * remove `lastSync` param from kc API responses * add blank line to satisfy sanity check * add changelog fragment * fix NoneType error introduced by changed normalize func return value (cherry picked from commit 5d9a7ab) Co-authored-by: fgruenbauer <gruenbauer@b1-systems.de>
Massl123
pushed a commit
to Massl123/community.general
that referenced
this pull request
Feb 7, 2025
…es (ansible-collections#8812) * remove `lastSync` param from kc API responses * add blank line to satisfy sanity check * add changelog fragment * fix NoneType error introduced by changed normalize func return value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Keycloak stores a timestamp of the last ldap sync in the parameter
lastSync. Once the parameter is set after a sync (periodic or manual), the module always detects a change and shows a diff similar to the one below.The parameter seems to be used to time the periodic syncs, so i don't think changing it is good idea. The API does allow changing it though. But I did not find a way to view or change the parameter in the web GUI.
It looks like the parameter is only used by kc internally, so it should be safe to ignore it and remove it entirely from all API responses.
Fixes 5842
ISSUE TYPE
COMPONENT NAME
community.general.keycloak_user_federation