Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipx: add new states #8809

Merged
merged 12 commits into from
Sep 6, 2024
Merged

pipx: add new states #8809

merged 12 commits into from
Sep 6, 2024

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Aug 27, 2024

SUMMARY
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

pipx

@russoz russoz changed the title pipx: add new states [WIP] pipx: add new states Aug 27, 2024
@ansibullbot ansibullbot added WIP Work in progress feature This issue/PR relates to a feature request module module module_utils module_utils plugins plugin (any type) labels Aug 27, 2024
@ansibullbot ansibullbot added integration tests/integration tests tests labels Aug 27, 2024
@ansibullbot

This comment was marked as resolved.

Sign in to view
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-9 Automatically create a backport for the stable-9 branch labels Aug 27, 2024
russoz and others added 3 commits August 27, 2024 19:10
@russoz russoz changed the title [WIP] pipx: add new states pipx: add new states Aug 27, 2024
@ansibullbot ansibullbot removed the WIP Work in progress label Aug 27, 2024
felixfontein
felixfontein reviewed Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late update...

plugins/modules/pipx.py Outdated Show resolved Hide resolved
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Sep 5, 2024
@ansibullbot ansibullbot removed the stale_ci CI is older than 7 days, rerun before merging label Sep 6, 2024
felixfontein
felixfontein reviewed Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, two more details ;) Feel free to merge once these are fixed and CI passes. Otherwise I'll do it on the weekend.

plugins/modules/pipx.py Outdated Show resolved Hide resolved
tests/integration/targets/pipx/files/spec.json.license Outdated Show resolved Hide resolved
russoz and others added 2 commits September 7, 2024 08:34
@russoz @felixfontein
Update plugins/modules/pipx.py
75fd2f3 
Co-authored-by: Felix Fontein <felix@fontein.de>
@russoz @felixfontein
Update tests/integration/targets/pipx/files/spec.json.license
defff2e 
Co-authored-by: Felix Fontein <felix@fontein.de>
@russoz russoz merged commit 43f8adf into ansible-collections:main Sep 6, 2024
147 checks passed
@patchback Patchback
Copy link

patchback bot commented Sep 6, 2024 •
edited
Loading

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/43f8adf1a5c7184310bc6ef7deee6fd8ebb5d9c1/pr-8809

Backported as #8834

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 6, 2024
@russoz @patchback
pipx: add new states (#8809)
28bd928 
* ensure minimum version of pip

* ensure pipx 1.7.0 is installed

* pipx: add new states/params

* add tests

* add license to json file

* Update plugins/modules/pipx.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* fix uninject tests

* add changelog frag

* fix doc per review

* refactor license out of pipx spec file

* Update plugins/modules/pipx.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update tests/integration/targets/pipx/files/spec.json.license

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 43f8adf)
@patchback patchback bot mentioned this pull request Sep 6, 2024
Merged
@russoz russoz deleted the pipx-new-params branch September 6, 2024 21:49
@felixfontein
Copy link
Collaborator

@russoz thanks for your contribution!

felixfontein pushed a commit that referenced this pull request Sep 7, 2024
@patchback @russoz
[PR #8809/43f8adf1 backport][stable-9] pipx: add new states (#8834)
73a1ac2 
pipx: add new states (#8809)

* ensure minimum version of pip

* ensure pipx 1.7.0 is installed

* pipx: add new states/params

* add tests

* add license to json file

* Update plugins/modules/pipx.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* fix uninject tests

* add changelog frag

* fix doc per review

* refactor license out of pipx spec file

* Update plugins/modules/pipx.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update tests/integration/targets/pipx/files/spec.json.license

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 43f8adf)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Sep 8, 2024
aioue pushed a commit to aioue/community.general that referenced this pull request Oct 1, 2024
@russoz @felixfontein @aioue
pipx: add new states (ansible-collections#8809)
3c50563 
* ensure minimum version of pip

* ensure pipx 1.7.0 is installed

* pipx: add new states/params

* add tests

* add license to json file

* Update plugins/modules/pipx.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* fix uninject tests

* add changelog frag

* fix doc per review

* refactor license out of pipx spec file

* Update plugins/modules/pipx.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update tests/integration/targets/pipx/files/spec.json.license

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
Massl123 pushed a commit to Massl123/community.general that referenced this pull request Feb 7, 2025
@russoz @felixfontein @Massl123
pipx: add new states (ansible-collections#8809)
03a3c8e 
* ensure minimum version of pip

* ensure pipx 1.7.0 is installed

* pipx: add new states/params

* add tests

* add license to json file

* Update plugins/modules/pipx.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* fix uninject tests

* add changelog frag

* fix doc per review

* refactor license out of pipx spec file

* Update plugins/modules/pipx.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update tests/integration/targets/pipx/files/spec.json.license

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
backport-9 Automatically create a backport for the stable-9 branch feature This issue/PR relates to a feature request integration tests/integration module_utils module_utils module module plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russoz @ansibullbot @felixfontein