Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proxmox inventory: fixing possible concatenation error #8794

Merged
merged 3 commits into from
Sep 1, 2024
Merged

proxmox inventory: fixing possible concatenation error #8794

merged 3 commits into from
Sep 1, 2024

Conversation

a17t
Copy link
Contributor

@a17t a17t commented Aug 24, 2024 •
edited by felixfontein
Loading

SUMMARY

When starting to use the proxmox inventory plugin with my 4 node setup, the plugin failed creating the inventory from the proxmox api. Some debugging led to the changed area, where it may happen that API calls return an empty result, leading to json["data"] being None and the list concatenation failing.

Fixes #8798

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

inventory: community.general.proxmox

ADDITIONAL INFORMATION

@ansibullbot
Copy link
Collaborator

cc @Ajpantuso @Thulium-Drake @ilijamt @joshainglis @karmab @krauthosting
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug inventory inventory plugin new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Aug 24, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-8 Automatically create a backport for the stable-8 branch backport-9 Automatically create a backport for the stable-9 branch labels Aug 24, 2024
@felixfontein
Copy link
Collaborator

Thanks for your contribution! Can you please add a changelog fragment? Thanks.

@felixfontein felixfontein mentioned this pull request Aug 25, 2024
Closed
1 task
@kennethso168
Copy link

Fixes #8798

@a17t
Copy link
Contributor Author

a17t commented Aug 25, 2024

Thanks for your contribution! Can you please add a changelog fragment? Thanks.

Will add that tomorrow, sorry for not looking up contribution guidelines, just quickly fixed an Issue I had while using.

@felixfontein
Copy link
Collaborator

No worries :)

@ansibullbot ansibullbot removed the small_patch Hopefully easy to review label Aug 26, 2024
@felixfontein
Copy link
Collaborator

I'll merge this in a few days if nobody objects.

@russoz russoz changed the title Fixing possible concatination error proxmox inventory: fixing possible concatenation error Aug 31, 2024
@felixfontein felixfontein merged commit 249126f into ansible-collections:main Sep 1, 2024
147 checks passed
@patchback Patchback
Copy link

patchback bot commented Sep 1, 2024 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/249126f42972edd1ec427c777588b9d5ccf4bfbb/pr-8794

Backported as #8816

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 1, 2024
@a17t @patchback
proxmox inventory: fixing possible concatenation error (#8794)
c1f6923 
* Fixing possible concatination error

* Create 8794-Fixing-possible-concatination-error.yaml

* Update 8794-Fixing-possible-concatination-error.yaml

Updating changelog

(cherry picked from commit 249126f)
@patchback patchback bot mentioned this pull request Sep 1, 2024
Merged
@patchback Patchback
Copy link

patchback bot commented Sep 1, 2024 •
edited
Loading

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/249126f42972edd1ec427c777588b9d5ccf4bfbb/pr-8794

Backported as #8818

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 1, 2024
@a17t @patchback
proxmox inventory: fixing possible concatenation error (#8794)
0037adb 
* Fixing possible concatination error

* Create 8794-Fixing-possible-concatination-error.yaml

* Update 8794-Fixing-possible-concatination-error.yaml

Updating changelog

(cherry picked from commit 249126f)
@patchback patchback bot mentioned this pull request Sep 1, 2024
Merged
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Sep 1, 2024
@felixfontein
Copy link
Collaborator

@a17t thanks a lot for your contribution!

felixfontein pushed a commit that referenced this pull request Sep 1, 2024
@patchback @a17t
[PR #8794/249126f4 backport][stable-8] proxmox inventory: fixing poss…
e14ebe3 
…ible concatenation error (#8816)

proxmox inventory: fixing possible concatenation error (#8794)

* Fixing possible concatination error

* Create 8794-Fixing-possible-concatination-error.yaml

* Update 8794-Fixing-possible-concatination-error.yaml

Updating changelog

(cherry picked from commit 249126f)

Co-authored-by: Simon Siebert <Mail@simonsiebert.de>
felixfontein pushed a commit that referenced this pull request Sep 1, 2024
@patchback @a17t
[PR #8794/249126f4 backport][stable-9] proxmox inventory: fixing poss…
19613ce 
…ible concatenation error (#8818)

proxmox inventory: fixing possible concatenation error (#8794)

* Fixing possible concatination error

* Create 8794-Fixing-possible-concatination-error.yaml

* Update 8794-Fixing-possible-concatination-error.yaml

Updating changelog

(cherry picked from commit 249126f)

Co-authored-by: Simon Siebert <Mail@simonsiebert.de>
aioue pushed a commit to aioue/community.general that referenced this pull request Oct 1, 2024
@a17t @aioue
proxmox inventory: fixing possible concatenation error (ansible-colle…
89b6076 
…ctions#8794)

* Fixing possible concatination error

* Create 8794-Fixing-possible-concatination-error.yaml

* Update 8794-Fixing-possible-concatination-error.yaml

Updating changelog
TobiasZeuch181 pushed a commit to TobiasZeuch181/zypper_repository_add_list that referenced this pull request Oct 2, 2024
@a17t @TobiasZeuch181
proxmox inventory: fixing possible concatenation error (ansible-colle…
7704a23 
…ctions#8794)

* Fixing possible concatination error

* Create 8794-Fixing-possible-concatination-error.yaml

* Update 8794-Fixing-possible-concatination-error.yaml

Updating changelog
Massl123 pushed a commit to Massl123/community.general that referenced this pull request Feb 7, 2025
@a17t @Massl123
proxmox inventory: fixing possible concatenation error (ansible-colle…
59863a5 
…ctions#8794)

* Fixing possible concatination error

* Create 8794-Fixing-possible-concatination-error.yaml

* Update 8794-Fixing-possible-concatination-error.yaml

Updating changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
backport-8 Automatically create a backport for the stable-8 branch backport-9 Automatically create a backport for the stable-9 branch bug This issue/PR relates to a bug has_issue inventory inventory plugin new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

community.general.proxmox inventory plugin fails for a cluster setup in 9.3.0
4 participants
@a17t @ansibullbot @felixfontein @kennethso168