Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipx/pipx_info: add parameter global #8793

Merged
merged 13 commits into from
Aug 26, 2024
Merged

pipx/pipx_info: add parameter global #8793

merged 13 commits into from
Aug 26, 2024

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Aug 24, 2024 •
edited
Loading

SUMMARY

Add new global parameter to both pipx and pipx_info modules.

Fixes #8705

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

pipx
pipx_info

@ansibullbot ansibullbot added WIP Work in progress feature This issue/PR relates to a feature request integration tests/integration module module module_utils module_utils plugins plugin (any type) tests tests labels Aug 24, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-9 Automatically create a backport for the stable-9 branch labels Aug 24, 2024
felixfontein
felixfontein reviewed Aug 24, 2024
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

plugins/modules/pipx.py Show resolved Hide resolved
plugins/modules/pipx_info.py Show resolved Hide resolved
@russoz russoz changed the title [WIP] pipx/pipx_info: add new parameters pipx/pipx_info: add new parameters Aug 25, 2024
@russoz
Copy link
Collaborator Author

russoz commented Aug 25, 2024 •
edited
Loading

@felixfontein
I think this PR is already big enough as it is, so it's probably better to go for it now and raise another one for the other new parameters.

Cc: @gaby

@ansibullbot ansibullbot removed the WIP Work in progress label Aug 25, 2024
@gaby
Copy link

gaby commented Aug 25, 2024

@russoz There was a big bug related to --global fixed in v1.7.0 should this required v1.7.0 instead?

Release
https://github.com/pypa/pipx/releases/tag/1.7.0

Related PR pypa/pipx#1476

@russoz
Copy link
Collaborator Author

russoz commented Aug 25, 2024

Probably a good idea.

@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Aug 25, 2024
@russoz russoz changed the title pipx/pipx_info: add new parameters pipx/pipx_info: add parameter global Aug 25, 2024
felixfontein
felixfontein reviewed Aug 25, 2024
View reviewed changes
changelogs/fragments/8793-pipx-global.yml Outdated Show resolved Hide resolved
changelogs/fragments/8793-pipx-global.yml Outdated Show resolved Hide resolved
plugins/modules/pipx.py
notes:
- This module requires C(pipx) version 0.16.2.1 or above.
- This module requires C(pipx) version 0.16.2.1 or above. From community.general 11.0.0 onwards, the module will require C(pipx>=1.7.0).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth to at some point move some documentation / common code (corresponding argspec) to a docs fragment + module utils.

russoz and others added 2 commits August 26, 2024 06:42
@russoz @felixfontein
Update changelogs/fragments/8793-pipx-global.yml
f28d75b 
Co-authored-by: Felix Fontein <felix@fontein.de>
@russoz @felixfontein
Update changelogs/fragments/8793-pipx-global.yml
e2b8fb5 
Co-authored-by: Felix Fontein <felix@fontein.de>
@ansibullbot ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Aug 25, 2024
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Aug 26, 2024
@felixfontein felixfontein merged commit 9c9c4cb into ansible-collections:main Aug 26, 2024
147 checks passed
@felixfontein
Copy link
Collaborator

@russoz thanks for your contribution!
@gaby thanks for reviewing!

@felixfontein felixfontein added backport-9 Automatically create a backport for the stable-9 branch and removed backport-9 Automatically create a backport for the stable-9 branch labels Aug 26, 2024
@patchback Patchback
Copy link

patchback bot commented Aug 26, 2024 •
edited
Loading

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/9c9c4cbc3ef9ef2e1a6c9312e4ed97ffcbab276e/pr-8793

Backported as #8807

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 26, 2024
@russoz @patchback
pipx/pipx_info: add parameter global (#8793)
87548da 
* pipx/pipx_info: add new parameters

* add test for --global, refactor int test main file

* ensure initial state of test

* ensure PATH includes /usr/local/bin

* ensure PATH includes /usr/local/bin for entire block

* ensure minimum version of pip

* ensure pipx 1.6.0 is installed

* push recommendation for pipx 1.7.0 instead of 1.6.0

* add changelog frag

* add deprecatons to changelog frag

* add deprecatons to changelog frag, better

* Update changelogs/fragments/8793-pipx-global.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update changelogs/fragments/8793-pipx-global.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 9c9c4cb)
@patchback patchback bot mentioned this pull request Aug 26, 2024
Merged
felixfontein pushed a commit that referenced this pull request Aug 26, 2024
@patchback @russoz
[PR #8793/9c9c4cbc backport][stable-9] pipx/pipx_info: add parameter …
b935dce 
…`global` (#8807)

pipx/pipx_info: add parameter `global` (#8793)

* pipx/pipx_info: add new parameters

* add test for --global, refactor int test main file

* ensure initial state of test

* ensure PATH includes /usr/local/bin

* ensure PATH includes /usr/local/bin for entire block

* ensure minimum version of pip

* ensure pipx 1.6.0 is installed

* push recommendation for pipx 1.7.0 instead of 1.6.0

* add changelog frag

* add deprecatons to changelog frag

* add deprecatons to changelog frag, better

* Update changelogs/fragments/8793-pipx-global.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update changelogs/fragments/8793-pipx-global.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 9c9c4cb)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
@russoz russoz deleted the 8705-pipx-global branch August 27, 2024 01:29
aioue pushed a commit to aioue/community.general that referenced this pull request Oct 1, 2024
@russoz @felixfontein @aioue
pipx/pipx_info: add parameter global (ansible-collections#8793)
b96e4f4 
* pipx/pipx_info: add new parameters

* add test for --global, refactor int test main file

* ensure initial state of test

* ensure PATH includes /usr/local/bin

* ensure PATH includes /usr/local/bin for entire block

* ensure minimum version of pip

* ensure pipx 1.6.0 is installed

* push recommendation for pipx 1.7.0 instead of 1.6.0

* add changelog frag

* add deprecatons to changelog frag

* add deprecatons to changelog frag, better

* Update changelogs/fragments/8793-pipx-global.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update changelogs/fragments/8793-pipx-global.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
TobiasZeuch181 pushed a commit to TobiasZeuch181/zypper_repository_add_list that referenced this pull request Oct 2, 2024
@russoz @felixfontein @TobiasZeuch181
pipx/pipx_info: add parameter global (ansible-collections#8793)
9762fec 
* pipx/pipx_info: add new parameters

* add test for --global, refactor int test main file

* ensure initial state of test

* ensure PATH includes /usr/local/bin

* ensure PATH includes /usr/local/bin for entire block

* ensure minimum version of pip

* ensure pipx 1.6.0 is installed

* push recommendation for pipx 1.7.0 instead of 1.6.0

* add changelog frag

* add deprecatons to changelog frag

* add deprecatons to changelog frag, better

* Update changelogs/fragments/8793-pipx-global.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update changelogs/fragments/8793-pipx-global.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
Massl123 pushed a commit to Massl123/community.general that referenced this pull request Feb 7, 2025
@russoz @felixfontein @Massl123
pipx/pipx_info: add parameter global (ansible-collections#8793)
9c88c7b 
* pipx/pipx_info: add new parameters

* add test for --global, refactor int test main file

* ensure initial state of test

* ensure PATH includes /usr/local/bin

* ensure PATH includes /usr/local/bin for entire block

* ensure minimum version of pip

* ensure pipx 1.6.0 is installed

* push recommendation for pipx 1.7.0 instead of 1.6.0

* add changelog frag

* add deprecatons to changelog frag

* add deprecatons to changelog frag, better

* Update changelogs/fragments/8793-pipx-global.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update changelogs/fragments/8793-pipx-global.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
backport-9 Automatically create a backport for the stable-9 branch feature This issue/PR relates to a feature request integration tests/integration module_utils module_utils module module plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pipx: Add support for --global parameter
4 participants
@russoz @gaby @felixfontein @ansibullbot