keycloak_user_federation: add module arg to make mapper removal optout #8764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
WIP
|
@https://github.com/canon-cmre-benoit-lecardonnel - Could you check if you get the original behavior when the removal is disabled? |
felixfontein
added
check-before-release
ansibullbot
added
needs_ci
changelogs/fragments/8764-keycloak_user_federation-make-mapper-removal-optout.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Felix Fontein <felix@fontein.de>
…-removal-optout.yml Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
fgruenbauer
force-pushed
the
keycloak-user-federation-make-mapper-removal-configurable
branch
from
6bafd0a to
fe7fec2
Compare
|
^ Sorry, made a bad rebase. You can ignore the mentions. Should be fixed now. |
felixfontein
approved these changes
Aug 21, 2024
felixfontein
removed
the
check-before-release
|
@fgruenbauer thanks for your contribution! |
felixfontein
added
backport-9
Backport to stable-9: 💚 backport PR created✅ Backport PR branch: Backported as #8804 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
#8764) * add module arg to make mapper removal optout * change parameter name to snake case: remove_unspecified_mappers * add period to parameter description Co-authored-by: Felix Fontein <felix@fontein.de> * use dict indexing to get parameter instead of `.get()` * add changelog fragment * Update changelogs/fragments/8764-keycloak_user_federation-make-mapper-removal-optout.yml Co-authored-by: Felix Fontein <felix@fontein.de> * add `version_added` to argument description Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/keycloak_user_federation.py Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 7dc4429)
felixfontein
pushed a commit
that referenced
this pull request
Aug 26, 2024
…module arg to make mapper removal optout (#8804) keycloak_user_federation: add module arg to make mapper removal optout (#8764) * add module arg to make mapper removal optout * change parameter name to snake case: remove_unspecified_mappers * add period to parameter description Co-authored-by: Felix Fontein <felix@fontein.de> * use dict indexing to get parameter instead of `.get()` * add changelog fragment * Update changelogs/fragments/8764-keycloak_user_federation-make-mapper-removal-optout.yml Co-authored-by: Felix Fontein <felix@fontein.de> * add `version_added` to argument description Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/keycloak_user_federation.py Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 7dc4429) Co-authored-by: fgruenbauer <gruenbauer@b1-systems.de>
aioue
pushed a commit
to aioue/community.general
that referenced
this pull request
Oct 1, 2024
ansible-collections#8764) * add module arg to make mapper removal optout * change parameter name to snake case: remove_unspecified_mappers * add period to parameter description Co-authored-by: Felix Fontein <felix@fontein.de> * use dict indexing to get parameter instead of `.get()` * add changelog fragment * Update changelogs/fragments/8764-keycloak_user_federation-make-mapper-removal-optout.yml Co-authored-by: Felix Fontein <felix@fontein.de> * add `version_added` to argument description Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/keycloak_user_federation.py Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de>
TobiasZeuch181
pushed a commit
to TobiasZeuch181/zypper_repository_add_list
that referenced
this pull request
Oct 2, 2024
ansible-collections#8764) * add module arg to make mapper removal optout * change parameter name to snake case: remove_unspecified_mappers * add period to parameter description Co-authored-by: Felix Fontein <felix@fontein.de> * use dict indexing to get parameter instead of `.get()` * add changelog fragment * Update changelogs/fragments/8764-keycloak_user_federation-make-mapper-removal-optout.yml Co-authored-by: Felix Fontein <felix@fontein.de> * add `version_added` to argument description Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/keycloak_user_federation.py Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de>
Massl123
pushed a commit
to Massl123/community.general
that referenced
this pull request
Feb 7, 2025
ansible-collections#8764) * add module arg to make mapper removal optout * change parameter name to snake case: remove_unspecified_mappers * add period to parameter description Co-authored-by: Felix Fontein <felix@fontein.de> * use dict indexing to get parameter instead of `.get()` * add changelog fragment * Update changelogs/fragments/8764-keycloak_user_federation-make-mapper-removal-optout.yml Co-authored-by: Felix Fontein <felix@fontein.de> * add `version_added` to argument description Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/keycloak_user_federation.py Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The
keycloak_user_federationmodule removes mappers that are not specified/listed in the module arguments. In order to keep the default mappers created by keycloak, they have to be specified in the module arguments. This could break something silently if keycloak changes the default mappers in the future and adds an mapper thats important.The argument
removeUnspecifiedMappersadded by the changes would allow users to disable or enable the removal of unspecified mappers, picking the desired behavior.The default is to enable the removal for now. But I'm not sure whether that's the right way and need some input.
ISSUE TYPE
COMPONENT NAME
keycloak_user_federation