keycloak_user_federation: sort desired and after mappers by name #8761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
WIP
ansibullbot
removed
needs_ci
felixfontein
added
check-before-release
|
Is this intentionally still a draft? |
felixfontein
reviewed
Sep 5, 2024
felixfontein
removed
the
check-before-release
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #8836 🤖 @patchback |
|
@fgruenbauer thanks for your contribution! |
patchback bot
pushed a commit
that referenced
this pull request
Sep 8, 2024
* sort desired mappers by name * sort mappers fetched after update by name * only sort mapper list if there are desired mappers specified * add fallback `''` in case `name` is not a key or `None` when sorting mappers * add changelog fragment (cherry picked from commit 982b8d8)
Backport to stable-9: 💚 backport PR created✅ Backport PR branch: Backported as #8837 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Sep 8, 2024
* sort desired mappers by name * sort mappers fetched after update by name * only sort mapper list if there are desired mappers specified * add fallback `''` in case `name` is not a key or `None` when sorting mappers * add changelog fragment (cherry picked from commit 982b8d8)
felixfontein
pushed a commit
that referenced
this pull request
Sep 8, 2024
… desired and after mappers by name (#8836) keycloak_user_federation: sort desired and after mappers by name (#8761) * sort desired mappers by name * sort mappers fetched after update by name * only sort mapper list if there are desired mappers specified * add fallback `''` in case `name` is not a key or `None` when sorting mappers * add changelog fragment (cherry picked from commit 982b8d8) Co-authored-by: fgruenbauer <gruenbauer@b1-systems.de>
felixfontein
pushed a commit
that referenced
this pull request
Sep 8, 2024
… desired and after mappers by name (#8837) keycloak_user_federation: sort desired and after mappers by name (#8761) * sort desired mappers by name * sort mappers fetched after update by name * only sort mapper list if there are desired mappers specified * add fallback `''` in case `name` is not a key or `None` when sorting mappers * add changelog fragment (cherry picked from commit 982b8d8) Co-authored-by: fgruenbauer <gruenbauer@b1-systems.de>
aioue
pushed a commit
to aioue/community.general
that referenced
this pull request
Oct 1, 2024
…ible-collections#8761) * sort desired mappers by name * sort mappers fetched after update by name * only sort mapper list if there are desired mappers specified * add fallback `''` in case `name` is not a key or `None` when sorting mappers * add changelog fragment
Massl123
pushed a commit
to Massl123/community.general
that referenced
this pull request
Feb 7, 2025
…ible-collections#8761) * sort desired mappers by name * sort mappers fetched after update by name * only sort mapper list if there are desired mappers specified * add fallback `''` in case `name` is not a key or `None` when sorting mappers * add changelog fragment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The module inconsistently sorts the mappers.
The module sorts the mappers fetched for the before state by name. The desired mappers and the mappers fetched after an update are not sorted. When comparing the desired mappers with the before mappers, changes are detected even if the mappers in both lists are the same except for the order. When diffing before with after mappers, differences are shown when the mappers are the same except for the order.
The changes add sorting by name for the desired mappers and the mappers fetched after an update, analog to the existing sorting for the before mappers. This minimizes the diff and makes the change detection more accurate.
ISSUE TYPE
COMPONENT NAME
keycloak_user_federation