Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

homebrew_cask: fix upgrade_all changed when nothing upgraded #8708

Merged
merged 4 commits into from
Aug 12, 2024
Merged

homebrew_cask: fix upgrade_all changed when nothing upgraded #8708

merged 4 commits into from
Aug 12, 2024

Conversation

johnbyrneio
Copy link
Contributor

SUMMARY

Fixes bug with homebrew_cask upgrade_all where the module always returns 'changed' due to change in output behavior of the brew command.

Fixes #8707

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

homebrew_cask

@ansibullbot
Copy link
Collaborator

cc @Akasurde @danieljaouen @enriclluelles @indrajitr @kyleabenson @martinm82
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type) labels Aug 2, 2024
@johnbyrneio johnbyrneio mentioned this pull request Aug 2, 2024
Closed
1 task
@johnbyrneio johnbyrneio mentioned this pull request Aug 2, 2024
Open
1 task
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-8 Automatically create a backport for the stable-8 branch backport-9 Automatically create a backport for the stable-9 branch labels Aug 5, 2024
felixfontein
felixfontein reviewed Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

changelogs/fragments/8708-homebrew_cask-fix-upgrade-all.yml Outdated Show resolved Hide resolved
plugins/modules/homebrew_cask.py Outdated Show resolved Hide resolved
@felixfontein
Copy link
Collaborator

@johnbyrneio can you take a look at my comments? It would be great to get this merged before the releases coming up on Monday. Thanks!

johnbyrneio and others added 2 commits August 9, 2024 13:13
@johnbyrneio @felixfontein
Update changelogs/fragments/8708-homebrew_cask-fix-upgrade-all.yml
1448f82 
Co-authored-by: Felix Fontein <felix@fontein.de>
@johnbyrneio @felixfontein
Add .strip() to upgrade output check
9da8eee 
Co-authored-by: Felix Fontein <felix@fontein.de>
@johnbyrneio
Copy link
Contributor Author

@felixfontein All set!

@felixfontein
Copy link
Collaborator

If nobody objects I'll merge this on Monday.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Aug 12, 2024
@felixfontein felixfontein merged commit 76d0222 into ansible-collections:main Aug 12, 2024
147 checks passed
@patchback Patchback
Copy link

patchback bot commented Aug 12, 2024 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/76d0222a83d7986e8fa6f693e87218cd0931f835/pr-8708

Backported as #8748

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 12, 2024
@johnbyrneio @patchback
homebrew_cask: fix upgrade_all changed when nothing upgraded (#8708)
9fd2ab1 
* homebrew_cask: fix upgrade_all changed when nothing upgraded

* Add changelog fragment

* Update changelogs/fragments/8708-homebrew_cask-fix-upgrade-all.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Add .strip() to upgrade output check

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: John Byrne <john@jobytech.net>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 76d0222)
@patchback patchback bot mentioned this pull request Aug 12, 2024
Merged
@patchback Patchback
Copy link

patchback bot commented Aug 12, 2024 •
edited
Loading

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/76d0222a83d7986e8fa6f693e87218cd0931f835/pr-8708

Backported as #8749

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@johnbyrneio thanks for your contribution!

patchback bot pushed a commit that referenced this pull request Aug 12, 2024
@johnbyrneio @patchback
homebrew_cask: fix upgrade_all changed when nothing upgraded (#8708)
388de8b 
* homebrew_cask: fix upgrade_all changed when nothing upgraded

* Add changelog fragment

* Update changelogs/fragments/8708-homebrew_cask-fix-upgrade-all.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Add .strip() to upgrade output check

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: John Byrne <john@jobytech.net>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 76d0222)
@patchback patchback bot mentioned this pull request Aug 12, 2024
Merged
felixfontein pushed a commit that referenced this pull request Aug 12, 2024
@patchback @johnbyrneio
[PR #8708/76d0222a backport][stable-8] homebrew_cask: fix upgrade_all…
d0fe612 
… changed when nothing upgraded (#8748)

homebrew_cask: fix upgrade_all changed when nothing upgraded (#8708)

* homebrew_cask: fix upgrade_all changed when nothing upgraded

* Add changelog fragment

* Update changelogs/fragments/8708-homebrew_cask-fix-upgrade-all.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Add .strip() to upgrade output check

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: John Byrne <john@jobytech.net>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 76d0222)

Co-authored-by: John Byrne <6145795+johnbyrneio@users.noreply.github.com>
felixfontein pushed a commit that referenced this pull request Aug 12, 2024
@patchback @johnbyrneio
[PR #8708/76d0222a backport][stable-9] homebrew_cask: fix upgrade_all…
5103c3c 
… changed when nothing upgraded (#8749)

homebrew_cask: fix upgrade_all changed when nothing upgraded (#8708)

* homebrew_cask: fix upgrade_all changed when nothing upgraded

* Add changelog fragment

* Update changelogs/fragments/8708-homebrew_cask-fix-upgrade-all.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Add .strip() to upgrade output check

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: John Byrne <john@jobytech.net>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 76d0222)

Co-authored-by: John Byrne <6145795+johnbyrneio@users.noreply.github.com>
aioue pushed a commit to aioue/community.general that referenced this pull request Oct 1, 2024
@johnbyrneio @felixfontein @aioue
homebrew_cask: fix upgrade_all changed when nothing upgraded (ansible…
3d7521c 
…-collections#8708)

* homebrew_cask: fix upgrade_all changed when nothing upgraded

* Add changelog fragment

* Update changelogs/fragments/8708-homebrew_cask-fix-upgrade-all.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Add .strip() to upgrade output check

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: John Byrne <john@jobytech.net>
Co-authored-by: Felix Fontein <felix@fontein.de>
TobiasZeuch181 pushed a commit to TobiasZeuch181/zypper_repository_add_list that referenced this pull request Oct 2, 2024
@johnbyrneio @felixfontein @TobiasZeuch181
homebrew_cask: fix upgrade_all changed when nothing upgraded (ansible…
896c9a4 
…-collections#8708)

* homebrew_cask: fix upgrade_all changed when nothing upgraded

* Add changelog fragment

* Update changelogs/fragments/8708-homebrew_cask-fix-upgrade-all.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Add .strip() to upgrade output check

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: John Byrne <john@jobytech.net>
Co-authored-by: Felix Fontein <felix@fontein.de>
Massl123 pushed a commit to Massl123/community.general that referenced this pull request Feb 7, 2025
@johnbyrneio @felixfontein @Massl123
homebrew_cask: fix upgrade_all changed when nothing upgraded (ansible…
065af2e 
…-collections#8708)

* homebrew_cask: fix upgrade_all changed when nothing upgraded

* Add changelog fragment

* Update changelogs/fragments/8708-homebrew_cask-fix-upgrade-all.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Add .strip() to upgrade output check

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: John Byrne <john@jobytech.net>
Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
backport-8 Automatically create a backport for the stable-8 branch backport-9 Automatically create a backport for the stable-9 branch bug This issue/PR relates to a bug has_issue module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

homebrew_cask upgrade_all always returns changed
3 participants
@johnbyrneio @ansibullbot @felixfontein