pkgng - add option use_globs (default=true) #8633

vbotka · 2024-07-14T17:18:09Z

SUMMARY

Implement feature request #8632

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

community.general.pkgng

ADDITIONAL INFORMATION

Add option

+    use_globs:
+        description:
+            - Treat the package names as shell glob patterns.
+        required: false
+        type: bool
+        default: true
+        version_added: 9.2.0

Remove all hard coded options -g, e.g.

-    rc, out, err = run_pkgng('info', '-g', '-e', name)
+    rc, out, err = run_pkgng('info', '-e', name)

Apply the option -g conditionally

     def run_pkgng(action, *args, **kwargs):
         cmd = [pkgng_path, dir_arg, action]

+        if p["use_globs"] and action in ('info', 'install', 'upgrade',):
+            args = ('-g',) + args

Add example. This allows the upgrade packages by pkg-origin (foo/bar). See https://man.freebsd.org/cgi/man.cgi?query=pkg-upgrade

+- name: Upgrade foo/bar
+  community.general.pkgng:
+    name: foo/bar
+    state: latest
+    use_globs: false

ansibullbot · 2024-07-14T17:19:25Z

cc @JoergFiedler @MacLemon @bcoca @dch @jasperla @mekanix @opoplawski @overhacked @tuxillo
click here for bot help

felixfontein

Thanks for your contribution!

changelogs/fragments/8632-pkgng-add-option-use_globs.yml

plugins/modules/pkgng.py

tests/integration/targets/pkgng/tasks/install_single_package.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

vbotka · 2024-07-21T20:26:56Z

Thanks for the review!

plugins/modules/pkgng.py

Co-authored-by: Felix Fontein <felix@fontein.de>

patchback · 2024-07-23T15:59:28Z

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/e3fb817a217a11827e72f1229fefefa73411480c/pr-8633

Backported as #8668

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

* pkgng - add option use_globs (default=true) #8632 * Fix lint. * Update changelogs/fragments/8632-pkgng-add-option-use_globs.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/pkgng.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/pkgng.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update tests/integration/targets/pkgng/tasks/install_single_package.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/pkgng.py Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit e3fb817)

felixfontein · 2024-07-23T15:59:53Z

@vbotka thanks for your contribution!

…default=true) (#8668) pkgng - add option use_globs (default=true) (#8633) * pkgng - add option use_globs (default=true) #8632 * Fix lint. * Update changelogs/fragments/8632-pkgng-add-option-use_globs.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/pkgng.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/pkgng.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update tests/integration/targets/pkgng/tasks/install_single_package.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/pkgng.py Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit e3fb817) Co-authored-by: Vladimir Botka <vbotka@gmail.com>

vbotka · 2024-07-24T12:52:46Z

@felixfontein thank you!

fixed group logic. Removed trailing spaces Type options of become plugins (ansible-collections#8623) Type options of become plugins. Type options of lookup plugins (ansible-collections#8626) Type options of lookup plugins. Type options of inventory plugins (ansible-collections#8625) Type options of inventory plugins. Type options of connection plugins (ansible-collections#8627) Type options of connection plugins. Type options of callback plugins (ansible-collections#8628) Type options of callback plugins. Various docs improvements (ansible-collections#8664) Various docs improvements. Fix new Proxmox Volume handling (ansible-collections#8646) * proxmox(fix): volume string builder Half of the string was incorrectly discarded * proxmox(fix): remove string conversion of values - Also converted `None` values into strings - Clashed with non-`str` values in documentation * proxmox: add changelog fragment * proxmox(fix): remove old & unused imports * proxmox(fix): correctly turn maps into lists * Update changelogs/fragments/8646-fix-bug-in-proxmox-volumes.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/proxmox.py Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> pkgng - add option use_globs (default=true) (ansible-collections#8633) * pkgng - add option use_globs (default=true) ansible-collections#8632 * Fix lint. * Update changelogs/fragments/8632-pkgng-add-option-use_globs.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/pkgng.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/pkgng.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update tests/integration/targets/pkgng/tasks/install_single_package.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/pkgng.py Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> Fix pipx tests (ansible-collections#8665) * fix pipx tests * enable pipx int tests * replace ansible-lint with pylint in pipx test * install jupyter in freebsd * replace jupyter with mkdocs in pipx test * adjust installed dependency for mkdocs * fix pipx_info tests as well Add TLS certs params to redis (ansible-collections#8654) * add tls params to redis * add PR number * add example * move doc to redis fragment * Update changelogs/fragments/8654-add-redis-tls-params.yml Co-authored-by: Felix Fontein <felix@fontein.de> * rm aliases and add version_added --------- Co-authored-by: Felix Fontein <felix@fontein.de> fixed pep8 errors changed group_access_level description as "not required"

fixed group logic. Removed trailing spaces Type options of become plugins (ansible-collections#8623) Type options of become plugins. Type options of lookup plugins (ansible-collections#8626) Type options of lookup plugins. Type options of inventory plugins (ansible-collections#8625) Type options of inventory plugins. Type options of connection plugins (ansible-collections#8627) Type options of connection plugins. Type options of callback plugins (ansible-collections#8628) Type options of callback plugins. Various docs improvements (ansible-collections#8664) Various docs improvements. Fix new Proxmox Volume handling (ansible-collections#8646) * proxmox(fix): volume string builder Half of the string was incorrectly discarded * proxmox(fix): remove string conversion of values - Also converted `None` values into strings - Clashed with non-`str` values in documentation * proxmox: add changelog fragment * proxmox(fix): remove old & unused imports * proxmox(fix): correctly turn maps into lists * Update changelogs/fragments/8646-fix-bug-in-proxmox-volumes.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/proxmox.py Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> pkgng - add option use_globs (default=true) (ansible-collections#8633) * pkgng - add option use_globs (default=true) ansible-collections#8632 * Fix lint. * Update changelogs/fragments/8632-pkgng-add-option-use_globs.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/pkgng.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/pkgng.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update tests/integration/targets/pkgng/tasks/install_single_package.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/pkgng.py Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> Fix pipx tests (ansible-collections#8665) * fix pipx tests * enable pipx int tests * replace ansible-lint with pylint in pipx test * install jupyter in freebsd * replace jupyter with mkdocs in pipx test * adjust installed dependency for mkdocs * fix pipx_info tests as well Add TLS certs params to redis (ansible-collections#8654) * add tls params to redis * add PR number * add example * move doc to redis fragment * Update changelogs/fragments/8654-add-redis-tls-params.yml Co-authored-by: Felix Fontein <felix@fontein.de> * rm aliases and add version_added --------- Co-authored-by: Felix Fontein <felix@fontein.de> fixed pep8 errors changed group_access_level description as "not required" fix required

fixed group logic. Removed trailing spaces Type options of become plugins (ansible-collections#8623) Type options of become plugins. Type options of lookup plugins (ansible-collections#8626) Type options of lookup plugins. Type options of inventory plugins (ansible-collections#8625) Type options of inventory plugins. Type options of connection plugins (ansible-collections#8627) Type options of connection plugins. Type options of callback plugins (ansible-collections#8628) Type options of callback plugins. Various docs improvements (ansible-collections#8664) Various docs improvements. Fix new Proxmox Volume handling (ansible-collections#8646) * proxmox(fix): volume string builder Half of the string was incorrectly discarded * proxmox(fix): remove string conversion of values - Also converted `None` values into strings - Clashed with non-`str` values in documentation * proxmox: add changelog fragment * proxmox(fix): remove old & unused imports * proxmox(fix): correctly turn maps into lists * Update changelogs/fragments/8646-fix-bug-in-proxmox-volumes.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/proxmox.py Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> pkgng - add option use_globs (default=true) (ansible-collections#8633) * pkgng - add option use_globs (default=true) ansible-collections#8632 * Fix lint. * Update changelogs/fragments/8632-pkgng-add-option-use_globs.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/pkgng.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/pkgng.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update tests/integration/targets/pkgng/tasks/install_single_package.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/pkgng.py Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> Fix pipx tests (ansible-collections#8665) * fix pipx tests * enable pipx int tests * replace ansible-lint with pylint in pipx test * install jupyter in freebsd * replace jupyter with mkdocs in pipx test * adjust installed dependency for mkdocs * fix pipx_info tests as well Add TLS certs params to redis (ansible-collections#8654) * add tls params to redis * add PR number * add example * move doc to redis fragment * Update changelogs/fragments/8654-add-redis-tls-params.yml Co-authored-by: Felix Fontein <felix@fontein.de> * rm aliases and add version_added --------- Co-authored-by: Felix Fontein <felix@fontein.de> fixed pep8 errors changed group_access_level description as "not required" fix required fix

* pkgng - add option use_globs (default=true) ansible-collections#8632 * Fix lint. * Update changelogs/fragments/8632-pkgng-add-option-use_globs.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/pkgng.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/pkgng.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update tests/integration/targets/pkgng/tasks/install_single_package.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/pkgng.py Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de>

pkgng - add option use_globs (default=true) ansible-collections#8632

ac8470b

ansibullbot added feature This issue/PR relates to a feature request integration tests/integration module module plugins plugin (any type) tests tests labels Jul 14, 2024

Fix lint.

6142557

felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-9 Automatically create a backport for the stable-9 branch labels Jul 14, 2024

felixfontein reviewed Jul 21, 2024

View reviewed changes

vbotka and others added 4 commits July 21, 2024 22:23

Update changelogs/fragments/8632-pkgng-add-option-use_globs.yml

cdf99ed

Co-authored-by: Felix Fontein <felix@fontein.de>

Update plugins/modules/pkgng.py

3a4d72c

Co-authored-by: Felix Fontein <felix@fontein.de>

Update plugins/modules/pkgng.py

373d369

Co-authored-by: Felix Fontein <felix@fontein.de>

Update tests/integration/targets/pkgng/tasks/install_single_package.yml

afcd11f

Co-authored-by: Felix Fontein <felix@fontein.de>

felixfontein reviewed Jul 21, 2024

View reviewed changes

plugins/modules/pkgng.py Outdated Show resolved Hide resolved

Update plugins/modules/pkgng.py

79ac638

Co-authored-by: Felix Fontein <felix@fontein.de>

felixfontein approved these changes Jul 23, 2024

View reviewed changes

felixfontein merged commit e3fb817 into ansible-collections:main Jul 23, 2024
147 checks passed

felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jul 23, 2024

patchback bot mentioned this pull request Jul 23, 2024

[PR #8633/e3fb817a backport][stable-9] pkgng - add option use_globs (default=true) #8668

Merged

vbotka deleted the feature-pkgng-option-use_globs branch July 24, 2024 12:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pkgng - add option use_globs (default=true) #8633

pkgng - add option use_globs (default=true) #8633

vbotka commented Jul 14, 2024 •

edited

Loading

ansibullbot commented Jul 14, 2024

felixfontein left a comment

vbotka commented Jul 21, 2024

patchback bot commented Jul 23, 2024 •

edited

Loading

felixfontein commented Jul 23, 2024

vbotka commented Jul 24, 2024

pkgng - add option use_globs (default=true) #8633

pkgng - add option use_globs (default=true) #8633

Conversation

vbotka commented Jul 14, 2024 • edited Loading

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

ansibullbot commented Jul 14, 2024

felixfontein left a comment

Choose a reason for hiding this comment

vbotka commented Jul 21, 2024

patchback bot commented Jul 23, 2024 • edited Loading

Backport to stable-9: 💚 backport PR created

felixfontein commented Jul 23, 2024

vbotka commented Jul 24, 2024

vbotka commented Jul 14, 2024 •

edited

Loading

patchback bot commented Jul 23, 2024 •

edited

Loading