feat(redis_info): add option to fetch cluster info #8464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
feature
tyxieblub
force-pushed
the
redis-cluster-info
branch
from
3e923a8 to
d91f7ab
Compare
felixfontein
added
check-before-release
felixfontein
reviewed
Jun 8, 2024
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
|
Thanks for the review, I applied everything! |
levonet
approved these changes
Jun 10, 2024
felixfontein
removed
the
check-before-release
Backport to stable-9: 💚 backport PR created✅ Backport PR branch: Backported as #8493 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jun 12, 2024
* feat(redis_info): add option to fetch cluster info * add changelog fragment * update description Co-authored-by: Felix Fontein <felix@fontein.de> * Apply suggestions from code review Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 800bc01)
|
@tyxieblub thanks for your contribution! |
felixfontein
pushed a commit
that referenced
this pull request
Jun 13, 2024
…o fetch cluster info (#8493) feat(redis_info): add option to fetch cluster info (#8464) * feat(redis_info): add option to fetch cluster info * add changelog fragment * update description Co-authored-by: Felix Fontein <felix@fontein.de> * Apply suggestions from code review Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 800bc01) Co-authored-by: joris <5111464+tyxieblub@users.noreply.github.com>
Massl123
pushed a commit
to Massl123/community.general
that referenced
this pull request
Feb 7, 2025
…ns#8464) * feat(redis_info): add option to fetch cluster info * add changelog fragment * update description Co-authored-by: Felix Fontein <felix@fontein.de> * Apply suggestions from code review Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds support for getting cluster information. It does not use, redis-py's cluster_info() because I couldn't get it to work when the cluster is yet to be configured. Hence the
execute_commandwhich works in that case.It's optional and can be invoked with adding
cluster: trueto the task:And returns the additionnal data in the
cluster_infovariable alongsideinfo.ISSUE TYPE
COMPONENT NAME