Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added usb support to proxmox module #8199

Merged
merged 8 commits into from
May 20, 2024
Merged

added usb support to proxmox module #8199

merged 8 commits into from
May 20, 2024

Conversation

rippleFCL
Copy link
Contributor

SUMMARY

added usb support when managing proxmox kvm vms

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

proxmox_kvm

@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot
Copy link
Collaborator

cc @Ajpantuso @Thulium-Drake @UnderGreen @helldorado @joshainglis @karmab @krauthosting
click here for bot help

@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI feature This issue/PR relates to a feature request module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type) labels Apr 8, 2024
@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Apr 8, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-8 Automatically create a backport for the stable-8 branch labels Apr 9, 2024
felixfontein
felixfontein reviewed Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I've added some first comments.

plugins/modules/proxmox_kvm.py Outdated Show resolved Hide resolved
plugins/modules/proxmox_kvm.py Outdated Show resolved Hide resolved
felixfontein
felixfontein reviewed Apr 14, 2024
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a changelog fragment.

plugins/modules/proxmox_kvm.py Show resolved Hide resolved
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Apr 22, 2024
@felixfontein felixfontein removed the backport-8 Automatically create a backport for the stable-8 branch label Apr 23, 2024
@rippleFCL @felixfontein
added changelog fragment
8e9bf03 
Co-authored-by: Felix Fontein <felix@fontein.de>
@rippleFCL
Copy link
Contributor Author

completely forgot about this, apologies

@ansibullbot ansibullbot removed the stale_ci CI is older than 7 days, rerun before merging label May 3, 2024
@felixfontein
Copy link
Collaborator

Please note that the commit you added adds a version_added directive, not a changelog fragment. A changelog fragment is a separate file in changelogs/fragments/. See the link above :)

@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label May 11, 2024
@ansibullbot ansibullbot removed the stale_ci CI is older than 7 days, rerun before merging label May 18, 2024
@rippleFCL @felixfontein
corrected spelling and punctuation
766ffa1 
Co-authored-by: Felix Fontein <felix@fontein.de>
@felixfontein felixfontein merged commit 861f55e into ansible-collections:main May 20, 2024
132 checks passed
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label May 20, 2024
@felixfontein
Copy link
Collaborator

@rippleFCL thanks for your contribution!

austinlucaslake pushed a commit to austinlucaslake/community.general that referenced this pull request May 25, 2024
@rippleFCL @felixfontein @austinlucaslake
added usb support to proxmox module (ansible-collections#8199)
fc35e85 
* added usb support to proxmox module

* forgot docs

* fixed net refrances

* changed usb to USB

* added changelog fragment

Co-authored-by: Felix Fontein <felix@fontein.de>

* added changelog fragment

* corrected spelling and punctuation

Co-authored-by: Felix Fontein <felix@fontein.de>

* Another one.

---------

Co-authored-by: ripplefcl <ripple@ripplefcl.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
@rippleFCL rippleFCL deleted the feat/prox-usb branch May 30, 2024 12:48
Massl123 pushed a commit to Massl123/community.general that referenced this pull request Feb 7, 2025
@rippleFCL @felixfontein @Massl123
added usb support to proxmox module (ansible-collections#8199)
736c66d 
* added usb support to proxmox module

* forgot docs

* fixed net refrances

* changed usb to USB

* added changelog fragment

Co-authored-by: Felix Fontein <felix@fontein.de>

* added changelog fragment

* corrected spelling and punctuation

Co-authored-by: Felix Fontein <felix@fontein.de>

* Another one.

---------

Co-authored-by: ripplefcl <ripple@ripplefcl.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rippleFCL @ansibullbot @felixfontein