Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new consul modules and reuse code between them. #7878

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Add new consul modules and reuse code between them. #7878

merged 1 commit into from
Jan 27, 2024

Conversation

apollo13
Copy link
Contributor

No description provided.

@ansibullbot
Copy link
Collaborator

cc @sgargan
click here for bot help

@ansibullbot ansibullbot added WIP Work in progress integration tests/integration module module module_utils module_utils plugins plugin (any type) tests tests docs_fragments docs_fragments plugin (shared docs) labels Jan 21, 2024
@ansibullbot

This comment was marked as outdated.

Sign in to view
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-8 Automatically create a backport for the stable-8 branch labels Jan 21, 2024
felixfontein
felixfontein reviewed Jan 21, 2024
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some first comments :)

@apollo13 apollo13 force-pushed the consul_new_roles branch 2 times, most recently from 8a1b628 to e13532c Compare January 25, 2024 14:33
@apollo13 apollo13 marked this pull request as ready for review January 25, 2024 15:04
@apollo13
Copy link
Contributor Author

I think the 3rd party tests are failing due to:

filter community.general.time missing documentation (or could not parse documentation): No documentation available for community.general.time (/tmp/tmprzds3cf4/ansible_collections/community/general/plugins/filter/time.py)\

which I didn't touch.

@ansibullbot ansibullbot removed the WIP Work in progress label Jan 25, 2024
@felixfontein
Copy link
Collaborator

The Zuul test is always failing, you can ignore it. I'm currently trying to get completely rid of it, since it's very slow and fails relatively often (and for some time now constantly fails).

@felixfontein
Copy link
Collaborator

Can you modify changelogs/fragments/7826-consul-modules-refactoring.yaml by adding this PR to the brackets at the end (in format ... (url1, url2).)?

felixfontein
felixfontein reviewed Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For new features (check/diff mode support, new options) and option renames you need a changelog fragment (minor_changes).

@apollo13
Copy link
Contributor Author

For new features (check/diff mode support, new options) and option renames you need a changelog fragment (minor_changes).

Can I roll that into the existing fragment, or does it need a new one?

@apollo13 apollo13 mentioned this pull request Jan 26, 2024
Merged
felixfontein
felixfontein reviewed Jan 26, 2024
View reviewed changes
@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Jan 27, 2024
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jan 27, 2024
@felixfontein felixfontein merged commit 29f9865 into ansible-collections:main Jan 27, 2024
120 of 121 checks passed
@patchback Patchback
Copy link

patchback bot commented Jan 27, 2024 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/29f98654978590a69d3042d0f1bbb20271369b55/pr-7878

Backported as #7902

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 27, 2024
@apollo13 @patchback
Add new consul modules and reuse code between them. (#7878)
e79a33c 
Refactored consul modules and added new roles.

(cherry picked from commit 29f9865)
@felixfontein
Copy link
Collaborator

@apollo13 thanks a lot for your contributions!

@patchback patchback bot mentioned this pull request Jan 27, 2024
Merged
felixfontein pushed a commit that referenced this pull request Jan 27, 2024
@patchback @apollo13
[PR #7878/29f98654 backport][stable-8] Add new consul modules and reu…
0a904d6 
…se code between them. (#7902)

Add new consul modules and reuse code between them. (#7878)

Refactored consul modules and added new roles.

(cherry picked from commit 29f9865)

Co-authored-by: Florian Apolloner <florian@apolloner.eu>
@patchback patchback bot mentioned this pull request Jan 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
backport-8 Automatically create a backport for the stable-8 branch docs_fragments docs_fragments plugin (shared docs) integration tests/integration module_utils module_utils module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apollo13 @ansibullbot @felixfontein