Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proxmox_kvm - state:template will check if template exists first (#7791) #7792

Merged
merged 3 commits into from
Jan 1, 2024
Merged

proxmox_kvm - state:template will check if template exists first (#7791) #7792

merged 3 commits into from
Jan 1, 2024

Conversation

aaronjohnleonard
Copy link
Contributor

@aaronjohnleonard aaronjohnleonard commented Dec 29, 2023 •
edited by felixfontein
Loading

SUMMARY

Fixes #7791.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

proxmox_kvm

@ansibullbot
Copy link
Collaborator

cc @Ajpantuso @Thulium-Drake @UnderGreen @helldorado @joshainglis @karmab
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Dec 29, 2023
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-8 Automatically create a backport for the stable-8 branch labels Dec 29, 2023
@felixfontein
Copy link
Collaborator

Thanks for your contribution! Please add a changelog fragment. Thanks.

@aaronjohnleonard
Copy link
Contributor Author

Added changelog entry. Thanks for the reminder!

@ansibullbot ansibullbot removed the small_patch Hopefully easy to review label Dec 30, 2023
@felixfontein felixfontein merged commit 0bfebde into ansible-collections:main Jan 1, 2024
@patchback Patchback
Copy link

patchback bot commented Jan 1, 2024 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/0bfebde5c942ed0fbba42e3db7e94cbef8393d9b/pr-7792

Backported as #7806

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 1, 2024
@aaronjohnleonard @patchback
proxmox_kvm - state:template will check if template exists first (#7791…
8bfd4e9 
…) (#7792)

* proxmox_kvm - state:template will check if template exists first (#7791)

* added changelog entry

* Update changelog fragment.

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 0bfebde)
@patchback patchback bot mentioned this pull request Jan 1, 2024
Merged
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jan 1, 2024
@felixfontein
Copy link
Collaborator

@aaronjohnleonard thanks for your contribution!

felixfontein pushed a commit that referenced this pull request Jan 1, 2024
@patchback @aaronjohnleonard
[PR #7792/0bfebde5 backport][stable-8] proxmox_kvm - state:template w…
a045d08 
…ill check if template exists first (#7791) (#7806)

proxmox_kvm - state:template will check if template exists first (#7791) (#7792)

* proxmox_kvm - state:template will check if template exists first (#7791)

* added changelog entry

* Update changelog fragment.

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 0bfebde)

Co-authored-by: aaronjohnleonard <aaronjohnleonard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
backport-8 Automatically create a backport for the stable-8 branch bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proxmox_kvm - setting state:template is not idempotent
3 participants
@aaronjohnleonard @ansibullbot @felixfontein