[proxmox_vm_info] Return empty list when requested VM doesn't exist #7049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
feature
1 task
felixfontein
added
check-before-release
felixfontein
reviewed
Aug 2, 2023
|
@felixfontein can you please re-review the PR? |
felixfontein
reviewed
Aug 7, 2023
felixfontein
reviewed
Aug 8, 2023
Co-authored-by: Felix Fontein <felix@fontein.de>
|
Yes. Hope it will be the last iteration for that module. |
felixfontein
removed
the
check-before-release
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #7079 🤖 @patchback |
|
@UnderGreen thanks for your contribution! |
patchback bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
…7049) * [proxmox_vm_info] Return empty list when requested VM doesn't exist * Update documentation * Add changelog fragment * Address review comments * Allow to filter by empty name * Update plugins/modules/proxmox_vm_info.py Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 2089769)
felixfontein
pushed a commit
that referenced
this pull request
Aug 9, 2023
… list when requested VM doesn't exist (#7079) [proxmox_vm_info] Return empty list when requested VM doesn't exist (#7049) * [proxmox_vm_info] Return empty list when requested VM doesn't exist * Update documentation * Add changelog fragment * Address review comments * Allow to filter by empty name * Update plugins/modules/proxmox_vm_info.py Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 2089769) Co-authored-by: Sergei Antipov <greendayonfire@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Instead of failing when VM with provided name/vmid doesn't exist the module should have empty response. Than allows the workflows with checking VM existence.
ISSUE TYPE
COMPONENT NAME
proxmox_vm_info
ADDITIONAL INFORMATION