filesystem: add UUID change feature #6680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
WIP
felixfontein
added
check-before-release
FreeBSD error: xfs_admin: only 'rewrite' supported on V5 fs
Co-authored-by: Felix Fontein <felix@fontein.de>
|
@felixfontein Thank you for your guidance and fixes! |
ansibullbot
added
the
needs_revision
ansibullbot
added
needs_ci
ansibullbot
removed
the
needs_revision
|
Beside these I think this is safe to merge for 7.1.0. |
Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein
approved these changes
Jun 19, 2023
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #6731 🤖 @patchback |
felixfontein
removed
the
check-before-release
patchback bot
pushed a commit
that referenced
this pull request
Jun 19, 2023
* filesystem: add UUID change feature * Add changelog fragment for 6680 * Do not test XFS filesystem UUID reset on FreeBSD FreeBSD error: xfs_admin: only 'rewrite' supported on V5 fs * Apply suggestions from code review #1 Co-authored-by: Felix Fontein <felix@fontein.de> * Set filesystem UUID on FS creation * Fix tests - switch to ansible.builtion.to_uuid * Fix tests - Refactor to avoid FS remove tasks * Fail if uuid option not yet supported for fstype * Set resizefs and uuid options mutually exclusive * Apply suggestions from code review no 2. Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 5d9eb8b)
|
@lszomor thanks for your contribution! |
felixfontein
pushed a commit
that referenced
this pull request
Jun 19, 2023
…ature (#6731) filesystem: add UUID change feature (#6680) * filesystem: add UUID change feature * Add changelog fragment for 6680 * Do not test XFS filesystem UUID reset on FreeBSD FreeBSD error: xfs_admin: only 'rewrite' supported on V5 fs * Apply suggestions from code review #1 Co-authored-by: Felix Fontein <felix@fontein.de> * Set filesystem UUID on FS creation * Fix tests - switch to ansible.builtion.to_uuid * Fix tests - Refactor to avoid FS remove tasks * Fail if uuid option not yet supported for fstype * Set resizefs and uuid options mutually exclusive * Apply suggestions from code review no 2. Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 5d9eb8b) Co-authored-by: Laszlo Szomor <laszomor@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add a new feature to the filesystem module for managing UUID.
The feature does not break backward compatibility. It introduces an optional
uuidparameter.Rationale:
During disk cloning / lvm snapshot creation, the filesystem uuid remains the same. This new feature manages the filesystem UUID in an automated fashion.
ISSUE TYPE
COMPONENT NAME
filesystem
ADDITIONAL INFORMATION
The
version_addedentry in theuuidparameter's documentation needs to be set.