rhsm_release: improve the execution of subscription-manager #6669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cnsnyder @seandst |
ansibullbot
added
module
felixfontein
added
check-before-release
- pass the arguments to run_command() directly as list, rather than joining the arguments to string, which run_command() will need to split again - disable the expansions of variables, as there are none Adapt the unit test to the different way run_command() is called, factorizing the kwargs for run_command() so there is less repetition. There should be no behaviour changes.
ptoscano
force-pushed
the
rhsm_release-improve-subman
branch
from
4e474aa to
8b1fad9
Compare
felixfontein
approved these changes
Jun 11, 2023
felixfontein
removed
the
check-before-release
|
@ptoscano thanks! |
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #6674 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jun 11, 2023
- pass the arguments to run_command() directly as list, rather than joining the arguments to string, which run_command() will need to split again - disable the expansions of variables, as there are none Adapt the unit test to the different way run_command() is called, factorizing the kwargs for run_command() so there is less repetition. There should be no behaviour changes. (cherry picked from commit 74ffb29)
felixfontein
pushed a commit
that referenced
this pull request
Jun 11, 2023
…ution of subscription-manager (#6674) rhsm_release: improve the execution of subscription-manager (#6669) - pass the arguments to run_command() directly as list, rather than joining the arguments to string, which run_command() will need to split again - disable the expansions of variables, as there are none Adapt the unit test to the different way run_command() is called, factorizing the kwargs for run_command() so there is less repetition. There should be no behaviour changes. (cherry picked from commit 74ffb29) Co-authored-by: Pino Toscano <ptoscano@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
run_command()directly as list, rather than joining the arguments to string, whichrun_command()will need to split againAdapt the unit test to the different way
run_command()is called, factorizing the kwargs forrun_command()so there is less repetition.There should be no behaviour changes.
ISSUE TYPE
COMPONENT NAME
rhsm_release