Skip to content

ansible-core 2.20: avoid deprecated functionality #10687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

ansible.module_utils._text and ansible.module_utils.common._collections_compat have been deprecated.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

various

@felixfontein felixfontein added backport-10 Automatically create a backport for the stable-10 branch backport-11 Automatically create a backport for the stable-10 branch labels Aug 17, 2025
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added become become plugin bug This issue/PR relates to a bug cache cache plugin callback callback plugin connection connection plugin filter filter plugin inventory inventory plugin lookup lookup plugin module module module_utils module_utils plugins plugin (any type) tests tests unit tests/unit labels Aug 17, 2025
@felixfontein felixfontein requested a review from russoz August 17, 2025 18:15
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein merged commit 47e8a3c into ansible-collections:main Aug 18, 2025
134 checks passed
Copy link

patchback bot commented Aug 18, 2025

Backport to stable-10: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 47e8a3c on top of patchback/backports/stable-10/47e8a3c193e04725568449ef9878ae2c0bdb8adc/pr-10687

Backporting merged PR #10687 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/ansible-collections/community.general.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/stable-10/47e8a3c193e04725568449ef9878ae2c0bdb8adc/pr-10687 upstream/stable-10
  4. Now, cherry-pick PR ansible-core 2.20: avoid deprecated functionality #10687 contents into that branch:
    $ git cherry-pick -x 47e8a3c193e04725568449ef9878ae2c0bdb8adc
    If it'll yell at you with something like fatal: Commit 47e8a3c193e04725568449ef9878ae2c0bdb8adc is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 47e8a3c193e04725568449ef9878ae2c0bdb8adc
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR ansible-core 2.20: avoid deprecated functionality #10687 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/stable-10/47e8a3c193e04725568449ef9878ae2c0bdb8adc/pr-10687
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein deleted the deprecation branch August 18, 2025 04:25
Copy link

patchback bot commented Aug 18, 2025

Backport to stable-11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-11/47e8a3c193e04725568449ef9878ae2c0bdb8adc/pr-10687

Backported as #10693

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator Author

@sscheib @russoz thanks for reviewing!

patchback bot pushed a commit that referenced this pull request Aug 18, 2025
Avoid deprecated functionality.

(cherry picked from commit 47e8a3c)
felixfontein added a commit to felixfontein/community.general that referenced this pull request Aug 18, 2025
…s#10687)

Avoid deprecated functionality.

(cherry picked from commit 47e8a3c)
felixfontein added a commit that referenced this pull request Aug 18, 2025
…recated functionality (#10693)

ansible-core 2.20: avoid deprecated functionality (#10687)

Avoid deprecated functionality.

(cherry picked from commit 47e8a3c)

Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein added a commit that referenced this pull request Aug 18, 2025
#10694)

ansible-core 2.20: avoid deprecated functionality (#10687)

Avoid deprecated functionality.

(cherry picked from commit 47e8a3c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-10 Automatically create a backport for the stable-10 branch backport-11 Automatically create a backport for the stable-10 branch become become plugin bug This issue/PR relates to a bug cache cache plugin callback callback plugin connection connection plugin filter filter plugin inventory inventory plugin lookup lookup plugin module_utils module_utils module module plugins plugin (any type) tests tests unit tests/unit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants