[PR #10669/13bd4b5d backport][stable-11] composer: fix command args as list rather than string #10680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
(cherry picked from commit 13bd4b5)
ansibullbot
added
backport
bug
felixfontein
deleted the
patchback/backports/stable-11/13bd4b5d82edc00a6abc3810ed64c1487a1b0372/pr-10669
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #10669 as merged into main (13bd4b5).
SUMMARY
The changes introduced in #10525 were incomplete and required more adjustments. This PR makes those adjustments, adds one single unit test that is clearly shallow - it does not included actual output from the commands, only mock ups, but it helps, at least, to assert that the command lines are generated correctly.
Additionally a small adjustment to uthelper is introduced to allow the
environfield of the command mock-up to be optional.Fixes #10662
ISSUE TYPE
COMPONENT NAME
composer