GitHub app access token lookup: allow to use PyJWT + cryptography instead of jwt #10664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
ci_verified
ansibullbot
removed
ci_verified
felixfontein
added
breaking_change
felixfontein
added
backport-11
felixfontein
changed the title
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
|
If I may suggest, give it a try to https://pypi.org/project/andebox/ You can run this sanity test easily in your local machine by simply running: |
|
Though I suspect I am coming too late with that information :) |
I have a way to run it via |
felixfontein
approved these changes
Aug 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Change community.general.github_app_access_token lookup to use PyJWT (https://pypi.org/project/PyJWT/) rather than jwt (https://github.com/GehirnInc/python-jwt).
Fixes #10299
this is a continuation of #10332
ISSUE TYPE
COMPONENT NAME
github_app_access_token
ADDITIONAL INFORMATION
Change the implementation to use pyjwt, rather than jwt that causes conflits elsewhere in the Ansible ecosystem.
thank you @blavoie for the intial commit and fixes. This pr would include both the compatibility issue and (hopefully) the required test cases
Im not too sure about how deprecation warning are usually shown in this collection, I've make used of
display.deprecatedfunction with a magic version number, any direction on this would be appreciated