Add a scaleway group to be able to use module_defaults #10647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscherer
force-pushed
the
add_group_scaleway
branch
from
15e7bc4 to
7db1217
Compare
mscherer
force-pushed
the
add_group_scaleway
branch
2 times, most recently
from
f1e8146 to
08dc0a9
Compare
ansibullbot
added
docs_fragments
mscherer
force-pushed
the
add_group_scaleway
branch
from
08dc0a9 to
f293e59
Compare
|
cc @DenBeke @Lunik @Spredzy @abarbare @guillaume_ro_fr @pastral @remyleone |
felixfontein
added
check-before-release
| @@ -22,6 +22,7 @@ | |||
| extends_documentation_fragment: | |||
| - community.general.scaleway | |||
| - community.general.attributes | |||
| - community.general.scaleway.actiongroup_scaleway | |||
|
|
|||
| attributes: | |||
| check_mode: | |||
There was a problem hiding this comment.
Can you add action_group: / version_added: 11.2.0 (resp. 11.3.0) in all these modules?
There was a problem hiding this comment.
I think that's done. But after trying to find a smart sed invocation, i did it manually, so better double check.
|
LGTMbut for the comments by @felixfontein |
mscherer
force-pushed
the
add_group_scaleway
branch
from
f293e59 to
1bec7f5
Compare
ansibullbot
added
the
needs_revision
mscherer
force-pushed
the
add_group_scaleway
branch
from
1bec7f5 to
5470815
Compare
mscherer
force-pushed
the
add_group_scaleway
branch
from
5470815 to
05b3578
Compare
ansibullbot
removed
the
needs_revision
felixfontein
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add a scaleway group to be able to use module_defaults
Since all modules requires the use of a api_key and various others repeated arguments, being able to use module_defaults allow to write cleaner roles.
ISSUE TYPE
COMPONENT NAME
all scaleway