-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Reject empty string as value in cronvar #10445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Restarting CI. |
Hmm I guess this needs another commit, or a rebase, to get rid of the CI failures, since the CI matrix changed. I was hoping that closing + reopening updates the matrix, but apparently it does not 🤷 |
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Thank for the immediate feedback! I rebased the branch so now the CI matrix succeeds. |
There could be cases where the user wants to remove the existing content of the var, replacing it with |
The module currently writes this line into the crontab:
So while the syntax To support this use case safely across platforms, I could also modify the module to render: instead of |
SUMMARY
Reject empty string values for value in the cronvar module to prevent misleading success reports in some OSes.
I also added the necessary integration test.
Fixes #10439
ISSUE TYPE
COMPONENT NAME
cronvar