apt_rpm not upgrade packages if a newer version exists

[x09]

Summary

If exist new version of package, module has been report - "Nothing to install"
Bug description (on Russian) - https://bugzilla.altlinux.org/48091

Issue Type

Bug Report

Component Name

community.general.apt_rpm

Ansible Version

ansible 2.9.27
  config file = /etc/ansible/ansible.cfg
  configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python3/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 3.9.16 (main, Mar 21 2023, 10:12:38) [GCC 10.3.1 20210703 (ALT Sisyphus 10.3.1-alt2)]

Community.general Version

ansible-galaxy --version
ansible-galaxy 2.9.27
  config file = /etc/ansible/ansible.cfg
  configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python3/site-packages/ansible
  executable location = /usr/bin/ansible-galaxy
  python version = 3.9.16 (main, Mar 21 2023, 10:12:38) [GCC 10.3.1 20210703 (ALT Sisyphus 10.3.1-alt2)]


$ ansible-galaxy collection list community.general
usage: ansible-galaxy collection [-h] COLLECTION_ACTION ...
ansible-galaxy collection: error: argument COLLECTION_ACTION: invalid choice: 'list' (choose from 'init', 'build', 'publish', 'install')

Configuration

$ ansible-config dump --only-changed
-- nothing --

OS / Environment

OS Alt Server 10.1

Steps to Reproduce

0. fakepkg 1.0 and fakepkg 2.0 in repo.

1. Install fakepkg 1.0 manually -
   rpm -i /path/to/fakepkg-1.0.rpm (or apt-get install fakepkg=1.0)

2. Create simple playbook

cat /tmp/apt_rpm.yml

- name: Playbook
  connection: local
  gather_facts: false
  hosts: localhost
  tasks:

  - name: Ensure fakepkg rpm present
    apt_rpm:
      pkg: fakepkg
      update_cache: true
      state: present

3. apply

Using /etc/ansible/ansible.cfg as config file
[WARNING]: provided hosts list is empty, only localhost is available. Note that the implicit localhost does not match 'all'

PLAY [Playbook] ***********************************

TASK [Ensure fakepkg rpm present] *****************************************
ok: [localhost] => {"changed": false, "msg": "Nothing to install"}

PLAY RECAP ************************************
localhost                  : ok=1    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0   

Expected Results

fakepkg update from 1.0 to 2.0 version

Actual Results

rpm -q fakepkg
fakepkg-1.0-alt1.x86_64

Code of Conduct

• I agree to follow the Ansible Code of Conduct

[ansibullbot]

Files identified in the description:

• plugins/modules/apt_rpm.py

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibullbot]

cc @evgkrsk
click here for bot help

[felixfontein]

The documentation contains an example that states that this should work:

# bar will be the updated if a newer version exists
- name: Update the package database and install bar
  community.general.apt_rpm:
    name: bar
    state: present
    update_cache: true

(Just wanted to make sure that the documentation really mentions that this should work - I wouldn't expect that the package is upgraded if update_cache=true from just looking at the task.)

[x09]

Wrong creating string "packages" from "package" array

[root@host-c10f1 ~]# diff -u /usr/lib/python3/site-packages/ansible/modules/packaging/os/apt_rpm.py /root/apt_rpm.py 
--- /usr/lib/python3/site-packages/ansible/modules/packaging/os/apt_rpm.py      2023-03-03 12:26:05.000000000 +0500
+++ /root/apt_rpm.py    2023-10-23 12:47:54.503459007 +0500
@@ -189,8 +189,8 @@
 
     packages = ""
     for package in pkgspec:
-        if not query_package_provides(module, package):
-            packages += "'%s' " % package
+        #if not query_package_provides(module, package):
+        packages += "'%s' " % package
 
     if len(packages) != 0: