pacman: do not fail if there is nothing to do (#8514)

Do not fail if there is nothing to do. (cherry picked from commit df7fe19)
ansible-collections · Jun 17, 2024 · 6941838 · 6941838
1 parent e9f0e49
commit 6941838
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/changelogs/fragments/8514-pacman-empty.yml b/changelogs/fragments/8514-pacman-empty.yml
@@ -0,0 +1,2 @@
+bugfixes:
+  - "paman - do not fail if an empty list of packages has been provided and there is nothing to do (https://github.com/ansible-collections/community.general/pull/8514)."
diff --git a/plugins/modules/pacman.py b/plugins/modules/pacman.py
@@ -367,8 +367,9 @@ def run(self):
                 self.install_packages(pkgs)
                 self.success()
 
-        # This shouldn't happen...
-        self.fail("This is a bug")
+        # This happens if an empty list has been provided for name
+        self.add_exit_infos(msg='Nothing to do')
+        self.success()
 
     def install_packages(self, pkgs):
         pkgs_to_install = []
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		bugfixes:
		- "paman - do not fail if an empty list of packages has been provided and there is nothing to do (https://github.com/ansible-collections/community.general/pull/8514)."