ec2_transit_gateway_vpc_attachment - Prepare module for migration to amazon.aws #2157

GomathiselviS · 2024-09-24T17:40:08Z

SUMMARY

Refer: https://issues.redhat.com/browse/ACA-1868

This PR refactors and adds necessary documentation to ec2_transit_gateway_vpc_attachment and ec2_transit_gateway_vpc_attachment_info

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

github-actions · 2024-09-24T17:42:59Z

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

softwarefactory-project-zuul · 2024-09-24T18:26:42Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/aa5bf9b0c87540ccbc927d596cf48540

❌ ansible-galaxy-importer FAILURE in 5m 00s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 39s
✔️ ansible-test-splitter SUCCESS in 4m 20s
✔️ integration-community.aws-1 SUCCESS in 26m 30s
Skipped 21 jobs

alinabuzachis

What about adding type hints to the functions?
Also, I noticed that module_utils.transitgateway imports some functionalities from community.aws.plugins.module_utils.ec2, whereas when we migrate this module, we may want to use the utilities from amazon.aws.plugins.module_utils.ec2.
I would suggest checking how these can be replaced/upgraded and if possible.

from ansible_collections.community.aws.plugins.module_utils.ec2 import BaseEc2Manager
from ansible_collections.community.aws.plugins.module_utils.ec2 import Boto3Mixin
from ansible_collections.community.aws.plugins.module_utils.ec2 import Ec2WaiterFactory

softwarefactory-project-zuul · 2024-09-30T20:16:05Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/98c04d9c0dc245c986c7eddf48642551

❌ ansible-galaxy-importer FAILURE in 6m 06s (non-voting)
✔️ build-ansible-collection SUCCESS in 11m 20s
✔️ ansible-test-splitter SUCCESS in 4m 25s
❌ integration-community.aws-1 FAILURE in 14m 34s
Skipped 21 jobs

softwarefactory-project-zuul · 2024-10-01T16:57:04Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/e90bc6608785428c859c5187afe7a17d

✔️ ansible-galaxy-importer SUCCESS in 8m 37s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 52s
✔️ ansible-test-splitter SUCCESS in 5m 21s
❌ integration-community.aws-1 FAILURE in 16m 58s
Skipped 21 jobs

softwarefactory-project-zuul · 2024-10-01T20:04:21Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/83298abd12184455a27436bb1991b49c

✔️ ansible-galaxy-importer SUCCESS in 3m 21s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 40s
✔️ ansible-test-splitter SUCCESS in 4m 20s
❌ integration-community.aws-1 FAILURE in 14m 53s
Skipped 21 jobs

softwarefactory-project-zuul · 2024-10-03T17:41:48Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/fdf2498cc1f04a4493ac2db5815820fa

❌ ansible-galaxy-importer FAILURE in 5m 18s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 56s
✔️ ansible-test-splitter SUCCESS in 4m 39s
❌ integration-community.aws-1 FAILURE in 6m 36s
Skipped 21 jobs

softwarefactory-project-zuul · 2024-10-03T21:11:11Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/ed98ee24b37a40648d03b84cc1d132a1

❌ ansible-galaxy-importer FAILURE in 4m 50s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 59s
✔️ ansible-test-splitter SUCCESS in 4m 28s
❌ integration-community.aws-1 FAILURE in 14m 17s
Skipped 21 jobs

alinabuzachis · 2024-10-04T08:14:35Z

recheck

softwarefactory-project-zuul · 2024-10-04T08:43:14Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/4dfc0fa6a36b4fc98d59d24434ce6225

❌ ansible-galaxy-importer FAILURE in 4m 28s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 58s
✔️ ansible-test-splitter SUCCESS in 4m 35s
❌ integration-community.aws-1 FAILURE in 16m 46s
Skipped 21 jobs

softwarefactory-project-zuul · 2024-10-04T11:53:44Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/f90779264631475890dad41d1947f756

✔️ ansible-galaxy-importer SUCCESS in 3m 29s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 48s
✔️ ansible-test-splitter SUCCESS in 4m 21s
❌ integration-community.aws-1 FAILURE in 15m 14s
Skipped 21 jobs

softwarefactory-project-zuul · 2024-10-14T15:04:03Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/acaa26b721cf4ad390e595f8eacfd9eb

✔️ ansible-galaxy-importer SUCCESS in 3m 19s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 59s
✔️ ansible-test-splitter SUCCESS in 4m 35s
❌ integration-community.aws-1 FAILURE in 16m 25s
Skipped 21 jobs

alinabuzachis · 2024-10-16T14:28:18Z

recheck

softwarefactory-project-zuul · 2024-10-16T14:55:44Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/c3a41552a08545daa778e12a3e757975

❌ ansible-galaxy-importer FAILURE in 5m 04s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 10s
✔️ ansible-test-splitter SUCCESS in 4m 24s
❌ integration-community.aws-1 FAILURE in 16m 03s
Skipped 21 jobs

abikouo

The way the module ec2_transit_gateway_vpc_attachment has been written is a bit complex, it could be simplified to follow the same pattern like others modules.

plugins/modules/ec2_transit_gateway_vpc_attachment.py

plugins/module_utils/transitgateway.py

plugins/modules/ec2_transit_gateway_vpc_attachment.py

plugins/module_utils/transitgateway.py

plugins/modules/ec2_transit_gateway_vpc_attachment_info.py

softwarefactory-project-zuul · 2024-10-16T16:49:17Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/3de40f2a008c4651b9deaf56545216f6

❌ ansible-galaxy-importer FAILURE in 4m 40s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 30s
✔️ ansible-test-splitter SUCCESS in 4m 21s
❌ integration-community.aws-1 FAILURE in 15m 34s
Skipped 21 jobs

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

softwarefactory-project-zuul · 2024-10-17T15:27:28Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/b9ccfdd44b5b4a8ca6f57d08b905e7dc

⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection (non-voting)
❌ build-ansible-collection FAILURE in 5m 24s
✔️ ansible-test-splitter SUCCESS in 4m 16s
⚠️ integration-community.aws-1 SKIPPED Skipped due to failed job build-ansible-collection
Skipped 21 jobs

alinabuzachis · 2024-10-17T15:30:19Z

recheck

softwarefactory-project-zuul · 2024-10-17T16:05:49Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/1f320ae2b9f14d54a5017ead0451020a

✔️ ansible-galaxy-importer SUCCESS in 3m 47s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 07s
✔️ ansible-test-splitter SUCCESS in 4m 00s
✔️ integration-community.aws-1 SUCCESS in 24m 26s
Skipped 21 jobs

softwarefactory-project-zuul · 2024-10-18T10:05:46Z

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/884b1ac39b5c4493b2300fdd3e0b8c6c

❌ ansible-galaxy-importer FAILURE in 4m 47s (non-voting)
✔️ build-ansible-collection SUCCESS in 9m 58s
✔️ ansible-test-splitter SUCCESS in 3m 50s
✔️ integration-community.aws-1 SUCCESS in 26m 09s
Skipped 21 jobs

alinabuzachis reviewed Sep 25, 2024

View reviewed changes

GomathiselviS mentioned this pull request Sep 30, 2024

Add module_util support for transit gateway vpc attachment module ansible-collections/amazon.aws#2314

Merged

alinabuzachis force-pushed the prep_tgw_vpc_att branch from 8c69f03 to 0bde16c Compare October 1, 2024 16:23

alinabuzachis force-pushed the prep_tgw_vpc_att branch 2 times, most recently from f7f287a to f822de7 Compare October 3, 2024 13:15

alinabuzachis force-pushed the prep_tgw_vpc_att branch from 04e248f to ee67c12 Compare October 3, 2024 20:44

GomathiselviS requested a review from abikouo October 4, 2024 14:50

alinabuzachis force-pushed the prep_tgw_vpc_att branch from 6438f5b to 85ba284 Compare October 14, 2024 12:23

abikouo requested changes Oct 16, 2024

View reviewed changes

alinabuzachis requested a review from abikouo October 16, 2024 16:23

abikouo approved these changes Oct 17, 2024

View reviewed changes

alinabuzachis approved these changes Oct 17, 2024

View reviewed changes

GomathiselviS added 4 commits October 17, 2024 17:21

Prepare module for migration to amazon.aws

d977b1e

Add changelog

f46f5d8

Fix format

4aaa04e

Fix sanity error

92671d3

GomathiselviS and others added 9 commits October 17, 2024 17:21

Remove c.aws dependency in imports

ad04d77

Fixups

f4e2656

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

Re-work of the module

3bc9b60

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

Other fixes

cde0575

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

Fis string

b55bbaf

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

Doc fixes

39c7257

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

Fixes

032f5e6

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

Update upon review

5b1f221

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

Update 20240924-fix-documentation-tgw-vpc-att.yml

c218fe5

alinabuzachis force-pushed the prep_tgw_vpc_att branch from eccf4a5 to c218fe5 Compare October 17, 2024 15:21

alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Oct 18, 2024

softwarefactory-project-zuul bot merged commit 7dabfcc into ansible-collections:main Oct 18, 2024
66 of 67 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ec2_transit_gateway_vpc_attachment - Prepare module for migration to amazon.aws #2157

ec2_transit_gateway_vpc_attachment - Prepare module for migration to amazon.aws #2157

GomathiselviS commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

softwarefactory-project-zuul bot commented Sep 24, 2024

alinabuzachis left a comment

softwarefactory-project-zuul bot commented Sep 30, 2024

softwarefactory-project-zuul bot commented Oct 1, 2024

softwarefactory-project-zuul bot commented Oct 1, 2024

softwarefactory-project-zuul bot commented Oct 3, 2024

softwarefactory-project-zuul bot commented Oct 3, 2024

alinabuzachis commented Oct 4, 2024

softwarefactory-project-zuul bot commented Oct 4, 2024

softwarefactory-project-zuul bot commented Oct 4, 2024

softwarefactory-project-zuul bot commented Oct 14, 2024

alinabuzachis commented Oct 16, 2024

softwarefactory-project-zuul bot commented Oct 16, 2024

abikouo left a comment

softwarefactory-project-zuul bot commented Oct 16, 2024

softwarefactory-project-zuul bot commented Oct 17, 2024

alinabuzachis commented Oct 17, 2024

softwarefactory-project-zuul bot commented Oct 17, 2024

softwarefactory-project-zuul bot commented Oct 18, 2024

ec2_transit_gateway_vpc_attachment - Prepare module for migration to amazon.aws #2157

ec2_transit_gateway_vpc_attachment - Prepare module for migration to amazon.aws #2157

Conversation

GomathiselviS commented Sep 24, 2024 • edited Loading

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

github-actions bot commented Sep 24, 2024 • edited Loading

Docs Build 📝

softwarefactory-project-zuul bot commented Sep 24, 2024

alinabuzachis left a comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Sep 30, 2024

softwarefactory-project-zuul bot commented Oct 1, 2024

softwarefactory-project-zuul bot commented Oct 1, 2024

softwarefactory-project-zuul bot commented Oct 3, 2024

softwarefactory-project-zuul bot commented Oct 3, 2024

alinabuzachis commented Oct 4, 2024

softwarefactory-project-zuul bot commented Oct 4, 2024

softwarefactory-project-zuul bot commented Oct 4, 2024

softwarefactory-project-zuul bot commented Oct 14, 2024

alinabuzachis commented Oct 16, 2024

softwarefactory-project-zuul bot commented Oct 16, 2024

abikouo left a comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Oct 16, 2024

softwarefactory-project-zuul bot commented Oct 17, 2024

alinabuzachis commented Oct 17, 2024

softwarefactory-project-zuul bot commented Oct 17, 2024

softwarefactory-project-zuul bot commented Oct 18, 2024

GomathiselviS commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading