community.aws.elb_target Draining Targets Unexpectedly

[AaronJaegerVA]

Summary

When I run community.aws.elb_target to add targets to an existing target group, it works well; however, when I run the same job again, the targets I request are drained instead of being left alone. I'm not sure how to debug this.

Issue Type

Bug Report

Component Name

elb_target

Ansible Version

bash-4.4# ansible --version
/usr/local/lib/python3.8/site-packages/paramiko/transport.py:219: CryptographyDeprecationWarning: Blowfish has been deprecated
  "class": algorithms.Blowfish,
ansible [core 2.13.0]
  config file = None
  configured module search path = ['/home/runner/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python3.8/site-packages/ansible
  ansible collection location = /home/runner/.ansible/collections:/usr/share/ansible/collections
  executable location = /usr/local/bin/ansible
  python version = 3.8.12 (default, Sep 16 2021, 10:46:05) [GCC 8.5.0 20210514 (Red Hat 8.5.0-3)]
  jinja version = 3.1.2
  libyaml = True

Collection Versions

# /usr/share/ansible/collections/ansible_collections
Collection         Version
------------------ -------
amazon.aws         3.2.0  
ansible.controller 4.1.2  
community.aws      3.2.1  
kubernetes.core    2.2.3  
redhat.openshift   2.1.0

AWS SDK versions

bash-4.4# pip show boto boto3 botocore
Name: boto
Version: 2.49.0
Summary: Amazon Web Services Library
Home-page: https://github.com/boto/boto/
Author: Mitch Garnaat
Author-email: mitch@garnaat.com
License: MIT
Location: /usr/local/lib/python3.8/site-packages
Requires: 
Required-by: 
---
Name: boto3
Version: 1.23.9
Summary: The AWS SDK for Python
Home-page: https://github.com/boto/boto3
Author: Amazon Web Services
Author-email: 
License: Apache License 2.0
Location: /usr/local/lib/python3.8/site-packages
Requires: botocore, jmespath, s3transfer
Required-by: 
---
Name: botocore
Version: 1.26.9
Summary: Low-level, data-driven core of boto 3.
Home-page: https://github.com/boto/botocore
Author: Amazon Web Services
Author-email: 
License: Apache License 2.0
Location: /usr/local/lib/python3.8/site-packages
Requires: jmespath, python-dateutil, urllib3
Required-by: boto3, s3transfer```


### Configuration

```console (paste below)
$ ansible-config dump --only-changed
(no output)

OS / Environment

RHEL8 UBI EE

Steps to Reproduce

- name: Register instance target(s) to {{ use_environment }}-iris-mail-tgrp target group
  community.aws.elb_target:
    aws_access_key: "{{ cred_aws_access_key }}"
    aws_secret_key: "{{ cred_aws_secret_key }}"
    region: "{{ aws_region }}"
    target_group_name: "{{ use_environment }}-iris-mail-tgrp"
    target_id: "{{ item.instances[0].instance_id }}"
    target_port: "{{ scm_iris_mail_target_port }}"
    state: present
    debug_botocore_endpoint_logs: true
  loop: "{{ worker_instances.results }}"

Expected Results

I expect targets that already exist to be left alone.

Actual Results

Existing targets go into "draining" status and eventually disappear.

Code of Conduct

• I agree to follow the Ansible Code of Conduct

[ansibullbot]

Files identified in the description:

• [plugins/modules/elb_target.py](https://github.com/['ansible-collections/amazon.aws', 'ansible-collections/community.aws', 'ansible-collections/community.vmware']/blob/main/plugins/modules/elb_target.py)

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibullbot]

cc @jillr @markuman @s-hertel @tremble
click here for bot help

[AaronJaegerVA]

This was operator error 😭

The elb_target_group task to create the target group, which I run before the elb_target task, did not have modify_targets: no, so when the play is run a second time, the elb_target_group task below wipes out all targets. When the subsequent elb_target task runs with the same targets specified, they technically still exist (they are Status: draining) so elb_target thinks everything is ok; however, the end result was that the targets drained and disappeared a bit later.

After adding modify_targets: no in elb_target_group, idempotence is achieved and targets remain in tact.

- name: Create {{ use_environment }}-iris-mail-tgrp target group
  community.aws.elb_target_group:
    aws_access_key: "{{ cred_aws_access_key }}"
    aws_secret_key: "{{ cred_aws_secret_key }}"
    region: "{{ aws_region }}"
    name: "{{ use_environment }}-iris-mail-tgrp"
    protocol: tcp
    port: "{{ scm_iris_mail_listener_port }}"
    vpc_id: "{{ aws_vpc_id }}"
    state: present
    modify_targets: no
    debug_botocore_endpoint_logs: true

[markuman]

Maybe you don't need the elb_target module at all?

[AaronJaegerVA]

Maybe you don't need the elb_target module at all?

Yeah, I could probably refactor and one-task it. 😉