Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to sanity ignore files explaining why things are ignored #287

Merged
merged 1 commit into from
Mar 6, 2021
Merged

Add comments to sanity ignore files explaining why things are ignored #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add comments to ignores files explaining why we're ignoring things
  • Loading branch information
@tremble
tremble committed Mar 6, 2021
commit 4e7037f8bf628427bd4bb7b45e78daab1c465048
12 changes: 6 additions & 6 deletions tests/sanity/ignore-2.10.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
plugins/modules/ec2_tag.py validate-modules:parameter-state-invalid-choice
plugins/modules/ec2_vol.py validate-modules:parameter-state-invalid-choice
tests/utils/shippable/check_matrix.py replace-urlopen
tests/utils/shippable/timing.py shebang
plugins/module_utils/compat/_ipaddress.py no-assert
plugins/module_utils/compat/_ipaddress.py no-unicode-literals
plugins/modules/ec2_tag.py validate-modules:parameter-state-invalid-choice # Deprecated choice that can't be removed until 2022
plugins/modules/ec2_vol.py validate-modules:parameter-state-invalid-choice # Deprecated choice that can't be removed until 2022
plugins/module_utils/compat/_ipaddress.py no-assert # Vendored library
plugins/module_utils/compat/_ipaddress.py no-unicode-literals # Vendored library
tests/utils/shippable/check_matrix.py replace-urlopen # Standalone script used as part of testing
tests/utils/shippable/timing.py shebang # Standalone script used as part of testing
18 changes: 9 additions & 9 deletions tests/sanity/ignore-2.11.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
plugins/modules/ec2_tag.py validate-modules:parameter-state-invalid-choice
plugins/modules/ec2_vol.py validate-modules:parameter-state-invalid-choice
tests/utils/shippable/check_matrix.py replace-urlopen
tests/utils/shippable/timing.py shebang
plugins/module_utils/compat/_ipaddress.py no-assert
plugins/module_utils/compat/_ipaddress.py no-unicode-literals
plugins/module_utils/cloud.py pylint:isinstance-second-argument-not-valid-type
plugins/module_utils/cloudfront_facts.py pylint:unnecessary-comprehension
plugins/module_utils/core.py pylint:property-with-parameters
plugins/modules/ec2_tag.py validate-modules:parameter-state-invalid-choice # Deprecated choice that can't be removed until 2022
plugins/modules/ec2_vol.py validate-modules:parameter-state-invalid-choice # Deprecated choice that can't be removed until 2022
plugins/module_utils/cloudfront_facts.py pylint:unnecessary-comprehension # New test simple fix - https://github.com/ansible-collections/amazon.aws/pull/291
plugins/module_utils/cloud.py pylint:isinstance-second-argument-not-valid-type # New test simple fix - https://github.com/ansible-collections/amazon.aws/pull/291
plugins/module_utils/compat/_ipaddress.py no-assert # Vendored library
plugins/module_utils/compat/_ipaddress.py no-unicode-literals # Vendored library
plugins/module_utils/core.py pylint:property-with-parameters # Breaking change required to fix - https://github.com/ansible-collections/amazon.aws/pull/290
tests/utils/shippable/check_matrix.py replace-urlopen # Standalone script used as part of testing
tests/utils/shippable/timing.py shebang # Standalone script used as part of testing
38 changes: 19 additions & 19 deletions tests/sanity/ignore-2.9.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
plugins/modules/aws_az_info.py pylint:ansible-deprecated-no-version
plugins/modules/aws_caller_info.py pylint:ansible-deprecated-no-version
plugins/modules/cloudformation_info.py pylint:ansible-deprecated-no-version
plugins/modules/ec2.py pylint:ansible-deprecated-no-version
plugins/modules/ec2_ami_info.py pylint:ansible-deprecated-no-version
plugins/modules/ec2_eni_info.py pylint:ansible-deprecated-no-version
plugins/modules/ec2_group_info.py pylint:ansible-deprecated-no-version
plugins/modules/ec2_snapshot_info.py pylint:ansible-deprecated-no-version
plugins/modules/ec2_tag.py pylint:ansible-deprecated-no-version
plugins/modules/ec2_vol.py pylint:ansible-deprecated-no-version
plugins/modules/ec2_vol_info.py pylint:ansible-deprecated-no-version
plugins/modules/ec2_vpc_dhcp_option_info.py pylint:ansible-deprecated-no-version
plugins/modules/ec2_vpc_net_info.py pylint:ansible-deprecated-no-version
plugins/modules/ec2_vpc_subnet_info.py pylint:ansible-deprecated-no-version
plugins/module_utils/ec2.py pylint:ansible-deprecated-no-version
tests/utils/shippable/check_matrix.py replace-urlopen
tests/utils/shippable/timing.py shebang
plugins/module_utils/compat/_ipaddress.py no-assert
plugins/module_utils/compat/_ipaddress.py no-unicode-literals
plugins/modules/aws_az_info.py pylint:ansible-deprecated-no-version # We use dates for deprecations, Ansible 2.9 only supports this for compatability
plugins/modules/aws_caller_info.py pylint:ansible-deprecated-no-version # We use dates for deprecations, Ansible 2.9 only supports this for compatability
plugins/modules/cloudformation_info.py pylint:ansible-deprecated-no-version # We use dates for deprecations, Ansible 2.9 only supports this for compatability
plugins/modules/ec2_ami_info.py pylint:ansible-deprecated-no-version # We use dates for deprecations, Ansible 2.9 only supports this for compatability
plugins/modules/ec2_eni_info.py pylint:ansible-deprecated-no-version # We use dates for deprecations, Ansible 2.9 only supports this for compatability
plugins/modules/ec2_group_info.py pylint:ansible-deprecated-no-version # We use dates for deprecations, Ansible 2.9 only supports this for compatability
plugins/modules/ec2.py pylint:ansible-deprecated-no-version # We use dates for deprecations, Ansible 2.9 only supports this for compatability
plugins/modules/ec2_snapshot_info.py pylint:ansible-deprecated-no-version # We use dates for deprecations, Ansible 2.9 only supports this for compatability
plugins/modules/ec2_tag.py pylint:ansible-deprecated-no-version # We use dates for deprecations, Ansible 2.9 only supports this for compatability
plugins/modules/ec2_vol_info.py pylint:ansible-deprecated-no-version # We use dates for deprecations, Ansible 2.9 only supports this for compatability
plugins/modules/ec2_vol.py pylint:ansible-deprecated-no-version # We use dates for deprecations, Ansible 2.9 only supports this for compatability
plugins/modules/ec2_vpc_dhcp_option_info.py pylint:ansible-deprecated-no-version # We use dates for deprecations, Ansible 2.9 only supports this for compatability
plugins/modules/ec2_vpc_net_info.py pylint:ansible-deprecated-no-version # We use dates for deprecations, Ansible 2.9 only supports this for compatability
plugins/modules/ec2_vpc_subnet_info.py pylint:ansible-deprecated-no-version # We use dates for deprecations, Ansible 2.9 only supports this for compatability
plugins/module_utils/compat/_ipaddress.py no-assert # Vendored library
plugins/module_utils/compat/_ipaddress.py no-unicode-literals # Vendored library
plugins/module_utils/ec2.py pylint:ansible-deprecated-no-version # We use dates for deprecations, Ansible 2.9 only supports this for compatability
tests/utils/shippable/check_matrix.py replace-urlopen # Standalone script used as part of testing
tests/utils/shippable/timing.py shebang # Standalone script used as part of testing