Minor typing fixups #2497
Merged
Minor typing fixups #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
abikouo
approved these changes
Feb 3, 2025
Co-authored-by: Bikouo Aubin <79859644+abikouo@users.noreply.github.com>
softwarefactory-project-zuul
bot
merged commit 2564b0d
into
ansible-collections:main
48 of 49 checks passed
Backport to stable-9: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 2564b0d on top of patchback/backports/stable-9/2564b0d90eb6abec6c8313a047210c5abfcbb561/pr-2497 Backporting merged PR #2497 into main
🤖 @patchback |
|
Depends on #2478 to backport to stable-9 |
GomathiselviS
pushed a commit
to GomathiselviS/amazon.aws
that referenced
this pull request
Feb 3, 2025
SUMMARY module_utils.botocore - fixed type aliasing. module_utils.botocore - avoid assigning unused parts of exc_info return. plugin_utils.botocore - fixed type aliasing. module_utils._s3 - explicitly cast super to the parent type. module_utils.exceptions - avoid assigning unused parts of exc_info return. ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/module_utils/_s3/common.py plugins/module_utils/botocore.py plugins/module_utils/exceptions.py plugins/plugin_utils/botocore.py ADDITIONAL INFORMATION Reviewed-by: Bikouo Aubin (cherry picked from commit 2564b0d)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Feb 3, 2025
SUMMARY module_utils.botocore - fixed type aliasing. module_utils.botocore - avoid assigning unused parts of exc_info return. plugin_utils.botocore - fixed type aliasing. module_utils._s3 - explicitly cast super to the parent type. module_utils.exceptions - avoid assigning unused parts of exc_info return. ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/module_utils/_s3/common.py plugins/module_utils/botocore.py plugins/module_utils/exceptions.py plugins/plugin_utils/botocore.py ADDITIONAL INFORMATION Reviewed-by: Bikouo Aubin (cherry picked from commit 2564b0d) SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Bikouo Aubin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/_s3/common.py
plugins/module_utils/botocore.py
plugins/module_utils/exceptions.py
plugins/plugin_utils/botocore.py
ADDITIONAL INFORMATION