ec2_instance -> app_callback -> set_password doesn't work

[pluto00987]

Summary

Setting the 'set_password' option doesn't product the expected result.

Problem seems to be here

amazon.aws/plugins/modules/ec2_instance.py

Line 1236 in 8acb076

passwd=params.get('aap_callback').get('set_passwd'),

where it's passing 'set_passwd' when the actual variable name is 'set_password' set here

amazon.aws/plugins/modules/ec2_instance.py

Line 2046 in 8acb076

set_password=dict(type='str', no_log=True),

Seems to be a typo included in #1199 as it worked prior to that.

Issue Type

Bug Report

Component Name

ec2_instance

Ansible Version

$ ansible --version

Collection Versions

version 5.4.0
Also present in main branch

AWS SDK versions

$ pip show boto boto3 botocore

Configuration

$ ansible-config dump --only-changed

OS / Environment

No response

Steps to Reproduce

Expected Results

A line should be present in user_data for the new instance, which sets the local admin password

Actual Results

It's not there

Code of Conduct

• I agree to follow the Ansible Code of Conduct

[pluto00987]

Neglected to mention, this is for windows instances, with 'windows: true' also set under app_callback.

[ansibullbot]

cc @jillr @ryansb @s-hertel @tremble
click here for bot help

[alinabuzachis]

@pluto00987 Thank you for raising this issue. Would you be willing to open a Pull Request with a fix?

[UNiXMIT]

Nooooooo this has completely broken my Ansible playbooks to create Windows instances. Is there a workaround so that I can still automate creation of my Windows instances?