Skip to content

Commit

Permalink
CHE-5944. Fix editor keybindings displaying
Browse files Browse the repository at this point in the history
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
  • Loading branch information
RomanNikitenko committed Aug 21, 2017
1 parent b0fb35b commit e095436
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
package org.eclipse.che.ide.editor.preferences;

import com.google.gwt.user.client.ui.AcceptsOneWidget;
import com.google.gwt.user.client.ui.FlowPanel;
import com.google.gwt.user.client.ui.SimplePanel;
import com.google.inject.Inject;
import com.google.inject.Singleton;
import java.util.Set;
Expand Down Expand Up @@ -46,10 +48,13 @@ public boolean isDirty() {

@Override
public void go(final AcceptsOneWidget container) {
AcceptsOneWidget preferencesContainer = view.getEditorPreferencesContainer();

editorPreferenceSections.forEach(section -> section.go(preferencesContainer));

FlowPanel preferencesContainer = view.getEditorPreferencesContainer();
editorPreferenceSections.forEach(
section -> {
SimplePanel sectionPanel = new SimplePanel();
section.go(sectionPanel);
preferencesContainer.add(sectionPanel);
});
container.setWidget(view);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@
*/
package org.eclipse.che.ide.editor.preferences;

import com.google.gwt.user.client.ui.AcceptsOneWidget;
import com.google.gwt.user.client.ui.FlowPanel;
import com.google.gwt.user.client.ui.IsWidget;

/** View interface for the preference page for the editor preferences. */
public interface EditorPreferenceView extends IsWidget {
AcceptsOneWidget getEditorPreferencesContainer();
FlowPanel getEditorPreferencesContainer();
}
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,9 @@
import com.google.gwt.core.client.GWT;
import com.google.gwt.uibinder.client.UiBinder;
import com.google.gwt.uibinder.client.UiField;
import com.google.gwt.user.client.ui.AcceptsOneWidget;
import com.google.gwt.user.client.ui.Composite;
import com.google.gwt.user.client.ui.FlowPanel;
import com.google.gwt.user.client.ui.ScrollPanel;
import com.google.gwt.user.client.ui.SimplePanel;
import com.google.inject.Inject;

/** Implementation of the {@link EditorPreferenceView}. */
Expand All @@ -35,10 +33,8 @@ public EditorPreferenceViewImpl() {
}

@Override
public AcceptsOneWidget getEditorPreferencesContainer() {
SimplePanel container = new SimplePanel();
editorPreferencesContainer.add(container);
return container;
public FlowPanel getEditorPreferencesContainer() {
return editorPreferencesContainer;
}

/** UI binder interface for the {@link EditorPreferenceViewImpl} component. */
Expand Down

0 comments on commit e095436

Please sign in to comment.