Skip to content

Commit

Permalink
Workaround for ImageStreamTags issue on OpenShift 3.6
Browse files Browse the repository at this point in the history
Minor adjustment to how image name is set when creating a
workspace on OpenShift.

On OpenShift 3.6, it seems that using an ImageStreamTag
in a Deployment spec causes the deployment to have null status,
which causes kubernetes-client to throw an NPE.

We still need to decide if this is to be a longer term solution,
and if removing ImageStreamTags completely is a good option

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
  • Loading branch information
amisevsk authored and ibuziuk committed Aug 17, 2017
1 parent 5a2adf1 commit 6792b2b
Showing 1 changed file with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,9 @@ public ContainerCreated createContainer(CreateContainerParams createContainerPar
openShiftCheProjectName,
imageStreamTagPullSpec);

// Workaround for ImageStreamTags issue
dockerPullSpec = imageStreamTag.getTag().getFrom().getName();

ContainerConfig containerConfig = createContainerParams.getContainerConfig();
ImageConfig imageConfig = inspectImage(InspectImageParams.create(imageForDocker)).getConfig();

Expand Down

0 comments on commit 6792b2b

Please sign in to comment.